Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect CommandSourceStack creation for players #11563

Closed
wants to merge 1 commit into from
Closed

Fix incorrect CommandSourceStack creation for players #11563

wants to merge 1 commit into from

Conversation

notTamion
Copy link
Contributor

fixes #11562

@notTamion notTamion requested a review from a team as a code owner November 2, 2024 09:36
@Machine-Maker
Copy link
Member

On a slightly related note... The API still allows dispatching Commands from an Entity. These commands will be executed with the NULL CommandSource, this is kind of a change? Do we care?

@notTamion
Copy link
Contributor Author

Fixed by upstream

@notTamion notTamion closed this Nov 3, 2024
@notTamion notTamion deleted the fix-commandsourcestack-creation branch November 5, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytv kennytv kennytv approved these changes

@Machine-Maker Machine-Maker Machine-Maker approved these changes

@electronicboy electronicboy electronicboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Paper PR Queue
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.21.3] Player Perform Command API Failing
4 participants
@notTamion @Machine-Maker @electronicboy @kennytv