Fix NPE with enchantable #11557
Merged
Fix NPE with enchantable #11557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulu13022002
force-pushed
the
fix/enchantable-misc
branch
4 times, most recently
from
d6d3c10
to
c87bd4a
Compare
lynxplay
force-pushed
the
fix/enchantable-misc
branch
from
c87bd4a
to
a09f9c4
Compare
electronicboy
approved these changes
Nov 5, 2024
lynxplay
approved these changes
Nov 7, 2024
lynxplay
force-pushed
the
fix/enchantable-misc
branch
from
a09f9c4
to
dbe0fae
Compare
Machine-Maker
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ItemMeta#setEnchantable is nullable but yet passing null result in an NPE on Paper.
Also fixes a bunch of leftover during the update:
migrate the generated content to jspecify, make EnchantmentKeys#create public
undeprecate some fields on Registry
register instrument registry as data driven registry