Update Eigencraft patch to 1.21.3 #11553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytv
approved these changes
Nov 3, 2024
SpaceWalkerRS
force-pushed
the
1.21.3/eigencraft
branch
from
9d670b3 to
f87f6ae
Compare
electronicboy
approved these changes
Nov 3, 2024
SpaceWalkerRS
force-pushed
the
1.21.3/eigencraft
branch
2 times, most recently
from
438ce61 to
be39d24
Compare
Machine-Maker
approved these changes
Nov 9, 2024
Machine-Maker
force-pushed
the
1.21.3/eigencraft
branch
from
be39d24 to
5eb61f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from updating to 1.21.3 I also took the liberty to remove some code that has not been necessary since 1.13. Specifically, I mean the implementation of
calculateCurrentChangesinRedStoneWireBlock. The method signature alone tells me it's code from 1.12 or older that's been kept and updated, but the only optimization it brings is one that Vanilla itself introduced in 1.13: allowing wires to decrease in power level by more than 1 at a time.