Re-add exact choice shapeless support #11546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
force-pushed
the
fix/update-exact-choice
branch
from
b53eba8
to
3596160
Compare
|
Tested with exact choice shapeless recipes. As always, there are a few caveats with how these work in relation to the client. If your exact choice recipe doesn't include ingredients with damaged items, enchanted items, or "custom_name" items (NOT item_name), then they should work 100%. If you have ingredients that are damaged, enchanted, or have "custom_name" (displayName) NOT "item_name" (itemName), then the recipe book will show them as uncraftable and multiple clicks on the item won't keep adding 1 "recipe" to the grid, you get one click (or shift click). |
kennytv
approved these changes
Nov 6, 2024
patches/server/1058-Improve-exact-choice-recipe-ingredients.patch
Outdated
Show resolved
Hide resolved
patches/server/1058-Improve-exact-choice-recipe-ingredients.patch
Outdated
Show resolved
Hide resolved
patches/server/1058-Improve-exact-choice-recipe-ingredients.patch
Outdated
Show resolved
Hide resolved
Machine-Maker
force-pushed
the
fix/update-exact-choice
branch
from
3596160
to
72e020a
Compare
lynxplay
approved these changes
Nov 9, 2024
Machine-Maker
force-pushed
the
fix/update-exact-choice
branch
from
71de737
to
6602292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.