Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update patches to handle vineflower decompiler #10406

Merged
merged 13 commits into from
Apr 12, 2024
Merged

Update patches to handle vineflower decompiler #10406

merged 13 commits into from
Apr 12, 2024

Conversation

Machine-Maker
Copy link
Member

No description provided.

@jpenilla jpenilla marked this pull request as ready for review April 11, 2024 20:13
@jpenilla jpenilla requested a review from a team as a code owner April 11, 2024 20:13
@kennytv kennytv added the priority: high This issue is either a gamebreaking bug or crash and needs to be addressed soon. label Apr 12, 2024
kennytv
kennytv approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should start a server and see if things around collision work as expected, but otherwise should be good

@Machine-Maker Machine-Maker merged commit 526795b into master Apr 12, 2024
5 checks passed
@Machine-Maker Machine-Maker deleted the feat/vineflower branch April 12, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maintenancer Maintenancer Maintenancer left review comments

@jpenilla jpenilla jpenilla approved these changes

@kennytv kennytv kennytv approved these changes

@lynxplay lynxplay lynxplay approved these changes

Assignees
No one assigned
Labels
priority: high This issue is either a gamebreaking bug or crash and needs to be addressed soon.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Machine-Maker @jpenilla @kennytv @lynxplay @Maintenancer