When you open a Treasure chest the server crashes (Genericially: Server searching for generation features causes watchdog to time out) #2312
Comments
zachbr
changed the title
|
Since updated my server to Paper 135 (1.14.4) sometimes it get stuck completely (entities not moving, containers not opening, chat not working, etc...) and this thread dump appears in console: https://pastebin.com/LJWvcLkc No plugins at a glance on dump. I see Loot and 'findNearestMap' on it, maybe something related to 'auto-replenish' (true in my server) or 'treasure-maps-return-already-discovered' (false). |
|
Still on Paper 135 and the problem persist. But what I'm seeing is that everytime someone find a treasure map the server lags (maybe because chunk loading and poor performance of 1.14, related to this: #1438). Sometimes that lag persist and console start showing thread dump, other times is faster and no dump happens and with worse hardware I think it could crash the server like the original post in this issue. Here is another dump: https://pastebin.com/3BiWtMgN |
|
Can you provide a seed and location where this happens? |
|
Confirmed to still be occurring in Paper-148. Occurs with any chest that could potentially contain a treasure map (ie a sunken ship treasure chest or an underwater ruin). Only seems to occur in certain regions, but not others. See #2379 for a level.dat and region files where the error occurs and specific coordinates of chests that cause the crash. Here's another thread dump from when the error occurred on Paper-148: https://pastebin.com/mnNNd5cu |
|
The issue here appears to be the fact that mojang is just searching for such a large radius and is blowing itself up with chunk loading as it's looking, it's pretty much some level of praying that the structures aren't too far in; Suggested workaround will pretty much be to try and replace the vanilla loot tables to not use maps, as for a fix... :S |
|
Confirmed that this issue is not unique to paper and actually occurs on SSP as well. Made a ticket report here on MC's issue tracker. For those who want a workaround, please find a datapack that replaces treasure maps here. For sunken ships, the pack replaces treasure maps with a heart of the sea, diamonds, books, or a blank map; for large ruins, the pack replaces treasure maps with a chance to generate either a diamond or a heart of the sea; and for small ruins, the pack just gets rid of the treasure map. |
|
Temporarily "fixed" it, by removing Lootable tile logic. |
|
There is already a data pack posted in this topic which will "fix" the
issue less invasively, no need for alternative builds
…On Sat, 2 Nov 2019, 21:41 Xayanix, ***@***.***> wrote:
Temporarily "fixed" it, by removing Lootable tile logic.
Here is download link for anyone who has same problem:
https://anonymousfiles.io/8IjBERtT/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2312?email_source=notifications&email_token=AAJMAZDASQLROJLNC3JJIE3QRXXZTA5CNFSM4ICUMAE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC5FU6A#issuecomment-549083768>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJMAZBS43HNULGJJJVIUFTQRXXZTANCNFSM4ICUMAEQ>
.
|
|
If anyone wants to try it out, here is a patch which adds the ability to limit the finding of any feature/structure to only generated chunks which might help a bit in cases of non-pregenerated worlds (but would still have the impact of loading chunks on the main thread). Please note that this is almost fully untested. (And see the message for more potential issues) |
|
Here is another patch that tries to do the generation of the treasure maps async. It seems to work out fine most of the times but there is the possibility of the data not getting applied properly to the item if something interacts with it (or possibly if the chunk gets unloaded) before the actual structure location was found. This should only lead to the item not having the decoration marking the place but other issues might turn up. If anyone wants to use it make sure to properly test and be aware of the risks. (E.g. your server randomly crashing :P) |
electronicboy
changed the title
|
Having this issue still. Will this eventually be patched into paper? |
|
Proper fix is being worked on, but it will take time. If the fix is too complex, it might be abandoned.. If you want to keep up to date on the progress, check the discord. |
This is done by using the same seed checking functionality that is used by the server when generating these features instead of loading all chunks around the location to check if they have the feature. The chunk is only loaded after the generator confirmed a feature should be there. The only downside of this is that it breaks once the seed or generator changes but this should usually not happen but a config option is available anyways.
Proximyst
added
type: bug
|
Still causing crashes and bugged states for my server. |
|
https://paper-chan.moe/paper-optimization/ - ctrl-f "treasure maps" |
|
that helps, thanks 👍 |
The text was updated successfully, but these errors were encountered: