Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize-explosions no longer works correctly in 1.21.3/2 #11539

Closed
Samsuik opened this issue Oct 31, 2024 · 0 comments · Fixed by #11541
Closed

optimize-explosions no longer works correctly in 1.21.3/2 #11539

Samsuik opened this issue Oct 31, 2024 · 0 comments · Fixed by #11541
Assignees
Labels
priority: high This issue is either a gamebreaking bug or crash and needs to be addressed soon. status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. version: 1.21.3 Game version 1.21.3

Comments

@Samsuik
Copy link

Samsuik commented Oct 31, 2024

Expected behavior

The same behaviour prior to the 1.21.3/2 update.

Observed/Actual behavior

The explosionDensityCache is not cleared anymore after the 1.21.3/2 update which causes issues with explosions interacting with entities

Steps/models to reproduce

/fill -17 -55 -72 -17 -55 -70 minecraft:bedrock
# Observe how explosions interact with this entity
/summon minecraft:tnt -16.5 -54.00 -69.5 {fuse:10000}
/setblock -17 -54 -71 glass
/summon minecraft:tnt -16.5 -54.00 -71.5 {fuse:10}
# The entity will not move even though the obstruction has been cleared.
/summon minecraft:tnt -16.5 -54.00 -71.5 {fuse:10}

Plugin and Datapack List

n/a

Paper version

Checking version, please wait...
This server is running Paper version 1.21.3-1-master@f273e6e (2024-10-31T17:32:23Z) (Implementing API version 1.21.3-R0.1-SNAPSHOT)
You are running the latest version

Other

The optimize-explosions patch was not applied correctly during the 1.21.3/2 update. The line that clears the explosionDensityCache was moved into the MinecraftServer constructor before the update it was ran every tick in the tickChildren method.

https://github.com/PaperMC/Paper/blob/ver/1.21.1/patches/server/0043-Optimize-explosions.patch
https://github.com/PaperMC/Paper/blob/master/patches/server/0043-Optimize-explosions.patch

@Samsuik Samsuik added status: needs triage type: bug Something doesn't work as it was intended to. labels Oct 31, 2024
@papermc-sniffer papermc-sniffer bot added the version: 1.21.3 Game version 1.21.3 label Oct 31, 2024
@papermc-projects papermc-projects bot moved this to 🕑 Needs Triage in Issues: Bugs Oct 31, 2024
@lynxplay lynxplay added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. priority: high This issue is either a gamebreaking bug or crash and needs to be addressed soon. and removed status: needs triage labels Oct 31, 2024
@papermc-projects papermc-projects bot moved this from 🕑 Needs Triage to ✅ Accepted in Issues: Bugs Oct 31, 2024
NoahvdAa added a commit to NoahvdAa/Paper that referenced this issue Oct 31, 2024
@NoahvdAa NoahvdAa self-assigned this Oct 31, 2024
@github-project-automation github-project-automation bot moved this from ✅ Accepted to Done in Issues: Bugs Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high This issue is either a gamebreaking bug or crash and needs to be addressed soon. status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. version: 1.21.3 Game version 1.21.3
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants