Merge pull request payara#3174 from Pandrex247/PAYARA-3114

PAYARA-3114 Remove quicklook summary & add to gitignore, and fix Con…
Pandrex247 · Oct 10, 2018 · f9f1d5c · f9f1d5c
1 parent 59deae5
commit f9f1d5c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/.gitignore b/.gitignore
@@ -20,3 +20,4 @@ appserver/extras/arquillian-containers/payara-common/dependency-reduced-pom.xml
 /appserver/tests/quicklook/cluster/clustersetup/nbproject/
 /nucleus/payara-modules/service-exemplar/nbproject/
 /nucleus/admin/server-mgmt/nbproject/
+appserver/tests/quicklook/quicklook_summary.txt
diff --git a/appserver/tests/quicklook/quicklook_summary.txt b/appserver/tests/quicklook/quicklook_summary.txt
diff --git a/...eus/payara-modules/opentracing-adapter/src/main/java/fish/payara/opentracing/OTScope.java b/...eus/payara-modules/opentracing-adapter/src/main/java/fish/payara/opentracing/OTScope.java
@@ -48,7 +48,7 @@
 import java.util.Map;
 
 /**
- * Implementation of Scope from Opentracing.
+ * Implementation of Scope from OpenTracing.
  * 
  * @author jonathan coustick
  * @since 5.183
@@ -70,7 +70,8 @@ public void close() {
             if (allSpans.get(span)){
                 span.finish();
             }
-            allSpans.remove(span);//prevents scope holding on a reference to old spans
+            // Prevent scope holding on a reference to old spans
+            keys.remove();
         }
     }
 
@@ -79,7 +80,7 @@ public Span span() {
         return currentSpan;
     }
 
-    //package private - used only by ScopeManager
+    // Package private - used only by ScopeManager
     void setSpan(Span span, Boolean finishOnClose){
         allSpans.put(span, finishOnClose);
         currentSpan = span;