Add manual flush

[evalott100]

Corresponding ioc code here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7117d68) 96.35% compared to head (3693df5) 96.43%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   96.35%   96.43%   +0.07%     
==========================================
  Files          12       12              
  Lines        1180     1205      +25     
==========================================
+ Hits         1137     1162      +25     
  Misses         43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[evalott100]

@AlexanderWells-diamond how do you feel about deprecating python 3.7? pandablocks-ioc is currently minimum 3.10 so I think it might be time.

[AlexanderWells-diamond]

Overall seems ok, but I've got a few questions that I would like answers to before approve/reject.

Also, looking at commit afe9d6a, the commit message is very confusing. It talks about adding PVs, and PVI, neither of which are anything to do with this repository?

[AlexanderWells-diamond]

@AlexanderWells-diamond how do you feel about deprecating python 3.7? pandablocks-ioc is currently minimum 3.10 so I think it might be time.

That depends entirely on whether we want/need to keep supporting our Diamond-internal use, which is still technically on Python 3.7.2. I have no strong opinions, especially as other related repos have already broken that, but it's worth at least a moment's thought before we do so.

[evalott100]

@AlexanderWells-diamond how do you feel about deprecating python 3.7? pandablocks-ioc is currently minimum 3.10 so I think it might be time.

That depends entirely on whether we want/need to keep supporting our Diamond-internal use, which is still technically on Python 3.7.2. I have no strong opinions, especially as other related repos have already broken that, but it's worth at least a moment's thought before we do so.

I think it would be a good idea to deprecate 3.7 now rather than write a workaround to have asyncio.exceptions be imported differently on it. I'd argue we should keep versions which are end-of-life around so long as they work without having to write extra code to support them.

[AlexanderWells-diamond]

I think it would be a good idea to deprecate 3.7 now rather than write a workaround to have asyncio.exceptions be imported differently on it. I'd argue we should keep versions which are end-of-life around so long as they work without having to write extra code to support them.

Isn't just using asyncio.TimeoutError, as is done on line 156 already, a fully compatible way of referring to that exception?

You do make a fair point about end of life. My only defence of keeping using that Python version is that it's still the "standard" at Diamond.

[evalott100]

I think it would be a good idea to deprecate 3.7 now rather than write a workaround to have asyncio.exceptions be imported differently on it. I'd argue we should keep versions which are end-of-life around so long as they work without having to write extra code to support them.

Isn't just using asyncio.TimeoutError, as is done on line 156 already, a fully compatible way of referring to that exception?

You do make a fair point about end of life. My only defence of keeping using that Python version is that it's still the "standard" at Diamond.

Ah yep my mistake we can go for asyncio.TimeoutError

[AlexanderWells-diamond]

Code seems fine, a few possible enhancements to it. I've also got a set of comments about the generated documentation.

It's not exactly relevant to this PR, but it seems that the docs and pytest targets will no longer run on RHEL8 with Python 3.7.2. Something has bumped versions of various dependencies, that means we now see this error:

ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'OpenSSL 1.0.2o-fips  27 Mar 2018'. See: https://github.com/urllib3/urllib3/issues/2168

I'm uncertain if this is strictly an issue in Python 3.7, which we currently declare support for in pyproject.toml, or a specific issue to the Diamond version of Python.

[evalott100]

I'm uncertain if this is strictly an issue in Python 3.7, which we currently declare support for in pyproject.toml, or a specific issue to the Diamond version of Python.

Thanks for the review! I'll investigate this locally.

Tested

Docs and pytest work locally for me on redhat 8.8 with python 3.7.3

[AlexanderWells-diamond]

Looks good to me

[evalott100]

@AlexanderWells-diamond We should make sure this is ready before we merge this