Added top_defines_gen template and made top_defines non-templated #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtrafford
reviewed
Feb 13, 2023
common/hdl/top_defines.vhd
Outdated
| @@ -1,7 +1,11 @@ | |||
| -- AUTOGENERATED | |||
There was a problem hiding this comment.
Probably should remove the autogenerated header, as this file no longer is. I think this file should be moved to the defines directory as well?
tomtrafford
reviewed
Feb 13, 2023
| @@ -301,8 +301,8 @@ def generate_soft_blocks(self): | |||
| "soft_blocks.vhd") | |||
| self.expand_template("addr_defines.vhd.jinja2", context, hdl_dir, | |||
| "addr_defines.vhd") | |||
| self.expand_template("top_defines.vhd.jinja2", context, hdl_dir, | |||
| "top_defines.vhd") | |||
| self.expand_template("top_defines_gen.vhd.jinja2", context, hdl_dir, | |||
There was a problem hiding this comment.
Can you also make sure this file gets generated for the testbenches. Maybe at the same time as the module.tcl? You may need to generate some dummy parameters for total_pos_bus_length
|
Seeing as the makefile always generates the app I have just added the generated top_defines_gen.vhd path to both the tcl scripts. I'm not 100% sure this is a good idea though as this won't work in an instance where the test scripts are ever completely separated from the app generation... |
|
This will resolve #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.