Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(SidebarItem): optimizate SidebarItem #845

Merged
merged 8 commits into from
Jul 13, 2018
Merged

refactor(SidebarItem): optimizate SidebarItem #845

merged 8 commits into from
Jul 13, 2018

Conversation

bowencool
Copy link
Contributor

相关Issue：#631

@bowencool
Copy link
Contributor Author

命名好像有点随意，等会儿改下，你先看下能不能接受

@PanJiaChen PanJiaChen added the WIP Review Working In Progress label Jul 7, 2018
@bowencool
Copy link
Contributor Author

image

@PanJiaChen
Copy link
Owner

感谢你的pr，因为改动比较大，最近也有点忙，世界杯结束前会仔细看一下的。再次感谢你的pr。

@bowencool bowencool changed the title pref: optimizate SiderbarItem fix(SidebarItem): optimizate SidebarItem Jul 11, 2018
@bowencool bowencool changed the title fix(SidebarItem): optimizate SidebarItem refactor(SidebarItem): optimizate SidebarItem Jul 11, 2018
@PanJiaChen
Copy link
Owner

不建议使用 el-menu的 router 配置，这会导致侧边栏渲染出来的时候每一个 menu 都不是 a 标签。这样是不能右击新开页面或者使用快捷方式新开页面的。

@PanJiaChen
Copy link
Owner

image

image

@PanJiaChen
Copy link
Owner

PanJiaChen commented Jul 12, 2018 •
edited
Loading

还有一点，lang/en.js 也需要一改下。

@bowencool
Copy link
Contributor Author

哦了

@PanJiaChen
Copy link
Owner

感谢你的pr~ 👍

@PanJiaChen PanJiaChen merged commit aa7eab5 into PanJiaChen:master Jul 13, 2018
@PanJiaChen PanJiaChen mentioned this pull request Jul 13, 2018
Closed
@bowencool
Copy link
Contributor Author

感谢Merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP Review Working In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bowencool @PanJiaChen