Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ja Lang, please don't remove i18n #1999

Merged
merged 1 commit into from
May 2, 2019

Conversation

linzhengen
Copy link
Contributor

@linzhengen linzhengen commented Apr 30, 2019

这个项目非常好,希望可以增加日本的粉丝。
但准备提交pr时,才发现原来要移除 i18n #1828 😭。
还是希望可以保留多语言支持。

@PanJiaChen
Copy link
Owner

首先感谢你的pr。

对于国际化的疑问是这样的:大部分人其实做项目的时候是不需要国际化的,但移除国际化其实工作量还是蛮大的。所以之后版本中,我会维护两个版本。默认版本不支持国际化,而线上demo会作为一个 i18n 分支,与 master并行维护。

@PanJiaChen PanJiaChen merged commit abac078 into PanJiaChen:master May 2, 2019
ful1021 pushed a commit to ful1021/vue-element-admin that referenced this pull request May 5, 2019
pvtrong pushed a commit to pvtrong/vue-element-admin that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants