[WIP] pyDKB/message: introduce for_update() method.
#321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows to mark message as "for update"; without this marker it will be treated as "for insert" by the pre-load stage (e.g. Stage 019).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows to mark message as "for update"; without this marker (and without "incomplete" one, after #320) it will be treated as "for insert" by the pre-load stage (e.g. Stage 019).
Somehow this functionality was left out of the whole picture related to the "update" issue.
Now what we have: we have instrument to mark message as "incomplete", and (after #320) Stage 19 will decorate "incomplete" messages with "update" instructions. But in some cases we'd like to use "update", but not mark the record in the ES as "incomplete": e.g. if we know for sure that in some external source there will never appear data that we are supposed to get from there (like, after the dataset was removed from Rucio metacatalog, there will never appear information about the dataset size of number of events).
For now there's no pressing need for this functionality to be implemented so I mark this PR as
[WIP]-- since it is very "un-DRY" version and it would be better to somehow unify handling ofincompleteandfor-updatemarkers.