Support setting the uid from the query #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the get_password_hash_for_user query to allow it to return the uid as well. This makes it possible to support normalizing usernames, using email as username and other types of mapping in the query. Probably deals with PanCakeConnaisseur#56
|
Looking at the other open pull requests, I think this would allow doing what @Stratop0w is trying to do in #57 and #58 in sql query. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the get_password_hash_for_user query to allow it to return the uid as well. This makes it possible to support normalizing usernames, using email as username and other types of mapping in the query.
Probably deals with #56
I personally needed this to support both username and email as login without nextcloud creating separate accounts for 'user' and 'user@domain'. There certainly are different ways to solve this, I choose to use the optional second column in get_password_hash_for_user as that would be backwards compatible with exiting configurations. But a specific configuration for this could also be an option.
The checkPassword function is intended to be used this way, see https://github.com/nextcloud/server/blob/master/lib/public/User/Backend/ICheckPasswordBackend.php