Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: DecryptionRule wrong xpath. #404

Merged
merged 7 commits into from
Jan 27, 2022
Merged

bug: DecryptionRule wrong xpath. #404

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d0964a9
bug: DecryptionRule wrong xpath.
alexortize Jan 26, 2022
f2ca3ef
feat: Added negate and negate_target to DecryptionRule
alexortize Jan 26, 2022
889020a
clean up done
alexortize Jan 27, 2022
07acc06
Update policies.py
alexortize Jan 27, 2022
e97033a
Update policies.py file to use Unix style EOL.
alexortize Jan 27, 2022
2925d20
Merge branch 'bugfix' of https://github.com/alexortize/pan-os-python …
alexortize Jan 27, 2022
6adf816
Merge branch 'develop' into origin/fix
alexortize Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion panos/policies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,10 @@ class DecryptionRule(VersionedPanObject):
handshakes.
log_failed_tls_handshakes (bool): (PAN-OS 10.0+) Log failed TLS handshakes.
log_setting (str): (PAN-OS 10.0+) Log setting.
negate_target (bool): Target all but the listed target firewalls
(applies to panorama/device groups only)
target (list): Apply this policy to the listed firewalls only
(applies to panorama/device groups only)

"""

Expand All @@ -843,7 +847,7 @@ class DecryptionRule(VersionedPanObject):

def _setup(self):
# xpaths
self._xpaths.add_profile(value="/pbf/rules")
self._xpaths.add_profile(value="/decryption/rules")

# params
params = []
Expand Down Expand Up @@ -940,6 +944,12 @@ def _setup(self):
params[-1].add_profile(
"10.0.0", path="log-setting",
)
params.append(
VersionedParamPath("negate_target", path="target/negate", vartype="yesno")
)
params.append(
VersionedParamPath("target", path="target/devices", vartype="entry")
)

self._params = tuple(params)

Expand Down