-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rip support #330
feat: add rip support #330
Conversation
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
Hello @btorresgil @shinmog Would you please review my PR and comment if any changes are required. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is confusing and something that we'll need to enhance tests to check for, but when specifying the xpath of an object it needs to start with a /
, however when specifying the xpath for a param it shouldn't. I saw that this got you in a few places and have called them out.
As an aside, I appreciate the addition of tests. |
I really like your testing framework. It made easy to onboard additional test cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Looks like you need to run |
Some formatting is still off - |
@shinmog |
Ok, I have resolved the issue with
|
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
## [1.4.0](v1.3.0...v1.4.0) (2021-07-23) ### Features * Add new HIP options to security rules ([#355](#355)) ([bab35d1](bab35d1)), closes [#345](#345) * Add RIP support ([#330](#330)) ([7b697fe](7b697fe)) * Audit registered IPs for a specific tag ([5d13e05](5d13e05)), closes [#322](#322) ### Bug Fixes * Legacy HA interface stubs removed ([8d44951](8d44951)), closes [#350](#350)
🎉 This PR is included in version 1.4.0 🎉 The release is available on PyPI and GitHub release
|
Description
Adding RIP configuration objects to be added to
panos.network.VirtualRouter
instance.The following classes have been added to enable this functionality:
Added Unit tests to cover the additional classes
Feature enhancement #329
Motivation and Context
Current network design requires RIP routing configuration on VirtualRouter objects.
How Has This Been Tested?
pylint pass
flake8 pass
pytest live tests pass
Functionality tested with the following driver script:
Result
Types of changes
Checklist