-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: DecryptionRule wrong xpath. #404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DecryptionRule _setup method was referencing wrong xpath for decryption rules.
feat: Added negate and negate_target to DecryptionRule
moved some things around and removed whitespace causing test to fail.
shinmog
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
## [1.7.0](v1.6.0...v1.7.0) (2022-03-29) ### Features * Add Prisma Access support ([#419](#419)) ([f93416e](f93416e)), closes [#406](#406) [#413](#413) [#396](#396) * Add decryption rule target and negate_target ([#404](#404)) ([88a2903](88a2903)) * Add hierarchy retrieval info ([#366](#366)) ([a290b31](a290b31)) * Add hit count support for Panorama / device group rulebases ([#429](#429)) ([057822a](057822a)), closes [#388](#388) * **panos.panorama.Panorama:** Add `refresh_shared_objects()` ([#436](#436)) ([11327a4](11327a4)), closes [#428](#428) * Add alternative quoting for `op()` ([#367](#367)) ([b8d0379](b8d0379)), closes [#234](#234) * Add Cloud Services plugin support ([683f3b5](683f3b5)) * Add Local User Database objects ([#385](#385)) ([d39b6de](d39b6de)) * Add objects.ApplicationOverride ([#405](#405)) ([98db86a](98db86a)) * Add policies.AuthenticationRule ([#415](#415)) ([0d70d3f](0d70d3f)) * ApplicationTag - tag predefined applications ([#414](#414)) ([cfee6e3](cfee6e3)) * Make opstate more discoverable for users ([#413](#413)) ([f4f08d0](f4f08d0)), closes [#396](#396) ### Bug Fixes * **panos.objects.ApplicationFilter:** Fix tag path ([#381](#381)) ([a0991f8](a0991f8)) * `delete_similar()` now breaks delete calls into chunks ([#435](#435)) ([4333377](4333377)) * Fixes `refresh()` for attrib style params ([#395](#395)) ([0b47a3a](0b47a3a)), closes [#392](#392) * Modify show_highavailability_state method xpath for Panorama ([#430](#430)) ([37ed2ca](37ed2ca)) * **AggregateInterface:** Correct lacp_passive_pre_negotiation xpath ([6a67320](6a67320)), closes [#406](#406)
🎉 This PR is included in version 1.7.0 🎉 The release is available on PyPI and GitHub release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DecryptionRule _setup method was referencing wrong xpath for decryption rules.
Motivation and Context
It fixes correctly parsing DecryptionRule objects.
Types of changes
Checklist