Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: Authentication profile/sequance #286

Merged
merged 7 commits into from
Apr 29, 2021
Merged

enhancement: Authentication profile/sequance #286

merged 7 commits into from
Apr 29, 2021

Conversation

haginara
Copy link
Contributor

@haginara haginara commented Nov 4, 2020

Description

I added below objects.

  • AuthenticationProfile
  • AuthenticationSequance

Motivation and Context

I noticed there's no objects for AuthenticationProfile and AuthenticationSequance.
I added two objects to handle the authentication objects.

How Has This Been Tested?

I've tested my environment, and it parsed all profiles on objects.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@kevinhuy
Copy link
Contributor

hello @shinmog

can you review this pull request, i'm interested by this new featured.

thanks a lots.

shinmog
shinmog approved these changes Apr 29, 2021
View reviewed changes
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this.

So this is at least missing some documentation stuff regarding versioning support, as well as default values for the params, but this looks really good overall. I'll accept the PR as-is since it's been so long and make the tweaks after it's merged.

Thanks for all the work on this!

@shinmog shinmog merged commit d44dc51 into PaloAltoNetworks:develop Apr 29, 2021
shinmog added a commit that referenced this pull request Apr 30, 2021
@shinmog
refactor: Fix AuthenticationProfile and Sequence
25ebd7b 
This is the continuation of the work for #286.
@shinmog
Copy link
Collaborator

shinmog commented Apr 30, 2021

Super nice job on this! You had condensed params (aka - server_profile), you had good docs, very good use of condition... I saw a lot that I liked. Here's the stuff that I changed:

  • reorganized the params so it mirrors the GUI presentation
  • some param name changes, such as expanding the names (the shortened names we are not doing anymore, those saved keystrokes makes things less clear for users)
  • added kerberos_realm missed param
  • docstring updates (you forgot to put the name param as the first param for the classes)
  • added your new classes to the Firewall and Vsys child types (Panorama still needs this)

Again, thanks a bunch for your work on this!

@haginara haginara deleted the authentication-profile branch April 30, 2021 17:09
shinmog pushed a commit that referenced this pull request May 6, 2021
@haginara @shinmog
feat: Add Authentication profile/sequance (#286)
a66a01d 
* Add AuthenticationProfile PanObject

* Add comment on AuthenticationProfile

* Add AuthenticationSequance object

* Fix the comment which is modified accidently

* Reformat with black

* Add missing argument description

Co-authored-by: jonghak choi <[email protected]>
shinmog added a commit that referenced this pull request May 6, 2021
@shinmog
refactor: Fix AuthenticationProfile and Sequence
be4bf48 
This is the continuation of the work for #286.
github-actions bot pushed a commit that referenced this pull request May 6, 2021
@semantic-release-bot
chore(release): 1.1.0
01b1ab3 
## [1.1.0](v1.0.2...v1.1.0) (2021-05-06)

### Features

* Add `PanDevice.plugins()` ([fa1e4a6](fa1e4a6)), closes [#263](#263)
* Add audit comment support for rules ([#323](#323)) ([350840f](350840f)), closes [#272](#272) [#209](#209)
* Add Authentication profile/sequance ([#286](#286)) ([a66a01d](a66a01d))
* Add device group hierarchy support ([#321](#321)) ([ef90979](ef90979))
* Add DHCP relay support ([#319](#319)) ([fde1fe4](fde1fe4)), closes [#251](#251) [#259](#259)
* Add hit count support (opstate) ([#310](#310)) ([ba1f4d5](ba1f4d5)), closes [#239](#239)
* Add PanDevice.whoami() ([#318](#318)) ([f00d587](f00d587)), closes [#261](#261)
* Add static route path monitoring ([7662496](7662496)), closes [#296](#296)
* Add Zone 8.0+ support ([21f7026](21f7026)), closes [#158](#158)
* Content version by refresh_system_info() ([00f982f](00f982f))
* Save versions during device refresh ([7d7a7f9](7d7a7f9))

### Bug Fixes

* Add missing tag colors ([d021922](d021922)), closes [#267](#267)
* Anti-replay specified twice ([#274](#274)) ([aa30205](aa30205))
* AuthenticationSequence class name ([9632c93](9632c93))
* Correct `clock()` parsing ([48faab5](48faab5)), closes [#278](#278)
* correct user-id tag_user / untag_user ([#299](#299)) ([1de69f8](1de69f8)), closes [#287](#287)
* Correcting profile xpaths ([#333](#333)) ([c1ac9c4](c1ac9c4)), closes [#266](#266)
* Fix placement of default PAN-OS version const ([6fd6ae3](6fd6ae3))
* Fix show_system_resource parsing ([83ab35d](83ab35d)), closes [#280](#280)
btorresgil pushed a commit that referenced this pull request May 10, 2021
@semantic-release-bot @btorresgil
chore(release): 1.1.0
979be40 
## [1.1.0](v1.0.2...v1.1.0) (2021-05-06)

### Features

* Add `PanDevice.plugins()` ([fa1e4a6](fa1e4a6)), closes [#263](#263)
* Add audit comment support for rules ([#323](#323)) ([350840f](350840f)), closes [#272](#272) [#209](#209)
* Add Authentication profile/sequance ([#286](#286)) ([a66a01d](a66a01d))
* Add device group hierarchy support ([#321](#321)) ([ef90979](ef90979))
* Add DHCP relay support ([#319](#319)) ([fde1fe4](fde1fe4)), closes [#251](#251) [#259](#259)
* Add hit count support (opstate) ([#310](#310)) ([ba1f4d5](ba1f4d5)), closes [#239](#239)
* Add PanDevice.whoami() ([#318](#318)) ([f00d587](f00d587)), closes [#261](#261)
* Add static route path monitoring ([7662496](7662496)), closes [#296](#296)
* Add Zone 8.0+ support ([21f7026](21f7026)), closes [#158](#158)
* Content version by refresh_system_info() ([00f982f](00f982f))
* Save versions during device refresh ([7d7a7f9](7d7a7f9))

### Bug Fixes

* Add missing tag colors ([d021922](d021922)), closes [#267](#267)
* Anti-replay specified twice ([#274](#274)) ([aa30205](aa30205))
* AuthenticationSequence class name ([9632c93](9632c93))
* Correct `clock()` parsing ([48faab5](48faab5)), closes [#278](#278)
* correct user-id tag_user / untag_user ([#299](#299)) ([1de69f8](1de69f8)), closes [#287](#287)
* Correcting profile xpaths ([#333](#333)) ([c1ac9c4](c1ac9c4)), closes [#266](#266)
* Fix placement of default PAN-OS version const ([6fd6ae3](6fd6ae3))
* Fix show_system_resource parsing ([83ab35d](83ab35d)), closes [#280](#280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinmog shinmog shinmog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haginara @kevinhuy @shinmog