test: Adding new tests for class params (#356)

* test: Adding new tests for class params This also fixes a number of issues these tests found.
PaloAltoNetworks · Jul 7, 2021 · 6162912 · 6162912
1 parent bab35d1
commit 6162912
Show file tree

Hide file tree

Showing 6 changed files with 282 additions and 56 deletions.
diff --git a/panos/device.py b/panos/device.py
@@ -225,6 +225,7 @@ class NTPServer(PanObject):
     # TODO: Add authentication
     # TODO: Add PAN-OS pre-7.0 support
 
+    NAME = None
     XPATH = "/ntp-servers/primary-ntp-server"
 
     def __init__(self, *args, **kwargs):
@@ -805,6 +806,8 @@ class Administrator(VersionedPanObject):
         role_profile (str): The role based profile
         password_hash (encrypted str): The encrypted password
         password_profile (str): The password profile for this user
+        vsys_device (list): The vsys list (excluded)
+        vsys_read_only_device (list): The read-only device list (excluded)
 
     """
 

diff --git a/panos/ha.py b/panos/ha.py
@@ -39,6 +39,7 @@ class HighAvailabilityInterface(PanObject):
 
     """
 
+    NAME = None
     HA_SYNC = False
 
     # TODO: Support encryption
@@ -189,12 +190,13 @@ class HA1(HighAvailabilityInterface):
     """HA1 interface
 
     Args:
-        ip-address (str): IP of the interface
+        ip_address (str): IP of the interface
         netmask (str): Netmask of the interface
         port (str): Interface to use for this HA interface (eg. ethernet1/5)
         gateway (str): Default gateway of the interface
         link_speed (str): Link speed
         link_duplex (str): Link duplex
+        monitor_hold_time (int): Monitor hold time
 
     """
 
@@ -210,7 +212,7 @@ class HA1Backup(HighAvailabilityInterface):
     """HA1 Backup interface
 
     Args:
-        ip-address (str): IP of the interface
+        ip_address (str): IP of the interface
         netmask (str): Netmask of the interface
         port (str): Interface to use for this HA interface (eg. ethernet1/5)
         gateway (str): Default gateway of the interface
@@ -226,7 +228,7 @@ class HA2(HighAvailabilityInterface):
     """HA2 interface
 
     Args:
-        ip-address (str): IP of the interface
+        ip_address (str): IP of the interface
         netmask (str): Netmask of the interface
         port (str): Interface to use for this HA interface (eg. ethernet1/5)
         gateway (str): Default gateway of the interface
@@ -242,7 +244,7 @@ class HA2Backup(HighAvailabilityInterface):
     """HA2 Backup interface
 
     Args:
-        ip-address (str): IP of the interface
+        ip_address (str): IP of the interface
         netmask (str): Netmask of the interface
         port (str): Interface to use for this HA interface (eg. ethernet1/5)
         gateway (str): Default gateway of the interface