Merge pull request #391 from swaschkut/developer

UTIL pan-os-php type=device | introduce PAN-OS Panorama API call for actions=zoneprotectionprofile-create-bp
PaloAltoNetworks · Jan 11, 2022 · 67777fa · 67777fa
2 parents 6a8d8cc + 3e273ce
commit 67777fa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 19 deletions.
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
@@ -20,6 +20,7 @@ UTILS:
 * UTIL pan-os-php type=device | introduce PAN-OS API. mode for actions=zoneprotectionprofile-create-bp /  logforwardingprofile-create-bp
 * UTIL pan-os-php type=device | actions=securityprofile-create-alert-only introduce PAN-OS API method for FWs
 * UTIL pan-os-php type=device | introduce PAN-OS API call for Panorama for actions=cleanuprule-create-bp /  logforwardingprofile-create-bp / securityprofile-create-alert-only
+* UTIL pan-os-php type=device | introduce PAN-OS Panorama API call for actions=zoneprotectionprofile-create-bp
 
 BUGFIX:
 * update installer scripts / issues with git-php not available

diff --git a/utils/common/actions-device.php b/utils/common/actions-device.php
@@ -1612,21 +1612,6 @@
     'name' => 'zoneprotectionprofile-create-bp',
     'GlobalInitFunction' => function (DeviceCallContext $context) {
         $context->first = true;
-
-        if( $context->isAPI && $context->subSystem->isPanorama() )
-            derr( "API mode not implemented yet for Panorama" );
-
-        if( $context->subSystem->isPanorama() )
-        {
-            /*
-            $countDG = count( $context->subSystem->getDeviceGroups() );
-            if( $countDG == 0 )
-            {
-                #$dg = $context->subSystem->createDeviceGroup( "alert-only" );
-                derr( "NO DG available; please run 'pa_device-edit in=InputConfig.xml out=OutputConfig.xml actions=devicegroup-create:DG-NAME' first", null, false );
-            }
-            */
-        }
     },
     'MainFunction' => function (DeviceCallContext $context)
     {
@@ -1718,7 +1703,7 @@
                     $xmlRoot = $sharedStore->deviceConfiguration->network->xmlroot;
                     if( $xmlRoot === null )
                     {
-                        $xmlRoot = DH::findFirstElementOrCreate('device', $sharedStore->deviceConfiguration->xmlroot);
+                        $xmlRoot = DH::findFirstElementOrCreate('devices', $sharedStore->deviceConfiguration->xmlroot);
 
                         #$xmlRoot = DH::findFirstElementByNameAttrOrCreate( 'entry', 'localhost.localdomain', $xmlRoot, $sharedStore->deviceConfiguration->xmlroot->ownerDocument);
                         $xmlRoot = DH::findFirstElementOrCreate('entry', $xmlRoot);
@@ -1731,7 +1716,7 @@
                     $xmlRoot = $sharedStore->owner->network->xmlroot;
                     if( $xmlRoot === null )
                     {
-                        $xmlRoot = DH::findFirstElementOrCreate('device', $sharedStore->owner->xmlroot);
+                        $xmlRoot = DH::findFirstElementOrCreate('devices', $sharedStore->owner->xmlroot);
 
                         #$xmlRoot = DH::findFirstElementByNameAttrOrCreate( 'entry', 'localhost.localdomain', $xmlRoot, $sharedStore->owner->xmlroot->ownerDocument);
                         $xmlRoot = DH::findFirstElementOrCreate('entry', $xmlRoot);
@@ -1774,8 +1759,8 @@
                 else
                     mwarning( "ZoneProtectionProfile 'Recommended_Zone_Protection' already available. BestPractise ZoneProtectionProfile 'Recommended_Zone_Protection' not created", null, FALSE );
 
-
-                $context->first = false;
+                //create for all VSYS and all templates
+                #$context->first = false;
             }
         }
     }