Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(panos_import): Add private key blocking to keypair import #417

Merged
merged 5 commits into from
Jun 14, 2023

Conversation

jamesholland-uk
Copy link
Member

Description

Adds the ability, at the time of importing a keypair, to block the private key from being exported from PAN-OS in future

Motivation and Context

Closes #415
Blocking export of private keys was introduced in PAN-OS 10.0

How Has This Been Tested?

Tested locally

Screenshots (if appropriate)

Testing screenshot:
Screenshot 2023-04-06 at 16 01 09

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

plugins/modules/panos_import.py Outdated Show resolved Hide resolved
plugins/modules/panos_import.py Outdated Show resolved Hide resolved
@jamesholland-uk jamesholland-uk requested a review from shinmog May 2, 2023 20:37
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to simplify this check, then it's fine.

plugins/modules/panos_import.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamesholland-uk jamesholland-uk merged commit 3fd5bac into develop Jun 14, 2023
@jamesholland-uk jamesholland-uk deleted the add-priv-key-blocking-to-keypair-import branch June 14, 2023 09:05
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
## [2.17.0](v2.16.0...v2.17.0) (2023-06-14)

### Features

* **panos_export:** Create directory if it doesn't exist ([#434](#434)) ([9422af0](9422af0))
* **panos_import:** Add private key blocking to keypair import ([#417](#417)) ([3fd5bac](3fd5bac))
* **panos_software:** name config load option ([#398](#398)) ([378d5a6](378d5a6))
@github-actions
Copy link

🎉 This PR is included in version 2.17.0 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Block export of private key when importing keypairs
2 participants