-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(panos_import): Add private key blocking to keypair import #417
feat(panos_import): Add private key blocking to keypair import #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to simplify this check, then it's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
## [2.17.0](v2.16.0...v2.17.0) (2023-06-14) ### Features * **panos_export:** Create directory if it doesn't exist ([#434](#434)) ([9422af0](9422af0)) * **panos_import:** Add private key blocking to keypair import ([#417](#417)) ([3fd5bac](3fd5bac)) * **panos_software:** name config load option ([#398](#398)) ([378d5a6](378d5a6))
🎉 This PR is included in version 2.17.0 🎉 The release is available on Ansible Galaxy and GitHub release
|
Description
Adds the ability, at the time of importing a keypair, to block the private key from being exported from PAN-OS in future
Motivation and Context
Closes #415
Blocking export of private keys was introduced in PAN-OS 10.0
How Has This Been Tested?
Tested locally
Screenshots (if appropriate)
Testing screenshot:
![Screenshot 2023-04-06 at 16 01 09](https://user-images.githubusercontent.com/6574404/230419483-562912b8-ad9a-4f56-b2f1-d2431f1b37e0.png)
Types of changes
Checklist