Add per-admin parameter to Panorama push

[jamesholland-uk]

Description

Adding support for the PAN-OS 10.2 feature of Administrator-Level Push from Panorama to Managed Devices

Depends upon supporting change in pan-os-python.

Motivation and Context

Motivation is adding support for a new PAN-OS feature, and also to support adding this feature in pan-os-ansible (ref - will close this issue)

How Has This Been Tested?

Tested locally, with Panorama 11.0.0 and managed firewall 10.2.3

  tasks:
    - name: Commit and Push template configuration
      panos_commit_push:
        provider: "{{ device }}"
        style: "device group"
        name: "poc-dg"
        admins:
          - "other"
        include_template: no
        force_template_values: no
      register: results
    - debug:
        msg: "Job ID: {{ results.jobid }} finished"

Screenshots (if appropriate)

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist

• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes if appropriate.
• All new and existing tests passed.

[shinmog]

This change requires a certain minimum version of PAN-OS, which is present in the docstring, so that's good.

However, it also requires a certain minimum version of pan-os-python, which is not reflected in the code right now. You can configure this as min_pandevice_version. However, you can't actually do that until you know which version of pan-os-python is going to contain the change for admin specific push. So pan-os-python needs to release that first, then this code can reflect that.

[jamesholland-uk]

Thanks @shinmog, that all makes sense. The change in pan-os-python is merged and awaiting release. It didn't pass all the tests, but that was the issue in CI with the version of the poetry action (and also poetry itself got a version upgrade), and that change is also merged. So do we 1) push the pan-os-python CI change from develop to master, 2) rerun the CI tests on my PR in pan-os-python, 3) push the changes from the PR from develop to master, 4) get the pan-os-python version and put it into this PR per your note, 5) release pan-os-ansible? Phew!

[jamesholland-uk]

1. push the pan-os-python CI change from develop to master - done
2. rerun the CI tests on my PR in pan-os-python - done
3. push the changes from the PR from develop to master - done
4. get the pan-os-python version and put it into this PR per your note - done
5. release pan-os-ansible...........

Let me know if there are any other modifications needed for us to go live with this PR @shinmog?

[shinmog]

lgtm

[github-actions]

🎉 This PR is included in version 2.13.0 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot