Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(panos_software): name config load option #398

Merged
merged 2 commits into from
Jun 14, 2023
Merged

feat(panos_software): name config load option #398

merged 2 commits into from
Jun 14, 2023

Conversation

FoSix
Copy link
Contributor

@FoSix FoSix commented Mar 1, 2023

Description

Adding an option to load a name config during the process.

Motivation and Context

An option to load a named config after and upgrade/downgrade is introduced. This can be helpful especially during downgrades.

How Has This Been Tested?

This module, in this form, was already used on production.

Screenshots (if appropriate)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@welcome-to-palo-alto-networks
Copy link

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@FoSix FoSix marked this pull request as draft March 1, 2023 07:49
@FoSix FoSix marked this pull request as ready for review March 1, 2023 09:31
@FoSix FoSix changed the title feat(panos_software): downgrade + name config load option feat(panos_software): name config load option May 22, 2023
Copy link
Member

@jamesholland-uk jamesholland-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working ok, downgraded with named config successfully

Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamesholland-uk jamesholland-uk merged commit 378d5a6 into PaloAltoNetworks:develop Jun 14, 2023
@welcome-to-palo-alto-networks

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
## [2.17.0](v2.16.0...v2.17.0) (2023-06-14)

### Features

* **panos_export:** Create directory if it doesn't exist ([#434](#434)) ([9422af0](9422af0))
* **panos_import:** Add private key blocking to keypair import ([#417](#417)) ([3fd5bac](3fd5bac))
* **panos_software:** name config load option ([#398](#398)) ([378d5a6](378d5a6))
@github-actions
Copy link

🎉 This PR is included in version 2.17.0 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants