V2 feature parity #742
Merged
V2 feature parity #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* impement redoc's x-tagGroup feature * merge main * update documentation * fix filtered tags by group * remove tracked .idea files * add option to readme * merge main * fix lint * revert yarn.lock and linter
Co-authored-by: Christian A. Mathiesen <[email protected]>
|
Visit the preview URL for this PR (updated for commit b11d101): https://docusaurus-openapi-36b86--pr742-zr8xjeec.web.app (expires Sun, 14 Apr 2024 19:48:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
* feat: Implement schema pages behind a config option `showSchemas` * Add `showSchemas` to petstore demo
pmarschik
reviewed
Mar 20, 2024
| if (!!value) { | ||
| const children = cb(value as T); | ||
| return render(children); | ||
| if (value === undefined || value === "") { |
There was a problem hiding this comment.
@sserrata this change introduced a bug in 3.0.0-beta.6, when guard is called from SchemaItem/index.tsx (for renderRequired, value is a boolean.
The check on this line evaluates to false and all <SchemaItem> are rendered as required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports missing features/functionality from v2