Use negative look behind to exclude colon delimited path segments #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +16 B (0%) Total Size: 5.97 MB ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit aad0d88): https://docusaurus-openapi-36b86--pr663-diflove5.web.app (expires Wed, 27 Dec 2023 15:02:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
blindaa121
approved these changes
Nov 28, 2023
sserrata
added a commit
that referenced
this pull request
Dec 1, 2023
sserrata
added a commit
that referenced
this pull request
Dec 1, 2023
* add negative look behind to exclude colon delimited path segments (#663) * use SCHEMA_TYPE to distinguish request/response to support readOnly/writeOnly properties (#665) * Improve support for handling multipart form data (#666) * use pdfblock to test multipart form data * switch back to cors proxy * add handler for generic key-value payload * debug response content type * refactor to download media and file content types * switch back to petstore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a negative look behind to exclude colon delimited path segments from regex match intended to replace segments with
:prefix with postman compatible vars enclosed with parentheses.Motivation and Context
The original regex pattern matched on all semi-colon prefixed segments, regardless if they were intended as path variables, e.g.
https://api.sase.paloaltonetworks.com/sse/config/v1/config-versions/candidate:pushHow Has This Been Tested?
Tested with the following OpenAPI spec:
https://raw.githubusercontent.com/PaloAltoNetworks/pan.dev/master/openapi-specs/access/prisma-access-config/ConfigurationManagement.yaml
Here's an example of a URL that should not be affected by this change:
https://petstore.swagger.io/v2/store/order/:orderIdScreenshots (if appropriate)