fix: remove node.js dependency in browser #1081
Open
+58
−503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Node.js core modules are imported in client(browser) side. And the previsous code use node polyfill, however this would brings more issue:
node:buffer
,node:zlib
... wherenode:
as prefix would still break the webpack bundler becausenode-polyfill-webpack-plugin
didn't handle it correctlyBuffer
could leads unexpected behaviorThis PR remove node.js dependency, instead now uses pika and web api directly to reduce the bundle hack, bundle size and more explicit imports
Motivation and Context
For more context, docusaurus will raise error if use nolyfill
How Has This Been Tested?
Try this in demo and everything works
Screenshots (if appropriate)
Types of changes
Checklist