-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new documentation #2970
Added new documentation #2970
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe pull request involves documentation updates for the Talawa API project, focusing on improving the structure and organization of documentation files. The changes include adding front matter metadata to markdown files, updating section headers, and modifying the sidebar configuration. The updates enhance the documentation's readability and navigation, with specific improvements to files related to PNPM scripts, troubleshooting, environment variables, installation, and the documentation's sidebar. Changes
Sequence DiagramsequenceDiagram
participant User
participant Docs
participant Sidebar
User->>Docs: Access Documentation
Docs->>Sidebar: Request Navigation Structure
Sidebar-->>Docs: Provide Structured Navigation
Docs-->>User: Display Organized Documentation
The sequence diagram illustrates how the documentation is now structured with improved navigation, allowing users to more easily access and navigate through the Talawa API documentation. Possibly related PRs
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #2970 +/- ##
=================================================
Coverage 39.85% 39.85%
=================================================
Files 453 453
Lines 33203 33203
Branches 385 385
=================================================
Hits 13234 13234
Misses 19969 19969 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
🔭 Outside diff range comments (1)
docs/docs/docs/getting-started/environment-variables.md (1)
Line range hint
8-485
: Fix grammar and style issues in the documentation.Several grammar and style issues need to be addressed:
- Missing commas in compound sentences
- Missing articles before nouns
- Inconsistent hyphenation
- Unnatural adverb placement
Apply these corrections:
-By default most workflows are configured +By default, most workflows are configured -When talawa api debugger is run within a container environment this variable +When talawa api debugger is run within a container environment, this variable -When talawa api is run within a container environment this variable +When talawa api is run within a container environment, this variable -the time in milli-seconds +the time in milliseconds -but its use is no longer recommended. It is kept with +but its use is no longer recommended. It is maintained with -configure the value of group id +configure the value of the group id -configure password for the default +configure the password for the default -configure name for the default +configure the name for the default -configure url for the default +configure the URL for the default🧰 Tools
🪛 LanguageTool
[misspelling] ~119-~119: This word is normally spelled as one.
Context: ...riable is used to configure the time in milli-seconds it takes for an authentication json web...(EN_COMPOUNDS_MILLI_SECONDS)
[uncategorized] ~223-~223: Use a comma before ‘but’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...t in which node.js is supposed to run in but its use is no longer recommended. It is...(COMMA_COMPOUND_SENTENCE_2)
[uncategorized] ~223-~223: If you mean ‘learn about’, ‘be aware’, or ‘stay in contact’, use “kept up with”.
Context: ...its use is no longer recommended. It is kept with a default value ofproduction
for bac...(PHRASING_OF_KEEP_UP_WITH)
[uncategorized] ~245-~245: Possible missing article found.
Context: ...iable is used to configure the value of group id of the group assigned to the default...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~325-~325: Possible missing article found.
Context: ...vironment variable is used to configure password for the default cloudbeaver admin accou...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~343-~343: Possible missing article found.
Context: ...vironment variable is used to configure name for the default talawa cloudbeaver serv...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~349-~349: Possible missing article found.
Context: ...vironment variable is used to configure url for the default talawa cloudbeaver serv...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~391-~391: Possible missing article found.
Context: ...vironment variable is used to configure password for the default minio root user `minioa...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~445-~445: Possible missing article found.
Context: ...vironment variable is used to configure password for the defaultpostgres
postgres use...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~451-~451: Possible missing article found.
Context: ...vironment variable is used to configure name for a custom postgres user with superus...(AI_HYDRA_LEO_MISSING_THE)
🪛 markdownlint-cli2 (0.17.2)
114-114: Bare URL used
null(MD034, no-bare-urls)
115-115: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
docs/docs/docs/developer-resources/pnpm-scripts.md
(5 hunks)docs/docs/docs/developer-resources/troubleshooting.md
(1 hunks)docs/docs/docs/getting-started/environment-variables.md
(2 hunks)docs/docs/docs/getting-started/installation.md
(1 hunks)docs/package.json
(2 hunks)docs/sidebars.ts
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/docs/docs/developer-resources/troubleshooting.md
[uncategorized] ~17-~17: You might be missing the article “the” here.
Context: ...Development Containers (devcontainers) Talawa API uses devcontainers for many feature...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~20-~20: The preposition “with” seems more likely in this position.
Context: ...remotely, in a private or public cloud, in a variety of supporting tools and edito...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
[style] ~20-~20: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...otely, in a private or public cloud, in a variety of supporting tools and editors. The Deve...
(A_VARIETY_OF)
[style] ~22-~22: This phrase is redundant. Consider writing “seeks”.
Context: ...The Development Container Specification seeks to find ways to enrich existing formats with co...
(SEEK_TO_FIND)
[uncategorized] ~22-~22: When ‘development-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ... to enrich existing formats with common development specific settings, tools, and configuration whil...
(SPECIFIC_HYPHEN)
[uncategorized] ~26-~26: A determiner appears to be missing. Consider inserting it.
Context: ....dev/ Regular Docker has core features are contrary to using it as a developer env...
(AI_EN_LECTOR_MISSING_DETERMINER)
[duplication] ~46-~46: Possible typo: you repeated a word.
Context: ...it repository is mounted into it. After the the Dev Container starts, the node.js
dev...
(ENGLISH_WORD_REPEAT_RULE)
[uncategorized] ~53-~53: It appears that hyphens are missing in the adjective “up-to-date”.
Context: ...on. 1. Make sure your .env
file is up to date with the latest changes in `.env.devcon...
(UP_TO_DATE_HYPHEN)
[typographical] ~54-~54: Usually, there’s no comma before “if”.
Context: ...lly created when the devcontainer starts, if doesn't previously exist. 3. Preexis...
(IF_NO_COMMA)
[formatting] ~56-~56: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...thchecks are skipped in the devcontainer, because if the healthcheck for it was running t...
(COMMA_BEFORE_BECAUSE)
docs/docs/docs/getting-started/environment-variables.md
[uncategorized] ~8-~8: Did you mean: “By default,”?
Context: ... for different scenarios and use cases. By default most workflows are configured to parse ...
(BY_DEFAULT_COMMA)
[style] ~16-~16: The placement of the adverb ‘api’ may sound unnatural here. Try moving it after ‘is’.
Context: ...dent on the environment in which talawa api is running. ### API_ADMINISTRATOR_USER_EM...
(PROG_ADV_PLACEMENT)
[uncategorized] ~88-~88: Possible missing comma found.
Context: ... api debugger is run within a container environment this variable must be assigned a value ...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~96-~96: Possible missing comma found.
Context: ...en talawa api is run within a container environment this variable must be assigned a value ...
(AI_HYDRA_LEO_MISSING_COMMA)
[misspelling] ~119-~119: This word is normally spelled as one.
Context: ...riable is used to configure the time in milli-seconds it takes for an authentication json web...
(EN_COMPOUNDS_MILLI_SECONDS)
[uncategorized] ~223-~223: Use a comma before ‘but’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...t in which node.js is supposed to run in but its use is no longer recommended. It is...
(COMMA_COMPOUND_SENTENCE_2)
[uncategorized] ~223-~223: If you mean ‘learn about’, ‘be aware’, or ‘stay in contact’, use “kept up with”.
Context: ...its use is no longer recommended. It is kept with a default value of production
for bac...
(PHRASING_OF_KEEP_UP_WITH)
[uncategorized] ~245-~245: Possible missing article found.
Context: ...iable is used to configure the value of group id of the group assigned to the default...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~325-~325: Possible missing article found.
Context: ...vironment variable is used to configure password for the default cloudbeaver admin accou...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~343-~343: Possible missing article found.
Context: ...vironment variable is used to configure name for the default talawa cloudbeaver serv...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~349-~349: Possible missing article found.
Context: ...vironment variable is used to configure url for the default talawa cloudbeaver serv...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~391-~391: Possible missing article found.
Context: ...vironment variable is used to configure password for the default minio root user `minioa...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~445-~445: Possible missing article found.
Context: ...vironment variable is used to configure password for the default postgres
postgres use...
(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~451-~451: Possible missing article found.
Context: ...vironment variable is used to configure name for a custom postgres user with superus...
(AI_HYDRA_LEO_MISSING_THE)
🪛 markdownlint-cli2 (0.17.2)
docs/docs/docs/developer-resources/troubleshooting.md
24-24: Bare URL used
null
(MD034, no-bare-urls)
33-33: Bare URL used
null
(MD034, no-bare-urls)
50-50: Emphasis used instead of a heading
null
(MD036, no-emphasis-as-heading)
🔇 Additional comments (4)
docs/sidebars.ts (1)
25-30
: LGTM! Well-structured sidebar configuration.The new "Developer Resources" category follows the established pattern and is appropriately positioned in the documentation hierarchy.
docs/package.json (1)
18-19
: Verify Docusaurus version compatibility.The updates to Docusaurus packages (3.6.3 → 3.7.0) appear consistent. Let's verify the compatibility and check for any breaking changes.
Also applies to: 28-30
✅ Verification successful
✅ Docusaurus version updates are compatible
The update from 3.6.3 to 3.7.0 is a minor version bump with no breaking changes. The changelog indicates only new features, bug fixes, and maintenance updates.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check Docusaurus changelog for breaking changes between versions curl -s "https://raw.githubusercontent.com/facebook/docusaurus/main/CHANGELOG.md" | \ awk '/## 3.7.0/,/## 3.6.3/' | \ grep -E "^###|BREAKING"Length of output: 280
docs/docs/docs/getting-started/installation.md (1)
16-18
: LGTM! Documentation improvements.The changes enhance the documentation by:
- Adding a step explaining
.env
file usage.- Adding a reference to the environment variables page for comprehensive configuration options.
docs/docs/docs/getting-started/environment-variables.md (1)
1-6
: LGTM! Well-structured front matter metadata.The front matter metadata is properly formatted and includes all necessary fields:
- id
- title
- slug
- sidebar position
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
64e2efc
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Issue Number:
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Added documentation on:
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?
Summary by CodeRabbit