Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new documentation #2970

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

palisadoes
Copy link
Contributor

@palisadoes palisadoes commented Jan 27, 2025

What kind of change does this PR introduce?

  • Added new documentation

Issue Number:

  • N/A

Snapshots/Videos:

  • N/A

If relevant, did you update the documentation?

  • N/A

Summary

Added documentation on:

  1. environment variables
  2. PNPM scripts
  3. Operation and troubleshooting

Does this PR introduce a breaking change?

  • No

Other information

  • N/A

Have you read the contributing guide?

  • Yes

Summary by CodeRabbit

  • Documentation
    • Updated documentation structure with new front matter metadata.
    • Added new "Operation & Troubleshooting" document.
    • Improved section headers and formatting in environment variables documentation.
    • Added new "Developer Resources" category in sidebar.
    • Added introductory resource for developers outlining key directories.
    • Updated Docusaurus dependencies to version 3.7.0.

@palisadoes palisadoes added the ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files label Jan 27, 2025
Copy link

coderabbitai bot commented Jan 27, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request involves documentation updates for the Talawa API project, focusing on improving the structure and organization of documentation files. The changes include adding front matter metadata to markdown files, updating section headers, and modifying the sidebar configuration. The updates enhance the documentation's readability and navigation, with specific improvements to files related to PNPM scripts, troubleshooting, environment variables, installation, and the documentation's sidebar.

Changes

File Change Summary
docs/docs/docs/developer-resources/pnpm-scripts.md Added front matter metadata, corrected typo "unncessary" to "unnecessary", adjusted link formatting
docs/docs/docs/developer-resources/troubleshooting.md New document added with metadata about Operation & Troubleshooting, focusing on devcontainers
docs/docs/docs/getting-started/environment-variables.md Reformatted with front matter metadata, updated section headers from # to ## and ###
docs/docs/docs/getting-started/installation.md Added note about .env file usage and reference to Environment Variables Page
docs/package.json Updated Docusaurus-related dependencies from version 3.6.3 to 3.7.0
docs/sidebars.ts Added new "Developer Resources" category to tutorialSidebar
docs/docs/docs/developer-resources/introduction.md New file added providing an overview of important directories related to the Talawa API development

Sequence Diagram

sequenceDiagram
    participant User
    participant Docs
    participant Sidebar
    
    User->>Docs: Access Documentation
    Docs->>Sidebar: Request Navigation Structure
    Sidebar-->>Docs: Provide Structured Navigation
    Docs-->>User: Display Organized Documentation
Loading

The sequence diagram illustrates how the documentation is now structured with improved navigation, allowing users to more easily access and navigate through the Talawa API documentation.

Possibly related PRs

  • Updated documentation to include production setup #2798: The changes in the main PR involve updating documentation related to the installation and usage of the Talawa API, which aligns with the updates made in this PR that enhance the installation instructions for running the API in both development and production environments.
  • add drizzle/graphql implementation for community #2866: The main PR introduces front matter metadata and updates links related to Drizzle ORM documentation, which is relevant to the changes in this PR that implement a drizzle/schema and SQL migrations for community data storage.
  • Feature/Create systemd to run talawa-api service . #2870: The main PR's changes to documentation and structure may relate to the new systemd service configuration introduced in this PR, which provides a structured approach to running the Talawa API service.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48a26ef and 9eeb7df.

📒 Files selected for processing (4)
  • docs/docs/docs/developer-resources/introduction.md (1 hunks)
  • docs/docs/docs/developer-resources/pnpm-scripts.md (5 hunks)
  • docs/docs/docs/developer-resources/troubleshooting.md (1 hunks)
  • docs/sidebars.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.85%. Comparing base (28859b2) to head (9eeb7df).
Report is 1 commits behind head on develop-postgres.

Additional details and impacted files
@@                Coverage Diff                @@
##           develop-postgres    #2970   +/-   ##
=================================================
  Coverage             39.85%   39.85%           
=================================================
  Files                   453      453           
  Lines                 33203    33203           
  Branches                385      385           
=================================================
  Hits                  13234    13234           
  Misses                19969    19969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🔭 Outside diff range comments (1)
docs/docs/docs/getting-started/environment-variables.md (1)

Line range hint 8-485: Fix grammar and style issues in the documentation.

Several grammar and style issues need to be addressed:

  1. Missing commas in compound sentences
  2. Missing articles before nouns
  3. Inconsistent hyphenation
  4. Unnatural adverb placement

Apply these corrections:

-By default most workflows are configured
+By default, most workflows are configured

-When talawa api debugger is run within a container environment this variable
+When talawa api debugger is run within a container environment, this variable

-When talawa api is run within a container environment this variable
+When talawa api is run within a container environment, this variable

-the time in milli-seconds
+the time in milliseconds

-but its use is no longer recommended. It is kept with
+but its use is no longer recommended. It is maintained with

-configure the value of group id
+configure the value of the group id

-configure password for the default
+configure the password for the default

-configure name for the default
+configure the name for the default

-configure url for the default
+configure the URL for the default
🧰 Tools
🪛 LanguageTool

[misspelling] ~119-~119: This word is normally spelled as one.
Context: ...riable is used to configure the time in milli-seconds it takes for an authentication json web...

(EN_COMPOUNDS_MILLI_SECONDS)


[uncategorized] ~223-~223: Use a comma before ‘but’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...t in which node.js is supposed to run in but its use is no longer recommended. It is...

(COMMA_COMPOUND_SENTENCE_2)


[uncategorized] ~223-~223: If you mean ‘learn about’, ‘be aware’, or ‘stay in contact’, use “kept up with”.
Context: ...its use is no longer recommended. It is kept with a default value of production for bac...

(PHRASING_OF_KEEP_UP_WITH)


[uncategorized] ~245-~245: Possible missing article found.
Context: ...iable is used to configure the value of group id of the group assigned to the default...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~325-~325: Possible missing article found.
Context: ...vironment variable is used to configure password for the default cloudbeaver admin accou...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~343-~343: Possible missing article found.
Context: ...vironment variable is used to configure name for the default talawa cloudbeaver serv...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~349-~349: Possible missing article found.
Context: ...vironment variable is used to configure url for the default talawa cloudbeaver serv...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~391-~391: Possible missing article found.
Context: ...vironment variable is used to configure password for the default minio root user `minioa...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~445-~445: Possible missing article found.
Context: ...vironment variable is used to configure password for the default postgres postgres use...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~451-~451: Possible missing article found.
Context: ...vironment variable is used to configure name for a custom postgres user with superus...

(AI_HYDRA_LEO_MISSING_THE)

🪛 markdownlint-cli2 (0.17.2)

114-114: Bare URL used
null

(MD034, no-bare-urls)


115-115: Bare URL used
null

(MD034, no-bare-urls)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28859b2 and 48a26ef.

⛔ Files ignored due to path filters (1)
  • docs/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • docs/docs/docs/developer-resources/pnpm-scripts.md (5 hunks)
  • docs/docs/docs/developer-resources/troubleshooting.md (1 hunks)
  • docs/docs/docs/getting-started/environment-variables.md (2 hunks)
  • docs/docs/docs/getting-started/installation.md (1 hunks)
  • docs/package.json (2 hunks)
  • docs/sidebars.ts (1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/docs/docs/developer-resources/troubleshooting.md

[uncategorized] ~17-~17: You might be missing the article “the” here.
Context: ...Development Containers (devcontainers) Talawa API uses devcontainers for many feature...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~20-~20: The preposition “with” seems more likely in this position.
Context: ...remotely, in a private or public cloud, in a variety of supporting tools and edito...

(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)


[style] ~20-~20: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...otely, in a private or public cloud, in a variety of supporting tools and editors. The Deve...

(A_VARIETY_OF)


[style] ~22-~22: This phrase is redundant. Consider writing “seeks”.
Context: ...The Development Container Specification seeks to find ways to enrich existing formats with co...

(SEEK_TO_FIND)


[uncategorized] ~22-~22: When ‘development-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ... to enrich existing formats with common development specific settings, tools, and configuration whil...

(SPECIFIC_HYPHEN)


[uncategorized] ~26-~26: A determiner appears to be missing. Consider inserting it.
Context: ....dev/ Regular Docker has core features are contrary to using it as a developer env...

(AI_EN_LECTOR_MISSING_DETERMINER)


[duplication] ~46-~46: Possible typo: you repeated a word.
Context: ...it repository is mounted into it. After the the Dev Container starts, the node.js dev...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~53-~53: It appears that hyphens are missing in the adjective “up-to-date”.
Context: ...on. 1. Make sure your .env file is up to date with the latest changes in `.env.devcon...

(UP_TO_DATE_HYPHEN)


[typographical] ~54-~54: Usually, there’s no comma before “if”.
Context: ...lly created when the devcontainer starts, if doesn't previously exist. 3. Preexis...

(IF_NO_COMMA)


[formatting] ~56-~56: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...thchecks are skipped in the devcontainer, because if the healthcheck for it was running t...

(COMMA_BEFORE_BECAUSE)

docs/docs/docs/getting-started/environment-variables.md

[uncategorized] ~8-~8: Did you mean: “By default,”?
Context: ... for different scenarios and use cases. By default most workflows are configured to parse ...

(BY_DEFAULT_COMMA)


[style] ~16-~16: The placement of the adverb ‘api’ may sound unnatural here. Try moving it after ‘is’.
Context: ...dent on the environment in which talawa api is running. ### API_ADMINISTRATOR_USER_EM...

(PROG_ADV_PLACEMENT)


[uncategorized] ~88-~88: Possible missing comma found.
Context: ... api debugger is run within a container environment this variable must be assigned a value ...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~96-~96: Possible missing comma found.
Context: ...en talawa api is run within a container environment this variable must be assigned a value ...

(AI_HYDRA_LEO_MISSING_COMMA)


[misspelling] ~119-~119: This word is normally spelled as one.
Context: ...riable is used to configure the time in milli-seconds it takes for an authentication json web...

(EN_COMPOUNDS_MILLI_SECONDS)


[uncategorized] ~223-~223: Use a comma before ‘but’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...t in which node.js is supposed to run in but its use is no longer recommended. It is...

(COMMA_COMPOUND_SENTENCE_2)


[uncategorized] ~223-~223: If you mean ‘learn about’, ‘be aware’, or ‘stay in contact’, use “kept up with”.
Context: ...its use is no longer recommended. It is kept with a default value of production for bac...

(PHRASING_OF_KEEP_UP_WITH)


[uncategorized] ~245-~245: Possible missing article found.
Context: ...iable is used to configure the value of group id of the group assigned to the default...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~325-~325: Possible missing article found.
Context: ...vironment variable is used to configure password for the default cloudbeaver admin accou...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~343-~343: Possible missing article found.
Context: ...vironment variable is used to configure name for the default talawa cloudbeaver serv...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~349-~349: Possible missing article found.
Context: ...vironment variable is used to configure url for the default talawa cloudbeaver serv...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~391-~391: Possible missing article found.
Context: ...vironment variable is used to configure password for the default minio root user `minioa...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~445-~445: Possible missing article found.
Context: ...vironment variable is used to configure password for the default postgres postgres use...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~451-~451: Possible missing article found.
Context: ...vironment variable is used to configure name for a custom postgres user with superus...

(AI_HYDRA_LEO_MISSING_THE)

🪛 markdownlint-cli2 (0.17.2)
docs/docs/docs/developer-resources/troubleshooting.md

24-24: Bare URL used
null

(MD034, no-bare-urls)


33-33: Bare URL used
null

(MD034, no-bare-urls)


50-50: Emphasis used instead of a heading
null

(MD036, no-emphasis-as-heading)

🔇 Additional comments (4)
docs/sidebars.ts (1)

25-30: LGTM! Well-structured sidebar configuration.

The new "Developer Resources" category follows the established pattern and is appropriately positioned in the documentation hierarchy.

docs/package.json (1)

18-19: Verify Docusaurus version compatibility.

The updates to Docusaurus packages (3.6.3 → 3.7.0) appear consistent. Let's verify the compatibility and check for any breaking changes.

Also applies to: 28-30

✅ Verification successful

✅ Docusaurus version updates are compatible

The update from 3.6.3 to 3.7.0 is a minor version bump with no breaking changes. The changelog indicates only new features, bug fixes, and maintenance updates.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check Docusaurus changelog for breaking changes between versions

curl -s "https://raw.githubusercontent.com/facebook/docusaurus/main/CHANGELOG.md" | \
  awk '/## 3.7.0/,/## 3.6.3/' | \
  grep -E "^###|BREAKING"

Length of output: 280

docs/docs/docs/getting-started/installation.md (1)

16-18: LGTM! Documentation improvements.

The changes enhance the documentation by:

  1. Adding a step explaining .env file usage.
  2. Adding a reference to the environment variables page for comprehensive configuration options.
docs/docs/docs/getting-started/environment-variables.md (1)

1-6: LGTM! Well-structured front matter metadata.

The front matter metadata is properly formatted and includes all necessary fields:

  • id
  • title
  • slug
  • sidebar position

docs/docs/docs/developer-resources/troubleshooting.md Outdated Show resolved Hide resolved
docs/docs/docs/developer-resources/troubleshooting.md Outdated Show resolved Hide resolved
docs/docs/docs/developer-resources/troubleshooting.md Outdated Show resolved Hide resolved
docs/docs/docs/developer-resources/troubleshooting.md Outdated Show resolved Hide resolved
docs/docs/docs/developer-resources/pnpm-scripts.md Outdated Show resolved Hide resolved
Copy link

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@palisadoes palisadoes merged commit 64e2efc into PalisadoesFoundation:develop-postgres Jan 27, 2025
17 of 18 checks passed
@palisadoes palisadoes deleted the docs branch January 27, 2025 02:00
@coderabbitai coderabbitai bot mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant