Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Event agendas - Minor improvements and fixes #2254

Merged

Conversation

Atharva-Kanherkar
Copy link
Contributor

@Atharva-Kanherkar Atharva-Kanherkar commented Apr 22, 2024

What kind of change does this PR introduce?

Feature

Issue Number:

Fixes #2230

Did you add tests for your changes?

Yes

Snapshots/Videos:

N/A

If relevant, did you update the documentation?

No

Summary

I have made a new schema called as "Note" Which is embedded to an agenda item. Whenever you create an agenda item, you can :

  • Create a note for the agenda item by simply providing the ID.
  • Delete the note. If the agenda item is deleted, the all the notes get deleted automatically. Notes can not exist independently.
  • If a note is created, it automatically gets pushed to the notes array of an agenda item
  • The note has just the content and related agenda item fieds as the input
  • We can easily bind the interspersed agenda items and notes as each note is connected to its agenda item and can not exist independently.
  • User can make as many notes as he wants per agenda item
  • Makes note making and agenda item making more feature rich
  • Removed redundant item type enum and isNote boolean from agenda item schema
  • Added queries to fetch all the notes per agenda item
  • Added queries to fetch a particular note too
  • Also fixed the "User" Type in agenda item. It is no longer a string now. It is an array of actual, real talawa users.
  • Added field level query resolver for fetching all the users related to that agenda item.
  • All the added tests have been covered with 100% Test code coverage.

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@Atharva-Kanherkar Atharva-Kanherkar changed the title Event agendas fix feat : Event agendas - Minor improvements and fixes Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (03fe1b8) to head (496097c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2254      +/-   ##
===========================================
+ Coverage    98.45%   98.47%   +0.02%     
===========================================
  Files          343      349       +6     
  Lines        24799    25159     +360     
  Branches      2316     2347      +31     
===========================================
+ Hits         24416    24776     +360     
  Misses         380      380              
  Partials         3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Atharva-Kanherkar
Copy link
Contributor Author

Atharva-Kanherkar commented Apr 22, 2024

@palisadoes Kindly review the PR, I will add the missing tests in an hour, they didnt get uploaded because of some reason. Thank you!

@Cioppolo14
Copy link
Contributor

@Atharva-Kanherkar Please fix the failing codecov tests.

@Atharva-Kanherkar
Copy link
Contributor Author

@Atharva-Kanherkar Please fix the failing codecov tests.

Yes, in a bit.

@Atharva-Kanherkar
Copy link
Contributor Author

@Cioppolo14 I have added the necessarry tests. Please check the same...

@Atharva-Kanherkar
Copy link
Contributor Author

@Cioppolo14 @palisadoes This error does not seem to arrive because of my delta files. Could you please look into it or Tigger re-run for the tests? I think the error is because of some other issues in the codebase.

@palisadoes palisadoes merged commit 5f7b155 into PalisadoesFoundation:develop Apr 22, 2024
10 of 11 checks passed
@Atharva-Kanherkar Atharva-Kanherkar deleted the EventAgendasFix branch April 22, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants