-
-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : Event agendas - Minor improvements and fixes #2254
feat : Event agendas - Minor improvements and fixes #2254
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2254 +/- ##
===========================================
+ Coverage 98.45% 98.47% +0.02%
===========================================
Files 343 349 +6
Lines 24799 25159 +360
Branches 2316 2347 +31
===========================================
+ Hits 24416 24776 +360
Misses 380 380
Partials 3 3 ☔ View full report in Codecov by Sentry. |
@palisadoes Kindly review the PR, I will add the missing tests in an hour, they didnt get uploaded because of some reason. Thank you! |
@Atharva-Kanherkar Please fix the failing codecov tests. |
Yes, in a bit. |
@Cioppolo14 I have added the necessarry tests. Please check the same... |
@Cioppolo14 @palisadoes This error does not seem to arrive because of my delta files. Could you please look into it or Tigger re-run for the tests? I think the error is because of some other issues in the codebase. |
5f7b155
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Feature
Issue Number:
Fixes #2230
Did you add tests for your changes?
Yes
Snapshots/Videos:
N/A
If relevant, did you update the documentation?
No
Summary
I have made a new schema called as "Note" Which is embedded to an agenda item. Whenever you create an agenda item, you can :
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes