-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix minor bug: ensure single database connection on server startup #2240
fix minor bug: ensure single database connection on server startup #2240
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2240 +/- ##
===========================================
+ Coverage 98.17% 98.43% +0.25%
===========================================
Files 184 343 +159
Lines 10767 24799 +14032
Branches 835 2317 +1482
===========================================
+ Hits 10571 24410 +13839
- Misses 186 386 +200
+ Partials 10 3 -7 ☔ View full report in Codecov by Sentry. |
@meetulr Comments please |
Yes, this is what I had in mind. @lokeshwar777 I'd be better for the sake of clarity if you added a comment specifying what the check is doing, i.e. we're first checking if a connection already exists, if not, then only we're establishing a new one. |
Please add the check comments so that we can review and merge |
251d5af
to
6980bef
Compare
@meetulr PTAL again |
Yes this looks good. |
What kind of change does this PR introduce?
bugfix
Issue Number:
Fixes #2161
Did you add tests for your changes?
No
Snapshots/Videos:
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes