Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several setup script failures: develop branch #2831

Closed
palisadoes opened this issue Jan 7, 2025 · 16 comments
Closed

Several setup script failures: develop branch #2831

palisadoes opened this issue Jan 7, 2025 · 16 comments
Assignees
Labels
bug Something isn't working no-issue-activity No issue activity unapproved Unapproved for Pull Request

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 7, 2025

Describe the bug

  1. On running setup with the latest updates to the branch we get this error.
    image
  2. Setup fails when you don't previously have a .env file created (DB logging)
    image
  3. Setup fails on the subsequent attempt for storing logs
    image
  4. If you don't do DB transaction logs, you are not prompted for a storing logs. There is no error
    image
  5. When asked to load sample testing data we get this error
    image
  6. When you go through setup again and load sample data. Your answer disappears, and you get this printout.
    image
    1. The prompt reappears at the bottom only after hitting enter again
      image

To Reproduce

  • See above

Expected behavior

  1. No error because the issue has been fixed correctly, not because the error has been suppressed
  2. No other functionality must be affected
  3. Tests must be created for 100% code coverage for the setup process
  4. All tests must pass and be valid

Actual behavior

  • See above

Screenshots

image

Additional details

  • N/A

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added the bug Something isn't working label Jan 7, 2025
@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Jan 7, 2025
@bandhan-majumder
Copy link

can i work on this?

@palisadoes
Copy link
Contributor Author

palisadoes commented Jan 7, 2025

@bandhan-majumder

  1. Please thoroughly check setup. It is badly broken
  2. Write tests for 100% code coverage for the setup process.
  3. I continue to find errors. I've updated the first issue comments

@palisadoes palisadoes changed the title Fix warning on running setup: develop branch Several setup script failures: develop branch Jan 7, 2025
@bandhan-majumder
Copy link

hi @palisadoes . In the issue description, what does the 4th point mean? If I am not enabling log, it's not showing me storing log location which is fine. Logs are not generating, so cant be stored. Is there anything I am missing?

@palisadoes
Copy link
Contributor Author

Start with an empty .env file and try to set it up from scratch.

I don't think my old .env had any minio configuration parameters. That may have been past of the cause.

@palisadoes
Copy link
Contributor Author

You'll also need to add tests.

@bandhan-majumder
Copy link

Start with an empty .env file and try to set it up from scratch.

I don't think my old .env had any minio configuration parameters. That may have been past of the cause.

Sure. I will add tests if needed. Right now the changes are not too much.

@bandhan-majumder
Copy link

@palisadoes this message is everywhere. Is this causing any issue otherwise?
image

@palisadoes
Copy link
Contributor Author

palisadoes commented Jan 9, 2025

This was fixed some time ago. There needs to be a different approach to setup mongo on your local system versus in the cloud

@palisadoes
Copy link
Contributor Author

This was fixed some time ago. There needs to be a different approach to setup on your local system and in the cloud.

Look at the history of the file responsible for mongo setup

@bandhan-majumder
Copy link

Start with an empty .env file and try to set it up from scratch.

I don't think my old .env had any minio configuration parameters. That may have been past of the cause.

I started with empty .env and it is working as well. I copied the .env.example file and ran npm run setup
image

@palisadoes
Copy link
Contributor Author

What happened when you asked

  1. to setup logging
  2. not to setup logging

That's when it failed for me. I'm using node v22 as in the .node-version file

@bandhan-majumder
Copy link

What happened when you asked

1. to setup logging

2. not to setup logging

That's when it failed for me. I'm using node v22 as in the .node-version file

There was a reference error of __dirname . I added the fix in my changes.

enable logging with custom path

image

enable logging with default path

image

do not enable

image

@palisadoes
Copy link
Contributor Author

Did you add tests?

@bandhan-majumder
Copy link

No. I could not find any setup.spec.ts file. Do I need to write test from scratch?

@palisadoes
Copy link
Contributor Author

Yes. This failure keeps happening

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 20, 2025
@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity No issue activity unapproved Unapproved for Pull Request
Projects
None yet
Development

No branches or pull requests

2 participants