Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Code Coverage in src/screens/Users/Users.tsx #3298

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed linting issues
syedali237 committed Jan 16, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit d766b805f3e802494921322976b2caa78421d85a
40 changes: 39 additions & 1 deletion src/screens/Users/Users.spec.tsx
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ import {
MOCKS_NEW2,
MOCKS_NEW3,
MOCKS_NEW_2,
} from './UsersMocks';
} from './UsersMocks.mocks';
import useLocalStorage from 'utils/useLocalstorage';
import { describe, expect, it, beforeEach, afterEach, vi } from 'vitest';

@@ -841,4 +841,42 @@ describe('Testing Users screen', () => {
expect(rows.length).toBe(4);
});
});

it('renders InfiniteScroll with empty users list', async () => {
render(
<MockedProvider mocks={EMPTY_MOCKS} addTypename={false}>
<BrowserRouter>
<Provider store={store}>
<I18nextProvider i18n={i18nForTest}>
<Users />
</I18nextProvider>
</Provider>
</BrowserRouter>
</MockedProvider>,
);

await wait();
const infiniteScroll = screen.getByTestId('users-list');
expect(infiniteScroll).toBeInTheDocument();
expect(infiniteScroll).toHaveAttribute('data-length', '0');
});

it('renders InfiniteScroll with users list', async () => {
render(
<MockedProvider mocks={MOCKS_NEW} addTypename={false}>
<BrowserRouter>
<Provider store={store}>
<I18nextProvider i18n={i18nForTest}>
<Users />
</I18nextProvider>
</Provider>
</BrowserRouter>
</MockedProvider>,
);

await wait();
const infiniteScroll = screen.getByTestId('users-list');
expect(infiniteScroll).toBeInTheDocument();
expect(infiniteScroll).toHaveAttribute('data-length', '12'); // Assuming `MOCKS_NEW` returns 12 users
});
});
5 changes: 1 addition & 4 deletions src/screens/Users/Users.tsx
Original file line number Diff line number Diff line change
@@ -428,10 +428,7 @@ const Users = (): JSX.Element => {
/>
)}
<InfiniteScroll
dataLength={
/* istanbul ignore next */
displayedUsers.length ?? 0
}
dataLength={displayedUsers.length ?? 0}
syedali237 marked this conversation as resolved.
Show resolved Hide resolved
next={() => {
loadMoreUsers(displayedUsers.length, perPageResult);
}}
Original file line number Diff line number Diff line change
@@ -503,26 +503,6 @@ export const EMPTY_MOCKS = [
},
];

export const EMPTY_MOCK_NEW = [
{
request: {
query: USER_LIST,
variables: {
first: 12,
skip: 0,
firstName_contains: 'NonexistentName',
lastName_contains: '',
order: 'createdAt_DESC',
},
},
result: {
data: {
users: [],
},
},
},
];

export const createAddress = {
city: 'Kingston',
countryCode: 'JM',