-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored src/components/AgendaCategory/AgendaCategoryContainer.test.tsx from jest to vitest #2938
Refactored src/components/AgendaCategory/AgendaCategoryContainer.test.tsx from jest to vitest #2938
Conversation
….tsx from jest to vitest
WalkthroughThis pull request focuses on migrating the Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used📓 Learnings (1)src/components/AgendaCategory/AgendaCategoryContainer.spec.tsx (1)
🔇 Additional comments (2)src/components/AgendaCategory/AgendaCategoryContainer.spec.tsx (2)
The import statement correctly includes all necessary Vitest testing functions.
The mock has been properly migrated from Jest to Vitest:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #2938 +/- ##
=====================================================
+ Coverage 46.89% 88.36% +41.47%
=====================================================
Files 299 316 +17
Lines 7414 8271 +857
Branches 1621 1868 +247
=====================================================
+ Hits 3477 7309 +3832
+ Misses 3697 747 -2950
+ Partials 240 215 -25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
….tsx from jest to vitest
Rectified that |
178a9ed
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Refactoring
Issue Number:
Fixes #2791
Did you add tests for your changes?
No
Snapshots/Videos:
Here is the uploaded Snapshots for the successful test runs:
If relevant, did you update the documentation?
No
Summary
I open a PR earlier regarding the same issue... but that was having some troubles regarding the file changes in the CheckIn template... so pull and created a new PR for the issue.
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes
Summary by CodeRabbit
vi.fn()
instead ofjest.fn()
.