Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed : #2508 Refactor CSS files in src/screens/Leaderboard #2768

Conversation

pranavnathe
Copy link
Contributor

@pranavnathe pranavnathe commented Dec 24, 2024

What kind of change does this PR introduce?

Refactoring of CSS files related to the Leaderboard screen.

Issue Number:
Fixes #2508

Did you add tests for your changes?
No

Snapshots/Videos:

If relevant, did you update the documentation?
No

Summary
This PR refactors the CSS for the Leaderboard screen by moving relevant styles to the global app.module.css file.

Does this PR introduce a breaking change?
No

Other information

Have you read the contributing guide?
Yes

Summary by CodeRabbit

  • New Features

    • Introduced a new configuration schema for .coderabbit.yaml to enhance language server and review processes.
    • Added a new .env.example file for environment variable configuration.
    • Implemented a new GitHub Actions workflow for managing stale issues and pull requests.
    • Added localization support for multiple languages including English, French, Hindi, Spanish, and Chinese.
  • Bug Fixes

    • Improved error handling in various scripts and configurations.
  • Documentation

    • Enhanced README.md, INSTALLATION.md, and CONTRIBUTING.md for better clarity and navigation.
    • Added comprehensive code style and issue report guidelines.
  • Tests

    • Added new test suites for mocking and verifying functionalities.
  • Chores

    • Updated various scripts and configurations for better performance and maintainability.

DangaRanga and others added 30 commits May 23, 2021 12:21
Updated CONTRIBUTING.md with new branching strategy
…arn/dns-packet-1.3.4

Bump dns-packet from 1.3.1 to 1.3.4
* Update authorized-changes-detection.yml

* Code Coverage @ 87.1%

* Update .gitignore

* Delete codecov

This executable should not be in the repo

* added translation hint text in placeholders (#487)

* Update pull-requests.yml

* Create DOCUMENTATION.md

* Rename issue-guidelines.md to ISSUE_GUIDELINES.md

* Update CONTRIBUTING.md

* Update issue.yml

* Rename PR-guidelines.md to PR_GUIDELINES.md

* Update CONTRIBUTING.md

* Update pull-request-target.yml

* Delete PULL_REQUEST_TEMPLATE.md

* Delete ISSUE_TEMPLATE.md

* Rename Code_Style.md to CODE_STYLE.md

* added removeMember mutation (#491)

* added removeMember mutation

* changed mutation name

* remove contributions from router (#502)

* Fixed Settings page Header (#501)

* fixed cani-use lite warning

* fixed the alignments for smaller screens and also added spacing on places where it was needed

* fixed the linting errors

* ran prettier to remove styling errors

* made the orgSetting title dynamic

* linted the code and made the settings header as required and also made the settings page navbar responsive

* linted code and made necessary changes

* errors fixed

* Added dropdown for Applanguage in UserUpdation form (#498)

* Added dropdown for Applanguage in UserUpdation form

* App language code changed to Default language

* Change the Scalar Types [Provides relevant client side changes for #1085 in Talawa-API] (#500)

* Change typedefs

* Fix date parsing

* Move ID to ObjectID scalar

* Client changes for Adding GraphQL Scalars (#511)

* Change typedefs

* Fix date parsing

* Move ID to ObjectID scalar

* Revert ObjectID to ID

* Change ObjectID to ID

* modal closed after organization creation (#516)

* most recently added Org displays at the top (#515)

* Add Husky (#520)

* updated contributing (#521)

* Display and choose Organisation image (#512)

* upload image working for createOrganisation

* Organisation image showing everywhere

* Testcase failure fixed

* Linting fixed

* convertToBase64 func made and tests for it

* CI/CD error fixed

* tests added for AdminNavbar & OrganisationDashboard

* Linting fixed

* fixed translation on the plugin tab (#510)

* added OrgName to the Navbar (#525)

* Fix create event mutation [Fixes part of #1101 in Talawa-API] (#523)

* Add format fix

* Fix updation of posts

* Test coverage improved for organizationPeople.tsx (#526)

* Update INSTALLATION.md

* Update INSTALLATION.md

* Update INSTALLATION.md

* Update stale.yml

* Remove tags (#532)

* Fixed navbar added tests (#534)

* Fixed navbar added tests

* Fixed the translation of All orgnaizations btn in AdminNavbar

* Fix the updateOrg page, and made it to create mutation request [Fixes #531] (#536)

* fix orgUpdate system

* fix translations

* Update CONTRIBUTING.md

* Code Coverage @ 88%

* Fixes #478 : Implemeneted calendar to the Event tab (#537)

* calendar-implemented

* calendar-implemented

* fixed tests

* Added post-merge hook using husky (#541)

* Added post-merge hook using husky

* made required changes to installation.md

* make changes to documentation for husky

* made the required changes in installation guide

* Update pull-requests.yml

* Fixed yarn installation instructions (#584)

* organization sorting for all organization (#619)

* removed redundant notification (#577)

* Profile Page for Members (#543)

* Initial member page made

* Changed query added Org and Events section

* Homescreen ready

* initial translation added for Profile

* initial translation added for Profile

* Added translations

* Added translations

* Revised translation

* Fixed failing tests for components

* Link added to OrgAdminListCard

* Linting fixed for OrgPeopleListCard

* Added tests, removed logs

* Uniform design

* Fix:routing issue for orgdash page (#580)

* Fix:routing issue for orgdash page

* fix:failing test of SuperDashListCard

* Rectify Warnings: EventListCard.test.tsx (#595)

* Added logic to close modal after successful submission (#623)

* Feature Request: Position of the search bar.  (#631)

* Feature Request: Position of the search bar #614 resolved

* Feature Request: Position of the search bar #614 resolved

* fixes: #550 added test for the calendar (#552)

* added test for the calendar

* updates mocks

* Update Router Function [Fixes #636] (#638)

* Update Router Function

* Empty commit

* Fix about content overflow (#632)

Signed-off-by: Ekene Nwobodo <[email protected]>

* removed duplicate rows per page section in orgposts (#648)

* fixed :made card in organization dashboard interactive (#620)

* Implemented manage functionality for admin and super admin after login (#539)

* Implememnted manage functinality for admin/superadmin after login

* Update AdminDashListCard.module.css

* Some formatting issues with module file

* resolved workflow issues

* Added folding feature to posts (#581)

* added folding feature to posts

* added fold feature to posts

* brought code under code coverage

* added tests

* added tests for remainging uncovered lines

* brought code coverage to 100% for the changes

* Code coverage @87.2%

* Fix User Update Details Page and Add Update Password Page [Fixes #530] (#657)

* fixed updateuser logic

* update translations

* fix lint

* lint fix 2

* fix tests

* fixed:move orgLocation & remove duplicate orgName (#655)

* fixed:move orgLocation & remove duplicate orgName

* Dummy commit

* fixes - [#597] - Navbar navlinks hover and button styles  (#603)

* fixed: #585 - Password error showing. Tested

* fix: #590 - fixed navbar hover issues

* fix: #590 - fixed navbar hover issues

* Code Coverage 87.4%

* fixes 599 (#653)

* fixed errors and removed window.replace

* written test case for ensure window.location.replace

* written test case for ensure window.location.replace

* added useHistory to keep track of routing behind the scenes

* fixed merge conflicts and errors

* updated comments for file changes

* Added warning comments for routing

---------

Co-authored-by: Adepeju <adepeju.kayode@gmail>

* fix org search location (#682)

Signed-off-by: Ekene Nwobodo <[email protected]>

* fixed the issue of validate the input before submit #674 (#678)

* Adds required tests for OrganizationEvents.tsx and Fixes a minor bug in Calendar (#527)

* adds tests for organization events

* removes the unrequired branch from OrganizationEvents.tsx

* fixes failing tests

* fixes failing lint tests

* Update password preview feature with coverage tests (#629)

* Fix to the issue #585 (#607)

* [fix]- fixed the password error warning

* [fix]- fixed the password error warning

* [fix]- fixed the password error warning

* [fix]-fixed the password error warning

* [fix]-fixed the password error warning

* [fix]-fixed the password error warning

* [fix]-fixed the password error warning

* [feat]-added test cases for password error warning

* [feat]- added test cases for password error warning

* [feat]- added test cases for password error warning

* [fix]- fixed the linting

* Improve test coverage for calendar.tsx (#679)

* Improve test coverage for calendar.tsx

* Restore previous tests

* remove --coverage

* i rebased my codebase and resolved the initial issue (#669)

* fixed the issue use of toast in place of window.alert #645 (#687)

* Update ISSUE_GUIDELINES.md

* fixed the static time data under Organization card in the Organization List tab (#689)

* fixed the static time in org card

* formatted the date to MM D, YYYY

---------

Co-authored-by: thesaaddevloper <[email protected]>

* Fixed the pagination alignment issue (#702)

* [fix]- fixed the password error warning

* [fix]- fixed the password error warning

* [fix]- fixed the password error warning

* [fix]-fixed the password error warning

* [fix]-fixed the password error warning

* [fix]-fixed the password error warning

* [fix]-fixed the password error warning

* [feat]-added test cases for password error warning

* [feat]- added test cases for password error warning

* [feat]- added test cases for password error warning

* [fix]- fixed the linting

* [fix]- fixed the pagination alignment issue

* [fix]- fixed the pagination alignment issue

* [fix]- fixed the pagination alignment issue

* Removed overlapping (#675)

* changes input element to textarea and changes in test (#710)

* Code Coverage @90.7%

* Indicating active tabs (#691)

* added underline to active links in navbar

* fixed lint error

* fixed the org default image #688 and removed stock image (#695)

* fixed the org default image #688 and removed stock image

* removed eslint warning

* added new img as default org img

* Update INSTALLATION.md

* Added Clear Error and Warn Messages when API is unavailable (#670)

* Added error and warn messages

* Added tests & fixed inconsistency in mocks

* Lint fix LoginPage

* Lint Fix LoginPage.test

* minor fix

* Minor update to LoginPage

* Minor change to LoginPage.test

* Replaced toast.warn() with toast.error()

* Fixed test accordingly

* Lint Fix

* Minor fix

* Extra edge case handled

* code coverage fix

* Lint fix

* Update LoginPage

* Update LoginPage.test

* Lint fix

* improve test coverage for orgpost.tsx (#718)

* Improve test coverage for calendar.tsx

* Restore previous tests

* remove --coverage

* improve test for orgpost.tsx

* Implemented Proper Error Handling for all Screens [Fixes: #535] (#731)

* Handled error cases for all screens

* Some more fixes

* Some more fixes

* Added StaticMockLink to use Mocks multiple times [Fixes Multiple Issues] (#745)

* add StaticMockLink

* lint fix

* remove showWarning

* Added prompt to Register on Login Page (#628)

* Add prompt to Login page
- Add prompt in other languages: fr, sp, hi, zh.
- switch styling of Login Button with Reg Button

* format with prettier

* fixed event checkboxes to update (#707)

* Block/Unblock functionality for only members of the organization (#690)

* Implememnted manage functinality for admin/superadmin after login

* Update AdminDashListCard.module.css

* Some formatting issues with module file

* resolved workflow issues

* Updated block/unblock page preventing users who are not members of organiztion

* Update BlockUser.test.tsx to resolve failing tests

Modified the mocks fields according to the corresponding changes in BlockUser.tsx file.

* created a reusable postNotFound Component with responsive UI (#717)

* created a reusable postNotFound Component with responsive UI

* run test error solved

* added translation to the component and also created the test.tsx for the error component

* fixed the failing test and added the postNotFound reusable component for OrgList

---------

Co-authored-by: thesaaddevloper <[email protected]>

* fix: #601 modal responsive width (#621)

* added dynamic title to OrgPeople section (#704)

* added dynamic title to OrgPeople section

* fixed code coverage

* fixed code coverage

* uncommented the mistakenly added code

* Delete er

* Updated session timeout notification toast with already existing one (#734)

* Added a toast to notify users that session has expired and redirects to the login page

* Updated toast notification on session timeout  with already existing one

* eliminated the use of  magic numbers

* minor error correction on the timeout minutes

---------

Co-authored-by: TheoCathy <[email protected]>

* Fixed the empty space in the OrgList (#751)

* created a reusable postNotFound Component with responsive UI

* run test error solved

* added translation to the component and also created the test.tsx for the error component

* fixed the failing test and added the postNotFound reusable component for OrgList

* fixed the empty space in orgList

* fixed the failing test

* removed the unwanted files

---------

Co-authored-by: thesaaddevloper <[email protected]>

* align navbar items (#755)

* align navbar items

* replace More with a hamburger icon

* replace More with a hamburger icon to fix workflow error

* replace More with a hamburger icon to fix workflow error

* Fixes: toggle password for registration  (#758)

* added toggle-password

* updated

* formatting

* added icon for toggle password

* Super Admin Dashboard Error When Organizations Absent (#754)

* No Organization Warning on OrgList

* Minor Fix

* Fixed failing tests

* Added Warning on Roles and Request Pages

* Added Tests for OrgList

* Testing Fixes

* Added more tests

* Added Tests for Roles and Request Pages

* Code Coverage @ 91.0%

* Add link to dashboard admin card (#760)

* image upload made functional (#677)

* image upload made functional

* lint

* fixed failing test

* linting

* re run test , remove yarn.lock changes

* updateUser test cov

* OrgPost

* rerun tests

* Empty commit

* reverted last 2 commits changes

* re run code cov

* update userUpdate

* rerun code cov again

* revert last commit

* Update PR_GUIDELINES.md

* Implemented Search bar and the radio buttons in orgPost page that searches both title and text of post (#770)

* created a reusable postNotFound Component with responsive UI

* run test error solved

* added translation to the component and also created the test.tsx for the error component

* fixed the failing test and added the postNotFound reusable component for OrgList

* fixed the empty space in orgList

* fixed the failing test

* removed the unwanted files

* the one search bar which searches both text and title of post

* testing file

* orpost file testing

* code coverage is increased

* fixed the failing test

---------

Co-authored-by: thesaaddevloper <[email protected]>
Co-authored-by: saadabban76 <�[email protected]>

* center org image on mobile (#778)

Signed-off-by: Ekene Nwobodo <[email protected]>

* removed link for plugin dropdown toggle (#781)

* removed link for plugin dropdown toggle

* added id

* align superadmin nav items and fix failed tests (#766)

* changed the handleSearchByName function in searchByName in Roles page (#735)

* changed the handleSearchByName function to search using target's value instead of searchByName variable

* updated the file Roles.tsx to take care of useState lag

* changed tests for suiting searchByName

* changed tests for searchByName including backspaces

* added tests for paginationList and changing rowsPerPage

* added tests to increase coverage in Roles.tsx

* changed the package.json file's test command

* removed extra scrollbars (#800)

* Recently added Post displays at top (#773)

* Recently added Post displays at top

* reversed the posts as required in the query

* Increased the OrgList Code Coverage (#786)

* increased the orgList coverage to 95$

* increased the orgList Code Coverage

* increased the orgList Code Coverage

* increased the orgList Code Coverage

* fixed image rendering in orgPost page

* increased the code coverage for orgList Component

* increased code coverage to 97% in orgList Component

---------

Co-authored-by: saadabban76 <�[email protected]>

* Modify event visibility for non-admins (#796)

* Modify event visibility for non-admins

Signed-off-by: Ekene Nwobodo <[email protected]>

* Add test suites for events visibilty

---------

Signed-off-by: Ekene Nwobodo <[email protected]>

* Bug Fix: Drawer menu visibility (#794)

* Remove filter by event field (#807)

* increased the orgList coverage to 95$

* increased the orgList Code Coverage

* increased the orgList Code Coverage

* increased the orgList Code Coverage

* fixed image rendering in orgPost page

* increased the code coverage for orgList Component

* increased code coverage to 97% in orgList Component

* removed the filter by event section in orgPeople's component

* fixed the failing test

---------

Co-authored-by: saadabban76 <�[email protected]>

* Add image to post (#804)

* increased the orgList coverage to 95$

* increased the orgList Code Coverage

* increased the orgList Code Coverage

* increased the orgList Code Coverage

* fixed image rendering in orgPost page

* increased the code coverage for orgList Component

* increased code coverage to 97% in orgList Component

* added Image to the post's card

* replaced external links with codebase default image

* replaced external links with codebase default image

* replaced blank image with the default image

* fixed the failing test

---------

Co-authored-by: saadabban76 <�[email protected]>

* Update pull-request-target.yml

* Update pull-request-target.yml

* Update pull-request-target.yml

* Update pull-request-target.yml

* Update pull-request-target.yml

* Update pull-request-target.yml

* Upgrade Yarn to NPM in Talawa Admin Project (#802)

* npm upgrade

* remove package lock

* Update push.yml

* empty

* upgrade yarn to npm

* fix docs

* fix scripts

* empty

* stop watch mode

* fix ymls

* empty

* fix scripts

* empty commit

* update scripts

* Redirect to dashboard on organization update (#816)

* Redirect to dashboard on organization update

* Minor Change

* Proper Testing Of Pagination In All List Views (#797)

* install faker package used for mocks in tests

* Test init for pagination

* install dependencies needed to implement certain tests

* add a data-testid attribute to their markup for use in tests

* add data-testid attributes to its markup being referenced from tests

* add test to ensure the number of organization displayed on the page corresponds to the option selected from rowsPerPage

* add prop to allow rendering of component in test environment

* add data-testid attributes to their markup being referenced from tests

* add data-testid attributes to its markup being referenced from tests

* add test to affirm that the number of persons displayed on the webpage is same with the selected option from rowsPerPage

* install dependencies for certain tests

* fix lint errors

* tests fix

* remove unnecessary dependencies

* lint fix

* tests fix update

* restore file to previous state

* empty commit

* tests fix update

* lint fix

* Conditional Usage of Google reCAPTCHA [Fixes #798] (#820)

* conditonal recaptcha

* Update INSTALLATION.md

* add tests

* fixed the issue of Mismatched passwords validation #722 (#824)

* fixed the issue of Mismatched passwords validation #722

* fixed lint code error

* Code Coverage @ 92%

* Replace Talawa Portal with Talawa Admin Portal #817 (#821)

* Update website title to Talawa Admin Portal in en

* Update website title in fr json file

* Update website title in sp json file

* Update website title in zh json file

* Update website title in hi json file

* Update the test in ListNavbar file

* Update the test in LoginPage.test file

* Create a function for the tex macher to make test

* Fix lint errors in the LandingPage test file

* Remove console.log in LandingPage test file

* Upgrade to use npm instead of yarn

* Delete yarn.lock file

* Fix lint errors

* Fix lint errors

* Update the heading in hi.json file

* Remove unused codes

* Fix lint error in LanfingPage file

* Correct the talawa_portal value in Fr json file

* Correct the talawa_portal value in sp json file

* Remove anused package in package.json file

* Organization Form Redirect Issue Prevents User Navigation, Affecting User Experience.  Issue #808 (#815)

* addressing issue #808

* finished - requested changes

* addressing warning

* Added:  event preview modal to view event details (#772)

* added event preview model

* added event preview model

* fixed formatting

* added test

* added test

* added test

* failing tests

* test

* tests

* Update workflow (#832)

* Workflow fix (#833)

* Update pull-requests.yml

* Update pull-requests.yml

* Update pull-requests.yml

* Code Coverage @ 91.0%

* Feature: Separation of ADMIN and SUPERADMIN functionalities (#826)

* Initial changes

* Commit to sync repo

* Made changes to OrgList

* Some fixes

* Minor fix

* Added tests for OrgList

* Added tests for OrgList

* Coverage fix

* Required changes added

* Made changes to OrgList

* Some fix

* Some fixes

* fixes test for OrgList

* Some more fixes

* Empty commit

* Lint fix

* Fixed test

* Lint fix

* Added Whitespace Validation to Organization and Post create forms (#838)

* Added whitespace check in Org Create form

* Added Tests

* Added Empty String check to OrgPost Form

* Added Tests for OrgPost

* fixed the issue of Toast msg is not available in all languages #740 (#845)

* fixed the issue of Toast msg is not available in all languages #740

* format issue

* Empty-Commit

* Fixed Org Update (#843)

* Prevent Admins and Super Admins from downgrading their own roles (#840)

* Code Cleanup

* Disabled Super Admins from changing their roles

* Added Tests

* Added more tests

* Improved Code Quality

* Revert "Fixed Org Update (#843)" (#847)

This reverts commit 53c3fef28ef986d63b1eec45663acb7d07cf1b8d.

* Fixed Organization Update and Translation (#849)

* Fixed Organization Update

* Minor Changes

* Success message updated

* Fail tests on warning [Priority Needed] (#856)

* fix warnings

Signed-off-by: Ansh Goyal <[email protected]>

* fix warnings

Signed-off-by: Ansh Goyal <[email protected]>

* fix warnings

Signed-off-by: Ansh Goyal <[email protected]>

* fix warnings

Signed-off-by: Ansh Goyal <[email protected]>

* fix warnings

Signed-off-by: Ansh Goyal <[email protected]>

* restore addonregister

Signed-off-by: Ansh Goyal <[email protected]>

---------

Signed-off-by: Ansh Goyal <[email protected]>

* Code duplicacy removed (#852)

* Code duplicacy removed

* Tests added

* Added comments

* Fixed failing tests

* Code formatted

* Unused packages removed, flag icons package updated to latest version (#860)

* Unused packages removed, flag icons updated to latest version

* Empty commit

* Changes in package-lock.json

* Fixes #848: limiting mulitple toast (#851)

* limiting-toast

* added test

* Organization People Filters Improved (#855)

* Added Filters to Users and Organizations Query

* Added Last Name Filter on User, Member and Admin

* Added Translation

* Fixed Failing Tests

* Added Tests for Filters

* Fixed Failing Tests

* Code Cleanup

* Fixed Tests

* Added Translation

* remove graphql-boost dep (#866)

Signed-off-by: Ansh Goyal <[email protected]>

* added UserNotFound component to the Roles page and improved the search (#865)

* changed the handleSearchByName function to search using target's value instead of searchByName variable

* updated the file Roles.tsx to take care of useState lag

* changed tests for suiting searchByName

* changed tests for searchByName including backspaces

* added tests for paginationList and changing rowsPerPage

* added tests to increase coverage in Roles.tsx

* changed the package.json file's test command

* changed PostNotFound component to be used as a reusable one and added it in Roles section and set languages option in locales folder

* changed formatting in locales changed files

* removed comments in Roles.tsx

* Empty commit

* renamed the PostNotFound component and modifiied relevant files

* changed Roles.tsx filtering

* empty commit

* reverted changes in package.json

* Improved signupform validations (#828)

* Improved signupform validations

* updated signup form validation to show all messages at once

* improved test coverage for LoginPage

* Fixed failing test

---------

Co-authored-by: Joyce Malicha <[email protected]>

* added tests for Search Bar in the Organization List Page of SUPERADMIN #827 (#867)

* added tests for Search Bar in the Organization List Page of SUPERADMIN #827

* added tests for Search Bar in the Organization List Page of SUPERADMIN #827

* Added Tests Previews (#868)

* Installed jest-preview

* Automatic Setup

* Fiixed Failing Test Command

* Added Basic CSS

* Added PostCSS Module

* Fixed MUI Styling

* Minor Changes

* Added cross-env to support windows

* Adaptar for React 17 and CSS Modules Mock

* Added Mocked Styles to Tests

* Documentatin Updated

* Fixed Failing Tests

* Minorr change in documentation

* Jest is now Dev Dependency

* Workflow Test

* Jest Module Path Updates

* Module Path Tese 2

* Github Workflow Fixed

* Removed Legacy Test Command

* Added Documentation to Debug Tests

* Fixed Documentation

* Docs Image Added To Repo

* Images Reorganization

* Organized Images

* Revert "Improved signupform validations (#828)" (#875)

This reverts commit 5820dd9ec05256551b48470c8880fcdc05452fda.

* Restored SearchBar Test for OrgList Page (#878)

* Restored searchBar test

* Lint fix

* Coverage fix

* Lint fix

* Some fixes

* Some fixes

* fixed the issue of Users filter to fetch corresponding Users to Organisation #701 (#853)

* fixed the issue of Users filter to fetch corresponding Users to Organisation #701

* removedd uunused variable

* fixed failing text

* fixed merged issue

* fixed lint error

* swap variable

* Revert "Restored SearchBar Test for OrgList Page (#878)" (#879)

This reverts commit 3d39c524d54e81853490d2d8a1f844ce67252365.

* Fixed crashing on error in Block/Unblock page (#862)

* Website crash fixed

* lint fixed

* Added tests for empty response from server

* More tests added

* Rerun tests empty commit

* Redirect on error functioning

* Fixed failing tests

* Testcase and Title added when users not found

* Linting fixed

* Typo fixed

* Fixed failing tests

* Linting fixed

* Added NotFound component in OrgPeople and changed Roles.tsx  (#882)

* changed the handleSearchByName function to search using target's value instead of searchByName variable

* updated the file Roles.tsx to take care of useState lag

* changed tests for suiting searchByName

* changed tests for searchByName including backspaces

* added tests for paginationList and changing rowsPerPage

* added tests to increase coverage in Roles.tsx

* changed the package.json file's test command

* changed PostNotFound component to be used as a reusable one and added it in Roles section and set languages option in locales folder

* changed formatting in locales changed files

* removed comments in Roles.tsx

* Empty commit

* renamed the PostNotFound component and modifiied relevant files

* changed Roles.tsx filtering

* empty commit

* reverted changes in package.json

* added NotFound component in OrgPeople, made changes in the locales files and made some changes to Roles too

* added NotFound component to OrgPeople, changerd locales files and changed Roles.tsx

* minor change

* Restored Search-Bar Test for OrgList Page (#880)

* Restored searchBar test

* Lint fix

* Coverage fix

* Lint fix

* Some fixes

* Some fixes

* Fixed Org Dashboard Error (#873)

* Fixed TypeError

* Minor Change

* Fixed Tests

* Added back logo512

* Fixed auth header getting copied on login (#890)

* fix user update  (#876)

* fix user detials update

* remove userType from update-user page

* fix failed test for userUpdate.test.tsx

* Removed and Replaced Ant Design from the project (#891)

* Fixed auth header getting copied on login

* Removed/Replaced  Ant Design from the project

* Fixed failing tests

* Removed comment

* Add today functionality in calendar (#897)

* Update countline.py

* Update pull-requests.yml

* Updated countlines.py to cover .spec. files (#900)

Co-authored-by: Peter Harrison <[email protected]>

* fixed the Inability to set user roles for specific organizations #556 (#898)

* fixed the Inability to set user roles for specific organizations #556

* added all language translation

* Revert "fixed the Inability to set user roles for specific organizations #556 (#898)" (#901)

This reverts commit 891d898eb5543116bb9042a6386b5a12e474159c.

* Documentation updated, Redundant css files removed (#896)

* Doc updated unused files removed

* Removed unused css files from setup tests

* Added small calendar in the events #887  (#903)

* added small clanedar

* added small clanedar

* fixed Code Coverage: Create tests for OrgSettings.tsx #396 (#905)

* remove redundancy from orgPostCard (#906)

* Revert "remove redundancy from orgPostCard (#906)" (#910)

This reverts commit d5ce4aa27ee241b0687f7db3d6acd1b62339562f.

* Block/Unblock Page Improvements (#885)

* Added Radio Buttons

* Optimized Queries

* Optimized Query and Added Last Name Filter

* Radio Button Working

* Added Translations

* Fixed Filter Name

* Fixed Debounce

* Fixed Asynchronous Debounce

* Added Tests

* Better Error and Loading State Handline

* Fixed Loader

* Fixed Loader

* Modulrised Mock Data

* Minor Change

* Fixed Tests

* Increase Coverage

* User query replaced with OrgMemberConnection

* Fixed Tests

* Code Coverage Increase

* Code Cov

* Fixed Translations

* Fixed Failing Tests

* fix in failing test (#913)

* Improve and Standardize Automated Linting Tests (#916)

* added linting rules

* added linting rules

* added linting rules

* Rename `data` variables to more readable name [Fixes #829] (#835)

* Refactor screens

* Update components

* Fix test

* Fix typecheck errors

* Increase test coverage

* Merge latest adminUI-Redesign into Develop (#927)

* Updated CODE_STYLE.md

* Updated CODE_STYLE.md (#917)

* Updated CODE_STYLE.md

* Import section update

* Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925)

* Updated CODE_STYLE.md

* Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed

* Buttons replaced from normal ones to Bootstrap ones

* Import section update

* Error fixed for Buttons

* Language dropdowns and Change language

* InputBoxes & Checkboxes fixed and imported from BS

* Removed unused package popper.js

* Replaced react-modal with Bootstrap one in Login Page

* Modals converted to React Bootstrap one

* Completely replaced react-modal with react-bootstrap/Modal from the project

* Removed react-modal from the project

* Removed classbased modal and unused images

* Notification navbar migrated

* Modal migration

* Modal migration

* Modal migration done for OrgPostCard

* Empty commit to make workflow run

* Empty commit to make workflow run

* Empty commit to run the workflow

---------

Co-authored-by: Anwer Sayeed <[email protected]>

* Introduces API versioning check in CI/CD (#924)

* a random change

* husky precommit

* one more try

* one more try

* one more try

* one more try

* one more try

* one more try

* second try

* removed unwanted deps

* removed unwanted deps

* resolved the error

* updated variable name

* rerun test

* rerun test

* added test to pull.yml

* removed push check

* resolved conflict

* Update stale.yml

* Update CONTRIBUTING.md

* Merge talawa-user-portal into develop (#935)

* Create login and register page for user portal

* Lint public locales

* Create tests for login page components

* Add react import in tests

* Create organizations screen for user portal

* Fix failing tests and lint code

* fix failing tests

* Add tests for organization screen and componenets

* Fix non-null assertions

* Fix non-null assertions in organizations test

* Fix bootstrap migration changes

* Merge latest Admin UI Redesign into Develop (#934)

* Updated CODE_STYLE.md

* Updated CODE_STYLE.md (#917)

* Updated CODE_STYLE.md

* Import section update

* Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925)

* Updated CODE_STYLE.md

* Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed

* Buttons replaced from normal ones to Bootstrap ones

* Import section update

* Error fixed for Buttons

* Language dropdowns and Change language

* InputBoxes & Checkboxes fixed and imported from BS

* Removed unused package popper.js

* Replaced react-modal with Bootstrap one in Login Page

* Modals converted to React Bootstrap one

* Completely replaced react-modal with react-bootstrap/Modal from the project

* Removed react-modal from the project

* Removed classbased modal and unused images

* Notification navbar migrated

* Modal migration

* Modal migration

* Modal migration done for OrgPostCard

* Empty commit to make workflow run

* Empty commit to make workflow run

* Empty commit to run the workflow

* Sass filed added with documentation

* Linting fixed

* Fixed the folder structure and naming convention

* Customised Bootstrap  (#929)

* Sass filed added with documentation

* Linting fixed

* Fixed the folder structure and naming convention

* Assets typo fixed

* Typo fix

* Merge conflict error fixed

---------

Co-authored-by: Anwer Sayeed <[email protected]>

* test PR for API versioning check (#932)

* testPR

* test2

* testing the change

* testing it again

* test--no-verify

* test--no-verify

* echo token

* test-again

* test-again

* test

* test

* read-only

* clone

* clone

* redesigned newsfeed (#939)

* Revert "redesigned newsfeed (#939)" (#943)

This reverts commit a645eca7cf2ce1335374f48b52335a293e344580.

* Make Talawa-Admin mutations in sync with the backend (#946)

* Initial change

* Redundant Notification removed

* Fixed linting and other issues

* Tests fixed

* Add Home Screen And People Screen along with other components (#940)

* Create login and register page for user portal

* Lint public locales

* Create tests for login page components

* Add react import in tests

* Create organizations screen for user portal

* Fix failing tests and lint code

* fix failing tests

* Add tests for organization screen and componenets

* Fix non-null assertions

* Fix non-null assertions in organizations test

* Fix bootstrap migration changes

* Add Home Screen along with other components

* Fix failing tests

* Add required tests and Offcanvas navbar

* Remove unused variables from tests

* Sync the Mutations with talawa-api

* Merge AdminUI-Redesign into Develop (#947)

* Updated CODE_STYLE.md

* Updated CODE_STYLE.md (#917)

* Updated CODE_STYLE.md

* Import section update

* Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925)

* Updated CODE_STYLE.md

* Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed

* Buttons replaced from normal ones to Bootstrap ones

* Import section update

* Error fixed for Buttons

* Language dropdowns and Change language

* InputBoxes & Checkboxes fixed and imported from BS

* Removed unused package popper.js

* Replaced react-modal with Bootstrap one in Login Page

* Modals converted to React Bootstrap one

* Completely replaced react-modal with react-bootstrap/Modal from the project

* Removed react-modal from the project

* Removed classbased modal and unused images

* Notification navbar migrated

* Modal migration

* Modal migration

* Modal migration done for OrgPostCard

* Empty commit to make workflow run

* Empty commit to make workflow run

* Empty commit to run the workflow

* Sass filed added with documentation

* Linting fixed

* Fixed the folder structure and naming convention

* Customised Bootstrap  (#929)

* Sass filed added with documentation

* Linting fixed

* Fixed the folder structure and naming convention

* Assets typo fixed

* Typo fix

* Initial login page work

* Merge conflict error fixed

* Theming modified and Added Loader over every screen

* Fixed UI issue for navbar and login

* Fixed production bug

* Removed unused variable

* Tests fixed

* Added Change Language Btn dropdown

* Merge conflict fixed, merge latest develop into adminUI-redesign (#938)

* Merge latest adminUI-Redesign into Develop (#927)

* Updated CODE_STYLE.md

* Updated CODE_STYLE.md (#917)

* Updated CODE_STYLE.md

* Import section update

* Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925)

* Updated CODE_STYLE.md

* Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed

* Buttons replaced from normal ones to Bootstrap ones

* Import section update

* Error fixed for Buttons

* Language dropdowns and Change language

* InputBoxes & Checkboxes fixed and imported from BS

* Removed unused package popper.js

* Replaced react-modal with Bootstrap one in Login Page

* Modals converted to React Bootstrap one

* Completely replaced react-modal with react-bootstrap/Modal from the project

* Removed react-modal from the project

* Removed classbased modal and unused images

* Notification navbar migrated

* Modal migration

* Modal migration

* Modal migration done for OrgPostCard

* Empty commit to make workflow run

* Empty commit to make workflow run

* Empty commit to run the workflow

---------

Co-authored-by: Anwer Sayeed <[email protected]>

* Introduces API versioning check in CI/CD (#924)

* a random change

* husky precommit

* one more try

* one more try

* one more try

* one more try

* one more try

* one more try

* second try

* removed unwanted deps

* removed unwanted deps

* resolved the error

* updated variable name

* rerun test

* rerun test

* added test to pull.yml

* removed push check

* resolved conflict

* Sass filed added with documentation

* Linting fixed

* Fixed the folder structure and naming convention

* Update stale.yml

* Typo fix

* Update CONTRIBUTING.md

* Merge talawa-user-portal into develop (#935)

* Create login and register page for user portal

* Lint public locales

* Create tests for login page components

* Add react import in tests

* Create organizations screen for user portal

* Fix failing tests and lint code

* fix failing tests

* Add tests for organization screen and componenets

* Fix non-null assertions

* Fix non-null assertions in organizations test

* Fix bootstrap migration changes

* Merge conflict error fixed

---------

Co-authored-by: Anwer Sayeed <[email protected]>
Co-authored-by: Kanishka Bansode <[email protected]>
Co-authored-by: Peter Harrison <[email protected]>
Co-authored-by: Noble Mittal <[email protected]>

* Random checkout

* Design ready for homescreen

* Login page 100% code c=coverage

* Login page icon adjustment

* Added translations

* Fixed the failing tests

* Revert to older version of loader

* Animation added fixed warnings

* Fixed accessability

* Mutations and Tests foxed

* Fixed coloring in UserPortal

* Tests fixed and ChangeLanguageDropdown used in UserLoginPage

* Linting Fixed

---------

Co-authored-by: Anwer Sayeed <[email protected]>
Co-authored-by: Kanishka Bansode <[email protected]>
Co-authored-by: Peter Harrison <[email protected]>
Co-authored-by: Noble Mittal <[email protected]>

* Merge latest adminUI-Redesign (#950)

* Initial Organizations screen done

* Removed yellow scrollbar

* Linting fixed

* Replaced images with svgs for logos

* Styling done for btnsContainer

* Better typechecking and readability

* Animated Drawer working

* Responsive page ready

* OrgCard responsive

* Fixed navbar issue and added webkit keyframes

* LeftDrawer ready

* Translations added

* Added shimmer loading effect

* Styling issue fixed

* Failing tests fixed for OrgList

* Removed unused vars

* Tests done for LeftDrawer

* Succesfully made component without causing any breaking change

* 100% Code coverage achieved for Requests Screen

* Fix alignment

* Roles screen UI done

* Role screen fixed with 100% test coverage

* Changing screen activeness fixed

* Unused vars and Typos fixed

* Language support added

* Linting and typos fixed

* Fixed failing tests for LeftDrawer

* Completed tests of AdminDashListCard with 100% code coverage

* OrgListCard done

* Finalised tests

* Requests user search made functional again !

* Fixed loading on refetch and UX on all screens

* OrgList failing errors fixed

* Fixed all failing tests

* Achieved 100% code coverage for OrgList.tsx

* Wrote tests and mod LeftDrawer for admins

* Minor ui issue fixed

* Fixed failing test

* UI bug dropdown

* Frontend insync with Backend attempt 1

* Introspection fail fix 1

* Introspection error fix 3

* Introspection error fix another attempt

* Another attempt

* [Talawa-user-portal] Add Settings and Donate Screen, along with other UI fixes (#953)

* Create login and register page for user portal

* Lint public locales

* Create tests for login page components

* Add react import in tests

* Create organizations screen for user portal

* Fix failing tests and lint code

* fix failing tests

* Add tests for organization screen and componenets

* Fix non-null assertions

* Fix non-null assertions in organizations test

* Fix bootstrap migration changes

* Add Home Screen along with other components

* Fix failing tests

* Add required tests and Offcanvas navbar

* Remove unused variables from tests

* Sync the Mutations with talawa-api

* Add Settings and Donate Screen

* Add multilingual support for the screens

* Add Event Project and Volunteer Management (#961)

* Add screens for adding and updating event projects

* Add delete operation for event projects and debug update

* Remove yarn.lock

* Begin testing

* Add display of tasks and functionality to add tasks

* Add modal for edit task

* Add UpdateTaskModal

* Add Delete Task Modal and volunteers display

* Add test for DeleteEventProjectModal.tsx

* Add tests for add and update event project modal

* Add screen for managing volunteers

* Add option to assign and remove volunteers

* Add tests for AddTaskModal.tsx

* Add tests for TaskListItem.tsx and DeleteTaskModal.tsx

* Complete testing for all Task Modals

* Add completed display to tasks

* Add tests for event dashboard

* Restructure files

* Add attendee management modal

* Add testing for EventAttendeeModal

* Move to 100% testing and wrapper for attendees modal

* Add basic checkIn functionality for users

* Add testing for CheckIn modals

* Introduce the tag generation into the repository

* Update linting rule and fix errors

* Remove alloted seat and alloted room

* Fix testing

* Correct some tests

* Migrate from attendees to registrants

* Migrate Event Project modals to new design

* Migrate registrants modals and checkin modals to new design with 100% test coverage

* Move task modals to new styles

* Move to 100% test coverage

* Admin workflow completed with updated package.json (#960)

* Merge latest AdminUI Redesign into develop (#956)

* Initial Organizations screen done

* Removed yellow scrollbar

* Linting fixed

* Replaced images with svgs for logos

* Styling done for btnsContainer

* Better typechecking and readability

* Animated Drawer working

* Responsive page ready

* OrgCard responsive

* Fixed navbar issue and added webkit keyframes

* LeftDrawer ready

* Translations added

* Added shimmer loading effect

* Styling issue fixed

* Failing tests fixed for OrgList

* Removed unused vars

* Tests done for LeftDrawer

* Succesfully made component without causing any breaking change

* 100% Code coverage achieved for Requests Screen

* Fix alignment

* Roles screen UI done

* Role screen fixed with 100% test coverage

* Changing screen activeness fixed

* Unused vars and Typos fixed

* Language support added

* Linting and typos fixed

* Fixed failing tests for LeftDrawer

* Completed tests of AdminDashListCard with 100% code coverage

* OrgListCard done

* Finalised tests

* Requests user search made functional again !

* Fixed loading on refetch and UX on all screens

* OrgList failing errors fixed

* Fixed all failing tests

* Achieved 100% code coverage for OrgList.tsx

* Wrote tests and mod LeftDrawer for admins

* Minor ui issue fixed

* Fixed failing test

* UI bug dropdown

* Frontend insync with Backend attempt 1

* Introspection fail fix 1

* Introspection error fix 3

* Introspection error fix another attempt

* Another attempt

* Fixed Default Animation on Organizations Screen

* Fixed typo

* Loading data from localstorage functional

* Fixed name conventions

* Fixed typo

* UI Fix

* Changed screen name

* Table Loader added

* Added LeftOrg drawer and Organization screen comp to Screens

* routesReducer tests fixed

* Redundant adminNavbar removed from project

* MemberDetail issue fixed

* Achieved 100% code coverage for LeftDrawerOrg, Added Empty div in images

* Fixed failing tests

* Fix tests

* Fixed warnings

* Linting fixes

* Linting issues fixed

* Achieved 100% code coverage for CollapsibleDropdown

* Achieved 100% CC on IconComponent and removed useless imports

* Achieved 100% cc for LeftDrawer Component

* Achieved 100% CC on SuperAdminScreen Component

* Fixed typo

* Integrated Event Dashboard

* Failing tests for LeftDrawer LeftDrawerOrg OrgList screen fixed

* Removed redundant code

* Removed useless imports

* Linting fixed

* Removed LeftDrawerOrg

* Update documentation

* copy-docs -to-talawa branch update to develop

* removed dependance of code copying from generate segment

* Update push.yml (#969)

* Update push.yml (#970)

* Feature Request: Adding a dialog to go to plugin store after an organization is created by the admin (#951)

* Add/ test for OrgPost.tsx

* fix:  org post back to default

* Added Dialog 2

* Updated Dialog UI

* Removed Extra code

* Updated Plugin store

* fix: warnings and solves #951  & #948

* fix: warnings and solves #951  & #948

* fix: warnings and solves #951  & #948

* Fix: UI Redesign

* fix: merge

* fix

* Update AddOnStore.tsx

* Fixed Merge Errors

* Add test: for OrgEntry

* Test 3

* fix test 4

* Merge latest AdminUI Redesign into develop (#972)

* Initial Organizations screen done

* Removed yellow scrollbar

* Linting fixed

* Replaced images with svgs for logos

* Styling done for btnsContainer

* Better typechecking and readability

* Animated Drawer working

* Responsive page ready

* OrgCard responsive

* Fixed navbar issue and added webkit keyframes

* LeftDrawer ready

* Translations added

* Added shimmer loading effect

* Styling issue fixed

* Failing tests fixed for OrgList

* Removed unused vars

* Tests done for LeftDrawer

* Succesfully made component without causing any breaking change

* 100% Code coverage achieved for Requests Screen

* Fix alignment

* Roles screen UI done

* Role screen fixed with 100% test coverage

* Changing screen activeness fixed

* Unused vars and Typos fixed

* Language support added

* Linting and typos fixed

* Fixed failing tests for LeftDrawer

* Completed tests of AdminDashListCard with 100% code coverage

* OrgListCard done

* Finalised tests

* Requests user search made functional again !

* Fixed loading on refetch and UX on all screens

* OrgList failing errors fixed

* Fixed all failing tests

* Achieved 100% code coverage for OrgList.tsx

* Wrote tests and mod LeftDrawer for admins

* Minor ui issue fixed

* Fixed failing test

* UI bug dropdown

* Frontend insync with Backend attempt 1

* Introspection fail fix 1

* Introspection error fix 3

* Introspection error fix another attempt

* Another attempt

* Fixed Default Animation on Organizations Screen

* Fixed typo

* Loading data from localstorage functional

* Fixed name conventions

* Fixed typo

* UI Fix

* Changed screen name

* Table Loader added

* Added LeftOrg drawer and Organization screen comp to Screens

* routesReducer tests fixed

* Redundant adminNavbar removed from project

* MemberDetail issue fixed

* Achieved 100% code coverage for LeftDrawerOrg, Added Empty div in images

* Fixed failing tests

* Fix tests

* Fixed warnings

* Linting fixes

* Linting issues fixed

* Achieved 100% code coverage for CollapsibleDropdown

* Achieved 100% CC on IconComponent and removed useless imports

* Achieved 100% cc for LeftDrawer Component

* Achieved 100% CC on SuperAdminScreen Component

* Fixed typo

* Integrated Event Dashboard

* Failing tests for LeftDrawer LeftDrawerOrg OrgList screen fixed

* Removed redundant code

* Removed useless imports

* Linting fixed

* Removed LeftDrawerOrg

* Dashboard screen ui almost ready

* Org Dash ready

* Block/Unblock screen ready

* Organization settings page ready

* Lang changes

* Page refresh on updating org removed

* OrgUpdate tests done

* OrgUpdate 100% test coverage achieved

* OrgSettings Tests done

* Organization Dashboard Cards done

* Organization Dashboard achieved 100% CC

* 100% CC achieved for BlockUser screen

* Finalised changes

* Small change

* Tests fixed

* Separate OrgSettings component made

* Linting fixed

* Formatting fixed

* Events screen and Post Comment Modal for Talawa-user-portal  (#963)

* Create login and register page for user portal

* Lint public locales

* Create tests for login page components

* Add react import in tests

* Create organizations screen for user portal

* Fix failing tests and lint code

* fix failing tests

* Add tests for organization screen and componenets

* Fix non-null assertions

* Fix non-null assertions in organizations test

* Fix bootstrap migration changes

* Add Home Screen along with other components

* Fix failing tests

* Add required tests and Offcanvas navbar

* Remove unused variables from tests

* Sync the Mutations with talawa-api

* Add Settings and Donate Screen

* Add multilingual support for the screens

* Add events screen without calendar view

* Add multilingual support to Events screen

* Fix failing tests due to merge

* Add Post Comment functionality

* Refactor Events tests

* Deprecate event registrants from query

* Update README.md

* Add My Tasks screen and Fix UI bugs [User Portal] (#978)

* Create login and register page for user portal

* Lint public locales

* Create tests for login page components

* Add react import in tests

* Create organizations screen for user portal

* Fix failing tests and lint code

* fix failing tests

* Add tests for organization screen and componenets

* Fix non-null assertions

* Fix non-null assertions in organizations test

* Fix bootstrap migration changes

* Add Home Screen along with other components

* Fix failing tests

* Add required tests and Offcanvas navbar

* Remove unused variables from tests

* Sync the Mutations with talawa-api

* Add Settings and Donate Screen

* Add multilingual support for the screens

* Add events screen without calendar view

* Add multilingual support to Events screen

* Fix failing tests due to merge

* Add Post Comment functionality

* Refactor Events tests

* Deprecate event registrants from query

* Add my tasks screen for user portal

* Remove unnecessary comments from test files

* Add Feedback UI Components to Talawa Admin (#980)

* Add feedback component

* Add tests for feedback modal

* Add handling for empty feedback

* Add Average Rating and Reviews component

* Add testing for all the added cards

* Fix tests and move to 100% coverage

* Add bugfix

* Add merge function to fix failing tests

* Add key definitons

* Change merge policy

* Add custom merge policy to all the Event Stat tests

* remove cache

* Migrate to a single query in the parent

* Adding Plugin Logic to the Talawa Mobile Web App (#976)

* Add/ test for OrgPost.tsx

* fix:  org post back to default

* Added Dialog 2

* Updated Dialog UI

* Removed Extra code

* Updated Plugin store

* fix: warnings and solves #951  & #948

* fix: warnings and solves #951  & #948

* fix: warnings and solves #951  & #948

* Fix: UI Redesign

* fix: merge

* fix

* Update AddOnStore.tsx

* Fixed Merge Errors

* Add test: for OrgEntry

* Test 3

* fix test 4

* chores: version changes

* Add: Initial Websocket setup on talawa mobile web

* Add: plugin logic

* Add: plugin logic

* removed extra

* removed extra

* Added: Tests

* fix

* Add Side Navigation to Event Dashboard (#981)

* Create left drawer for event dashboard

* Add basic styles to the event dashboard

* Fix button styling

* Add testing

* Add testing for the left event drawer

* Add 100% line coverage for all components

* Increase timeout for tests

* Move maximum rating in feedback from 10 to 5 [Fixes #990] (#987)

* Move maximum rating in feedbacks from 10 to 5

* Fix failing tests

* Add chat screen to talawa-user-portal (#986)

* Create login and register page for user portal

* Lint public locales

* Create tests for login page components

* Add react import in tests

* Create organizations screen for user portal

* Fix failing tests and lint code

* fix failing tests

* Add tests for organization screen and componenets

* Fix non-null assertions

* Fix non-null assertions in organizations test

* Fix bootstrap migration changes

* Add Home Screen along with other components

* Fix failing tests

* Add required tests and Offcanvas navbar

* Remove unused variables from tests

* Sync the Mutations with talawa-api

* Add Settings and Donate Screen

* Add multilingual support for the screens

* Add events screen without calendar view

* Add multilingual support to Events screen

* Fix failing tests due to merge

* Add Post Comment functionality

* Refactor Events tests

* Deprecate event registrants from query

* Add my tasks screen for user portal

* Remove unnecessary comments from test files

* Add chat screen along with components

* Add mui/system package for x-chart support

* Add chat screen tests and fix other bugs

* Update issue.yml

* Update stale.yml

* Merge latest AdminUI Redesign into Master (#1006)

* Pagination Done for Orglist

* Fixed warnings

* Infinite scroll and search working for Requests screen

* Simplified the code

* Infinite scroll enabled and functioning on OrgList Requests and Users screen

* FIxed warning

* Fixed typo

* Fixed bug

* Joined and Blockedbyorgs screen and mdoal ready

* Tables ready !

* Remove user from organization functionality working well

* Update user role in organization feature ready

* Minor changes

* Done with tests on OrgList

* Done with testss of Requests screen

* 100% CC achieved for Users screen

* Main tests done for UserTableItem

* 100% Code Coverage Achieved for UserTableItem

* Removed Redundant Landing Page

* 100% CC achieved for TableLoader

* Translation added for Users Screen

* Translation done for Requests screen

* Translation done for dashboard screen

* Linting and warnings fixed

* Improved login page

* UI Done for Forgot Password Screen

* Forgot Password Screen Tests done!

* Fixed all pending tests

* Better message for btns and coloring

* Linting issues fixed

* Fixed code styles

* SUPPRESSED UNKNOWN ERROR

* Fixed formatting

* Updated typoed message

* Fixed failing tests accompanying typo

* fix createEvent to close modal and show events without refresh (#1014)

* fix: Ensure Full Visibility of Logo on 404 Error Page (#1018)

- Adjusted the positioning of the logo on the 404 error page to ensure full visibility.
- Implemented CSS modifications to prevent the logo from being covered or cut off.
- Tested the changes by navigating to various undefined endpoints, confirming that the logo is now displayed
  correctly on the 404 error page.

This commit addresses the bug by ensuring the proper display of the logo on the 404 error page,
enhancing the user experience.

Fixes #1016

Signed-off-by: Akhilender <[email protected]>

* Implemented featurs for Postfeed Management (#982)

* redesigned newsfeed

* added test

* newsfeed management

* pinned post

* postfeed management

* pin unpin tag and video control

* changes part 2

* newsfeed changes

* changes in Card Preview of newsfeed

* changes in Card Preview of newsfeed

* testing phase 1

* translation

* tests

* tests

* merged intto develop

* test

* Added query

* Update pull-requests.yml

* update and delete buttons of event modal are now working (#1051)

* update and delete buttons of event modal are now working

* fixed the naming conventions and style of the modal

* Dynamic dashboard Enhancements (#979)

* Dynamic Organization Dashboard

* Dynamic Organization Dashboard

* refined organization dashboard

* Update src/utils/handleLatestFeed.ts

Co-authored-by: Noble Mittal <[email protected]>

* fixed inconsistent casing

* fixed org dashboard test

* fixed org dashboard test

* revert previous commit

* final changes

* final changes

---------

Co-authored-by: Noble Mittal <[email protected]>

* Fix dashboard items (#1007)

* Dashboard items are working now.

* added variables for links -fix dashboard items

* Added variables for links -fix dashboard items.

* made the changes as said

* Removed : string from variable assignment.

* remove repititive code and resolved falling tests

* Fix repeating code and falling tests.

* Resolved some more falling tests

* write test for missed lines

* Fix event creation issue with white spaces. (#1025)

* fix event creation with white spaces

* Add test for empty input values

* chore: fix unit test (#1052)

* Fix layout distortion due to untruncated title description of events. (#1049)

* Fix layout distortion due to untruncated title description of events

* Add test

* add test for LeftDrawerEvent.tsx

* fixed some tests

* add test complete

* test: SecuredRouteForUser component 100% Test Coverage and fixed uncovered lines (#1048)

* SecuredRouteForUser test case added

* Fixed Linting Errors

* Update SecuredRouteForUser.test.tsx

* Update SecuredRouteForUser.test.tsx

* linting fix

* Update SecuredRouteForUser.test.tsx

* Update SecuredRouteForUser.test.tsx

* Fix incorrect toast Notification. (#1053)

* correct toast notification for TableRow.tsx with full test coverage

* Add correct toast with full code  coverage

* Add correct toast for deleteEventProjectModal.tsx with full test coverage

* Add correct toast for UpdateEventProjectModal.tsx with full test coverage

* Add correct toast for EventRegistrantsModal.tsx and full test  coverage.

* Add correct toast for AddTaskModal.tsx with full test coverage

* Add correct toast for UpdateTaskModal.tsx with full test coverage

* minor fix

* Add correct toast to EventRegistrantsModal.tsx

* fix EventRegitrantsModal.tsx

* created a return button on event dashboard (#1057)

* test: Loader Component 100% Test Coverage and Fix Uncovered Lines (#1047)

* test: Achieve 100% Test Coverage and Fix Uncovered Lines

- Improved the test coverage for the Loader component, addressing the previously uncovered lines and ensuring that all tests pass successfully.
- Added a test to ensure that the component renders correctly with a custom 'sm' size. I verified that both the spinner-wrapper and
  spinner elements are present and that the correct class is applied.
- Added a test to ensure that the component renders correctly with a 'lg' size. I verified that the spinner element has the appropriate class.
- Added a test to ensure that the component renders correctly with an 'xl' size. I verified that the spinner element has the correct class.

With these new tests, I now have 100% test coverage, and there are no more uncovered lines. The Loader component is thoroughly tested for
different size scenarios, and all tests pass successfully.

Signed-off-by: Akhilender <[email protected]>

* Fixed linting in Loader component

Signed-off-by: Akhilender <[email protected]>

* Test: Increasing the test level

- Trying to meet the code coverage level for Loader component.

Signed-off-by: Akhilender <[email protected]>

* Fixed Linting

Signed-off-by: Akhilender <[email protected]>

* fix: Linting

Signed-off-by: Akhilender <[email protected]>

* Improving test coverage for Loader Component

- Fixed lint errors

Signed-off-by: Akhilender <[email protected]>

* test: Improving the tests on the Loader Component

- Added a new aspect in the test-case1

Signed-off-by: Akhilender <[email protected]>

* Fixed: Removed runtime-generated classes from testing

- Eliminated all checks for classes associated with bootstrap components assigned at runtime.
- Recognized that validating classes assigned during runtime is inappropriate.

Signed-off-by: Akhilender <[email protected]>

---------

Signed-off-by: Akhilender <[email protected]>

* Simulated Test Database (#984)

* Dynamic Organization Dashboard

* Dynamic Organization Dashboard

* Sample Org Implementation

* removed unnecessary changes

* removed unnecessary svgs

* removed unnecessary import

* added appropriate button style

* fixed OrgListCard tests

* Fixed OrgList and OrgListCard Tests

* Removed Unnecessary 'container' Variable

* Added Missing Translations and removed unused variable

* Fixed event check in management not updating automatically bug (#1062)

* fixed the event checkIn bug

* fixed the failing test

* fixed the CheckInWrapper test

* Fix user profile buttons layout and added form validation (#1064)

* Fix user profile buttons layout and added form validation

* Fix falling tests and warnings

* Add test for missed lines

* fix falling tests

* test: Achieved 100% test coverage and fixed uncovered lines (#1068)

* test: Achieved 100% test coverage and fixed uncovered lines

- Improved the test coverage for the User-Password-Update component, addressing the previously uncovered lines and ensuring that all tests pass
  successfully.
- Added two new tests
  1. Empty Password Field Test:
   - The first test ensures that an error is displayed when attempting to save changes with an empty password field.

  2. Mismatched New and Confirm Passwords Test
   - The second test covers the scenario where the new and confirm password fields do not match.

With these new tests, I now have 100% test coverage, and there are no more uncovered lines.

Signed-off-by: Akhilender <[email protected]>

* Altered the formData

- Altered the formData to make sure all are related to the organization name.

Signed-off-by: Akhilender <[email protected]>

---------

Signed-off-by: Akhilender <[email protected]>

* created test for src/components/UserPortal/EventCard/EventCard.tsx (#1079)

* created test for eventCard of User portal

* corrected the start and end time

* Feature request: Adding advertisement screen (#994)

* Add/ test for OrgPost.tsx

* fix:  org post back to default

* Added Dialog 2

* Updated Dialog UI

* Removed Extra code

* Updated Plugin store

* fix: warnings and solves #951  & #948

* fix: warnings and solves #951  & #948

* fix: warnings and solve…
* Changes position and text of all organization button

* Made changes to the routesReducer.test file

* Made changes in IconComponent.test file

* Fetched changes from main repo

* Fixed unnecessary changes

---------

Co-authored-by: Aditya Agarwal <[email protected]>
* Added Base branch check to main

* Deleted all files in the main branch in anticipation of merging develop into main cleanly

* Merge develop to main

* Deleted all main files

* Merged develop into main
* Deleted all files in the main branch in anticipation of merging develop into main cleanly

* Merge develop into main
* Deleted all files in the main branch in anticipation of merging develop into main cleanly

* Merge develop into main

* Deleted all files in the main branch in anticipation of merging develop into main cleanly

* Merge develop into main
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.15 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.1.15...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40 to 41.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v40...v41)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/mde/ejs/releases)
- [Commits](mde/ejs@v3.1.9...v3.1.10)

---
updated-dependencies:
- dependency-name: ejs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Deleted all files in the main branch in anticipation of merging develop into main cleanly

* Merge develop into main

---------

Co-authored-by: Peter Harrison <[email protected]>
* 20240727112607 Deleted all files in the main branch in anticipation of merging develop into main cleanly

* 20240727112842 Merge develop into main
* 20240929102850 Deleted all files in the main branch in anticipation of merging develop into main cleanly

* 20240929103238 Merge develop into main
)

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40 to 41.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v40...v41)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 6 commits September 29, 2024 11:32
Bumps [rollup](https://github.com/rollup/rollup) from 4.21.3 to 4.22.5.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.21.3...v4.22.5)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* 20241114065242 Deleted all files in the main branch in anticipation of merging develop into main cleanly

* 20241114065332 Merge develop into main
Copy link
Contributor

coderabbitai bot commented Dec 24, 2024

Walkthrough

This pull request introduces a comprehensive update to the Talawa Admin project, focusing on modernizing the development infrastructure, enhancing configuration management, and improving localization support. The changes span multiple aspects of the project, including workflow configurations, build tools, testing environments, localization files, and project documentation. The update aims to streamline development processes, improve code quality, and provide better internationalization support.

Changes

File/Directory Change Summary
.coderabbit.yaml, .env.example, .eslintignore, .eslintrc.json Configuration updates for code review, environment variables, linting, and ESLint rules
.github/workflows/ Comprehensive updates to GitHub Actions workflows for CI/CD, code quality checks, and issue management
config/ New configuration files for Babel, Vite, and Jest
public/locales/ Added localization files for English, French, Hindi, Spanish, and Chinese
scripts/ New utility scripts for testing, Git hooks, and development setup
Documentation files Updated guidelines, installation instructions, and contribution guidelines

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Repo as Repository
    participant CI as GitHub Actions
    participant Test as Test Environment
    participant Build as Build Process

    Dev->>Repo: Commits code changes
    Repo->>CI: Triggers workflows
    CI->>Test: Runs tests and checks
    Test->>CI: Returns test results
    CI->>Build: Initiates build process
    Build->>Repo: Updates project artifacts
Loading

Assessment against linked issues

Objective Addressed Explanation
Refactor CSS files in Leaderboard [#2508] Partial implementation - global CSS file structure added, but specific Leaderboard refactoring not visible

Possibly related issues

Suggested reviewers

Poem

🐰 Hop into code, a rabbit's delight,
Workflows dancing, configurations bright
Locales unfurling, like petals so fair
Talawa Admin's magic, beyond compare! 🌈

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 25

🔭 Outside diff range comments (1)
.eslintrc.json (1)

Based on the analysis of the codebase, I can now provide the final response:

Strict TypeScript rules will require significant codebase updates

The verification reveals several areas that need attention to comply with the new TypeScript rules:

  • Multiple files contain any type usage (16 source files excluding node_modules)
  • Extensive use of type assertions (as Type) across many components (70+ files)
  • Files that need interface naming convention updates to include Interface or TestInterface prefix

Key files requiring immediate attention:

  • src/state/action-creators/index.ts
  • src/state/helpers/Action.ts
  • src/components/AddOn/**/*.ts(x) (multiple files in this directory)
  • src/utils/useLocalstorage.ts
  • src/screens/UserPortal/Chat/Chat.tsx
🔗 Analysis chain

Line range hint 41-142: Verify the impact of strict TypeScript rules

The new TypeScript rules significantly enhance type safety but might require substantial changes to the existing codebase.

Let's check the potential impact:


Let me try a different approach to verify the TypeScript rules impact.


Let me check for non-null assertions and type assertions to complete the verification.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for potential violations of the new TypeScript rules
echo "Checking for any usage of 'any' type..."
rg ":\s*any\b" --type ts --type tsx

echo "Checking for non-null assertions..."
rg "!(\s|$)" --type ts --type tsx

echo "Checking for type assertions..."
rg "as\s+\w+" --type ts --type tsx

echo "Checking interface naming conventions..."
ast-grep --pattern 'interface $name {$$$}'

Length of output: 579


Script:

#!/bin/bash
# First, let's find TypeScript files
echo "Finding TypeScript files..."
fd -e ts -e tsx

# Then check specific patterns in those files
echo -e "\nChecking for 'any' type usage..."
find . -type f \( -name "*.ts" -o -name "*.tsx" \) -exec grep -l ":\s*any\b" {} \;

echo -e "\nChecking for non-null assertions..."
find . -type f \( -name "*.ts" -o -name "*.tsx" \) -exec grep -l "[^!]!" {} \;

echo -e "\nChecking for type assertions..."
find . -type f \( -name "*.ts" -o -name "*.tsx" \) -exec grep -l "as\s\+" {} \;

echo -e "\nChecking interface declarations..."
find . -type f \( -name "*.ts" -o -name "*.tsx" \) -exec grep -l "^interface\s\+" {} \;

Length of output: 41337


Script:

#!/bin/bash
# Search for non-null assertions and type assertions in source files
echo "Checking for non-null assertions (!.)..."
rg -l "!\." src/

echo -e "\nChecking for type assertions (as Type)..."
rg -l "as\s+[A-Z][A-Za-z]*" src/

echo -e "\nChecking interface naming conventions..."
rg -l "^interface\s+(?!Interface|TestInterface)[A-Z]" src/

Length of output: 5211

🧹 Nitpick comments (71)
.github/workflows/compare_translations.py (3)

59-60: Remove or utilize the named tuple.
The FileTranslation named tuple is defined but never used in this file. Consider removing it if it is no longer needed, or integrate it into the workflow to store and report file-level translation issues.


117-136: Adopt exception chaining for clarity.
Per static analysis, it's recommended to use explicit exception chaining, e.g., raise ValueError(...) from e. This preserves the original traceback and offers more context for debugging.

-except json.JSONDecodeError as e:
-    raise ValueError(f"Error decoding JSON from file {filepath}: {e}")
+except json.JSONDecodeError as e:
+    raise ValueError(f"Error decoding JSON from file {filepath}: {e}") from e
🧰 Tools
🪛 Ruff (0.8.2)

135-135: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling

(B904)


185-212: Ensure coverage with tests or a CI step.
This script is critical for maintaining translation consistency yet relies solely on manual invocation. Adding even a basic CI/automated test step would prevent accidental regressions.

config/vite.config.ts (1)

24-29: Potential discrepancy in server port documentation.
Line 27 says “this sets a default port to 3000,” but the actual port is 4321. Confusion might arise for new developers following these comments. Update or remove the mismatched comment.

-    // this sets a default port to 3000
+    // this sets a default port to 4321
scripts/githooks/update-toc.js (3)

4-7: Consider processing subdirectories if needed.
Currently, .readdirSync('./') will only process .md files in the top-level directory. If you have Markdown files in subdirectories, you might want to recursively gather them or handle them separately.


10-10: Add error handling for execSync.
execSync(command, { stdio: 'inherit' }) suppresses exceptions from Python or missing markdown-toc installations. Consider wrapping this in a try-catch block to announce or handle errors more gracefully.


11-12: Match Prettier formatting guidelines.
ESLint recommends removing extraneous whitespace on lines 11 and 12. Consider adjusting the empty line to adhere to your project's style guide.

10	 execSync(command, { stdio: 'inherit' });
-11	 
-12	 
+11
🧰 Tools
🪛 eslint

[error] 11-12: Delete ··⏎

(prettier/prettier)

scripts/githooks/check-localstorage-usage.js (2)

87-93: Prettier warnings about missing trailing commas.
Your static analysis suggests inserting commas after the last string arguments in your console.info calls:

-    '\nInfo: Consider using custom hook functions.'
+    '\nInfo: Consider using custom hook functions.',

and

-    'Please use the getItem, setItem, and removeItem functions provided by the custom hook useLocalStorage.\n'
+    'Please use the getItem, setItem, and removeItem functions provided by the custom hook useLocalStorage.\n',

While this is optional based on your coding style preferences, aligning with Prettier or your project’s style guide helps maintain consistency.

🧰 Tools
🪛 eslint

[error] 89-89: Insert ,

(prettier/prettier)


[error] 92-92: Insert ,

(prettier/prettier)


82-96: Exit code vs. partial failure consideration.
The script exits with a non-zero code on encountering any localStorage usage. If some usage might be valid or flagged only as a warning, consider offering a way to continue the commit while logging a warning. Otherwise, the current approach is fine for strictly preventing localStorage usage.

🧰 Tools
🪛 eslint

[error] 89-89: Insert ,

(prettier/prettier)


[error] 92-92: Insert ,

(prettier/prettier)

.github/workflows/stale.yml (2)

18-21: Fix trailing spaces while maintaining required permissions

The permissions configuration is correct for the stale action's functionality.

permissions:
  issues: write
- pull-requests: write  
-   
+ pull-requests: write
🧰 Tools
🪛 yamllint (1.35.1)

[error] 20-20: trailing spaces

(trailing-spaces)


[error] 21-21: trailing spaces

(trailing-spaces)


31-34: Consider documenting the rationale for stale/close timeframes

The messages are clear and helpful, but it would be beneficial to document why 10 days for stale and 180 days for closing were chosen.

Add a comment block explaining the reasoning:

+      # Stale after 10 days to maintain active discussions
+      # Close after 180 days to allow for long-term community engagement
       stale-issue-message: 'This issue did not get any activity...'
public/locales/hi/common.json (2)

41-42: Improve translation naturalness

The password-related translations could be more idiomatic:

  • "पास वर्ड" has an unnecessary space
  • "पासवर्ड" is more commonly used
-  "enterPassword": "पास वर्ड दर्ज करें",
+  "enterPassword": "पासवर्ड दर्ज करें",

1-98: Consider enhancing the localization infrastructure

To improve the maintainability and reliability of translations:

  1. Implement a validation system to ensure consistent placeholder usage across locale files
  2. Add TypeScript types for translation keys to catch missing translations at compile time
  3. Consider using a translation management system (TMS) for better collaboration with translators

Example type definition for translation keys:

// src/types/i18n.d.ts
export interface Translations {
  firstName: string;
  lastName: string;
  // ... other keys
  searchResultsFor: string; // expects {{text}} placeholder
  addedSuccessfully: string; // expects {{item}} placeholder
}
public/locales/fr/translation.json (3)

18-23: Consider standardizing validation message translations

The validation messages could be more naturally phrased in French:

-  "atleast_8_char_long": "Au moins 8 caractères",
-  "atleast_6_char_long": "Au moins 6 caractères",
-  "firstName_invalid": "Le prénom ne doit contenir que des lettres minuscules et majuscules",
-  "lastName_invalid": "Le nom de famille ne doit contenir que des lettres minuscules et majuscules",
-  "password_invalid": "Le mot de passe doit contenir au moins une lettre minuscule, une lettre majuscule, une valeur numérique et un caractère spécial",
-  "email_invalid": "L'e-mail doit contenir au moins 8 caractères",
+  "atleast_8_char_long": "Doit contenir au moins 8 caractères",
+  "atleast_6_char_long": "Doit contenir au moins 6 caractères",
+  "firstName_invalid": "Le prénom doit être composé uniquement de lettres",
+  "lastName_invalid": "Le nom de famille doit être composé uniquement de lettres",
+  "password_invalid": "Le mot de passe doit contenir au moins une minuscule, une majuscule, un chiffre et un caractère spécial",
+  "email_invalid": "L'adresse e-mail doit contenir au moins 8 caractères"

89-92: Improve capitalization consistency in event-related translations

Maintain consistent capitalization in French:

-    "eventCardTitle": "évènements à venir",
-    "eventCardSeeAll": "Voir tout",
-    "noEvents": "Aucun événement à venir"
+    "eventCardTitle": "Événements à venir",
+    "eventCardSeeAll": "Voir tout",
+    "noEvents": "Aucun événement à venir"

1379-1386: Standardize error message translations

The error messages could be more consistently phrased:

-    "errorCheckingIn": "Erreur lors de l'enregistrement",
-    "checkedInSuccessfully": "Enregistrement réussi"
-    "errorAddingAttendee": "Erreur lors de l'ajout du participant",
-    "errorRemovingAttendee": "Erreur lors de la suppression du participant"
+    "errorCheckingIn": "Une erreur s'est produite lors de l'enregistrement",
+    "checkedInSuccessfully": "Enregistrement effectué avec succès"
+    "errorAddingAttendee": "Une erreur s'est produite lors de l'ajout du participant",
+    "errorRemovingAttendee": "Une erreur s'est produite lors de la suppression du participant"
public/locales/en/errors.json (2)

2-2: Improve clarity and consistency in API unavailability message

The message has inconsistent punctuation (note the "!.") and could be more concise.

-  "talawaApiUnavailable": "Talawa-API service is unavailable!. Is it running? Check your network connectivity too.",
+  "talawaApiUnavailable": "Talawa API service is unavailable. Please check if the service is running and verify your network connectivity.",

5-5: Fix capitalization and grammar in authorization message

The message has inconsistent capitalization and an unnecessary exclamation mark.

-  "notAuthorised": "Sorry! you are not Authorised!",
+  "notAuthorised": "Sorry, you are not authorized.",
.github/ISSUE_TEMPLATE/bug-report.md (1)

33-36: Improve markdown formatting in internship section

The section needs proper markdown formatting:

  1. Use proper heading syntax instead of bold text
  2. Format URL as a proper markdown link
-**Potential internship candidates**
+## Potential internship candidates
 
 Please read this if you are planning to apply for a Palisadoes Foundation internship 
-https://github.com/PalisadoesFoundation/talawa/issues/359
+[Internship Information](https://github.com/PalisadoesFoundation/talawa/issues/359)
🧰 Tools
🪛 Markdownlint (0.37.0)

36-36: null
Bare URL used

(MD034, no-bare-urls)


33-33: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

.github/ISSUE_TEMPLATE/feature-request.md (1)

25-28: Improve markdown formatting in internship section

Apply the same formatting improvements as in the bug report template:

-**Potential internship candidates**
+## Potential internship candidates
 
 Please read this if you are planning to apply for a Palisadoes Foundation internship 
-https://github.com/PalisadoesFoundation/talawa/issues/359
+[Internship Information](https://github.com/PalisadoesFoundation/talawa/issues/359)
🧰 Tools
🪛 Markdownlint (0.37.0)

28-28: null
Bare URL used

(MD034, no-bare-urls)


25-25: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

ISSUE_GUIDELINES.md (2)

44-44: Capitalize "Slack" consistently

"Slack" is a proper noun and should be capitalized consistently throughout the document.

-Ask our contributors to assign it to you in `#talawa` slack channel.
+Ask our contributors to assign it to you in `#talawa` Slack channel.

-Join our `#talawa-github` slack channel for automatic issue and pull request updates.
+Join our `#talawa-github` Slack channel for automatic issue and pull request updates.

-Discuss issues in our various slack channels when necessary
+Discuss issues in our various Slack channels when necessary

Also applies to: 53-53, 57-57

🧰 Tools
🪛 LanguageTool

[grammar] ~44-~44: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...butors to assign it to you in #talawa slack channel. Working on these types of exi...

(ON_SKYPE)


57-59: Add missing punctuation in guidelines list

The list items should end consistently with periods and include necessary commas.

-1. Discuss issues in our various slack channels when necessary
+1. Discuss issues in our various Slack channels when necessary.
 2. Please do not derail or troll issues. 
 3. Keep the discussion on topic and respect the opinions of others.
🧰 Tools
🪛 LanguageTool

[grammar] ~57-~57: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...lines 1. Discuss issues in our various slack channels when necessary 2. Please do no...

(ON_SKYPE)


[typographical] ~57-~57: Consider adding a comma here.
Context: ...ur various slack channels when necessary 2. Please do not derail or troll issues. 3. Keep...

(PLEASE_COMMA)

.github/workflows/eslint_disable_check.py (1)

61-61: Rename the unused loop control variable dirs.

Static analysis flags that dirs is unused in the loop. Prefixing it with an underscore (_dirs) or simply using _ will clarify that it’s intentionally unused, preventing confusion and aligning with best practices.

-for root, dirs, files in os.walk(os.path.join(directory, 'src')):
+for root, _dirs, files in os.walk(os.path.join(directory, 'src')):
🧰 Tools
🪛 Ruff (0.8.2)

61-61: Loop control variable dirs not used within loop body

Rename unused dirs to _dirs

(B007)

jest-preview.config.ts (1)

2-4: Add clarifying comments for the moduleNameMapper usage.

Consider documenting why @mui/ is remapped to this particular path to assist contributors who may not be familiar with Material-UI's resolution patterns.

 export default {
   moduleNameMapper: {
+    // Ensures Material-UI imports are resolved correctly for Jest
     '^@mui/(.*)$': '<rootDir>/node_modules/@mui/$1',
   },
 };
.husky/post-merge (1)

4-4: Potentially refine post-merge install logic.

Triggering a full npm install may be overkill if the changes are minor (e.g., version bumps in devDependencies). Consider using a more targeted approach such as npm ci in CI or verifying only dependency changes.

.husky/pre-commit (1)

5-5: Uncomment npm run lint:fix if auto-fixing is desired.

Retaining the lint-fix step commented out might lead to lint warnings in subsequent commits. If auto-fixing is acceptable, consider enabling it for a smoother development experience.

.github/workflows/auto-label.json5 (1)

1-8: Looks consistent and straightforward.

The JSON configuration for synonyms and default labels is valid. It should integrate smoothly with any workflows that reference these label mappings. Consider expanding synonyms for other frequent labels (e.g., "bug") to further enhance issue categorization.

scripts/custom-test-env.js (2)

5-5: TSDoc tag "@pdfme" is not recognized.

The error from static analysis indicates that your TSDoc config doesn't define "@pdfme". Consider either removing this tag or adding a custom definition for it to eliminate the lint error.

🧰 Tools
🪛 eslint

[error] 5-5: tsdoc-undefined-tag: The TSDoc tag "@pdfme" is not defined in this configuration

(tsdoc/syntax)


9-9: Add an explicit return type to enhance clarity.

The static analysis suggests adding a return type to your setup method for better type consistency in TypeScript. If this is a JavaScript file without type checking, feel free to skip, but if you use TypeScript or JSDoc-based tooling, clarifying the return type can help maintainers.

🧰 Tools
🪛 eslint

[error] 9-9: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)


[error] 9-9: Missing return type on function.

(@typescript-eslint/explicit-module-boundary-types)

scripts/__mocks__/@pdfme/generator.ts (1)

11-11: Remove or replace commented debug statement.

Leaving commented-out console logs in the code may confuse teammates and clutter the implementation. Consider removing the commented console.log or converting it to a proper debug statement if necessary.

.github/workflows/check-tsdoc.js (3)

13-35: **Consider concurrency improvements **

The findTsxFiles function runs directory reads and subsequent file stat calls sequentially. If performance becomes an issue in large codebases, consider running these operations in parallel (e.g., using Promise.all), being mindful of potential overhead from too many simultaneous I/O operations.


38-45: **Extend TSDoc check to multi-line coverage **

You search for /**...*/ TSDoc comments but do not verify if they contain valid tags or descriptions. Consider using a more sophisticated TSDoc parser or adding checks for mandatory tags (e.g., @param, @returns) if your project requires them.


60-65: **Provide actionable feedback for missing TSDoc **

When a file lacks TSDoc comments, the script only prints an error message. You could also produce a more descriptive summary or offer guidance (e.g., referencing project documentation or examples) to accelerate correction. This will help contributors understand how TSDoc should be structured in your project.

jest.config.js (2)

48-51: **Consider enabling watch plugins **

You've commented out watch plugins. If some contributors rely on Jest's watch-typeahead features, you could leave them enabled by default or document clearly how to enable them locally.


60-65: **Set realistic coverage thresholds **

A global coverage threshold of 20% may be too low to drive meaningful improvement. If you aim to raise test coverage progressively, consider using a slightly higher threshold or a plan to increment it over time.

.github/workflows/talawa_admin_md_mdx_format_adjuster.py (1)

19-44: **Add narrower regex checks for MDX **

Your regex patterns correctly detect <, >, {, and } unless they’re already escaped. In more advanced MDX usage, other scenarios (like backticks or template literals) could also cause issues. Consider expanding or modifying these patterns if you encounter more edge cases.

setup.ts (3)

1-9: **Centralize repeated imports **

Multiple utility functions (checkConnection, askForTalawaApiUrl, etc.) are imported from src/setup/. If these are part of a common module, consider centralizing them with clearer naming, making imports simpler and more maintainable.


25-39: **Consider direct environment variable updates **

You store shouldSetCustomPort in a local variable and then set a port conditionally. You could handle the logic more succinctly by iterating user prompts inline. However, your current approach is perfectly valid and has the advantage of clarity.


163-169: **Provide an option to track logs in external file **

Your script only toggles ALLOW_LOGS to YES. Some projects prefer storing logs in external files to avoid console clutter. If interested, I can help extend this script to support a custom log path, performing log rotation, or conditional logging levels. Would you like me to open a new GitHub issue with these suggestions?

.github/workflows/countline.py (5)

35-56: Validate comment logic when checking for test filenames
The _valid_filename() function checks substrings like ".test." or ".spec." to determine invalid filenames. This may not catch variations (e.g., myTestFile.dart). If you need a stricter naming policy, consider using a regex or a more precise approach.


58-79: Expand or refine extension checks
Currently, _valid_extension() only checks a hardcoded list of unsupported file extensions (.css, .jpg, etc.). If you need to enforce a broad set of supported file types, consider inverting the logic by defining explicitly supported extensions and rejecting everything else.


197-209: Clarify the "Analyze dart files" docstring
The docstring in the main() function mentions "Analyze dart files," which might be confusing since this script appears language-agnostic. Consider updating it to reflect actual behavior.


267-267: Fix spelling error
The comment says "# If the line rule is voilated...". It should be "violated."

-    # If the line rule is voilated then the value is changed to 1
+    # If the line rule is violated then the value is changed to 1

220-224: Consider using Python's pathlib for cleaner code
The usage of os.path and string manipulation for building paths is correct but can be more readable and robust using the pathlib library. This would simplify path joining and checks, especially in loops.

Also applies to: 237-264

.github/workflows/codeql-codescan.yml (1)

6-20: Fix YAML formatting issues

There are some minor formatting inconsistencies in the YAML file:

  • Remove trailing spaces on lines 6, 17, and 20
  • Fix indentation to be consistent (use 6 spaces for steps and 11 spaces for action parameters)
🧰 Tools
🪛 yamllint (1.35.1)

[error] 6-6: trailing spaces

(trailing-spaces)


[error] 17-17: trailing spaces

(trailing-spaces)


[error] 20-20: trailing spaces

(trailing-spaces)

.github/pull_request_template.md (1)

22-24: Improve issue reference formatting

Consider using a more structured format for the issue reference section:

-**Issue Number:**
-
-Fixes #<!--Add related issue number here.-->
+**Issue Number:** #<!--Add related issue number here.-->
+
+Resolves: #<!--Add any additional related issues-->
DOCUMENTATION.md (3)

25-25: Fix grammar in server launch description

There's a grammatical error in the server launch description.

-    - A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/
+    - A local version of `docs.talawa.io` should automatically launch in your browser at `http://localhost:3000`
🧰 Tools
🪛 Markdownlint (0.37.0)

25-25: null
Bare URL used

(MD034, no-bare-urls)

🪛 LanguageTool

[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...f docs.talawa.io should automatically launched in your browser at http://localhost:300...

(MD_BASEFORM)


26-29: Improve technical writing consistency

Several improvements can be made to maintain consistency in technical documentation:

  1. Capitalize "Markdown" as it's a proper noun
  2. Fix typos ("brower" → "browser")
  3. Use consistent formatting for file/directory references
-1. Add/modify the markdown documents to the `docs/` directory of the `talawa-docs` repository
+1. Add/modify the Markdown documents to the `docs/` directory of the `talawa-docs` repository
-1. Always monitor the local website in your brower to make sure the changes are acceptable. 
+1. Always monitor the local website in your browser to make sure the changes are acceptable. 
🧰 Tools
🪛 LanguageTool

[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to the docs/ directory of t...

(MARKDOWN_NNP)


32-32: Improve repository reference clarity

The final instruction could be more specific about which repository it's referring to.

-***PLEASE*** do not add markdown files in this repository. Add them to `talawa-docs`!
+***PLEASE*** do not add Markdown files in the main repository. Add them to the `talawa-docs` repository instead!
🧰 Tools
🪛 LanguageTool

[uncategorized] ~32-~32: The preposition “to” seems more likely in this position.
Context: ... PLEASE do not add markdown files in this repository. Add them to `talawa-do...

(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)

.github/workflows/push.yml (2)

14-20: Consider restricting push triggers

The workflow currently runs on all branches ('**'). Consider restricting it to specific branches (e.g., develop, master) to optimize CI resources.

on:
  push:
    branches:
-      - '**'   
+      - 'develop'
+      - 'master'
🧰 Tools
🪛 yamllint (1.35.1)

[error] 17-17: trailing spaces

(trailing-spaces)


[error] 18-18: trailing spaces

(trailing-spaces)


[warning] 20-20: wrong indentation: expected 2 but found 4

(indentation)


54-61: Enhance code coverage configuration

The coverage reporting configuration could be improved:

  1. Consider adding coverage thresholds
  2. The fail_ci_if_error: false might hide important coverage upload issues
- run: npm run test -- --watchAll=false --coverage
+ run: npm run test -- --watchAll=false --coverage --coverageThreshold='{"global":{"branches":80,"functions":80,"lines":80,"statements":80}}'

Also, consider setting fail_ci_if_error: true to ensure coverage uploads are working correctly.

.github/workflows/README.md (3)

24-24: Fix typo in documentation

There's a duplicate word "to" in the sentence.

-      1. Place all actions related to to this in the `pull-request-target.yml` file.
+      1. Place all actions related to this in the `pull-request-target.yml` file.
🧰 Tools
🪛 LanguageTool

[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...ors: 1. Place all actions related to to this in the pull-request-target.yml f...

(ENGLISH_WORD_REPEAT_RULE)


35-35: Fix abbreviation format

The abbreviation "eg." should be "e.g." (with periods).

-1. Jobs only work correctly if they have a dedicated file (eg. `CodeQL`)
+1. Jobs only work correctly if they have a dedicated file (e.g., `CodeQL`)
🧰 Tools
🪛 LanguageTool

[uncategorized] ~35-~35: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...orrectly if they have a dedicated file (eg. CodeQL) ## Scripts Follow these gui...

(E_G)


41-47: Consider adding version requirements for linting tools

The documentation should specify minimum versions for the linting tools to ensure consistent results across different environments.

1. The python3 scripts must follow the following coding standards. Run these commands against your scripts before submitting PRs that modify or create python3 scripts in this directory.
-    1. Pycodestyle
-    1. Pydocstyle
-    1. Pylint
-    1. Flake8
+    1. Pycodestyle (>=2.10.0)
+    1. Pydocstyle (>=6.3.0)
+    1. Pylint (>=2.17.0)
+    1. Flake8 (>=6.0.0)
.github/workflows/issue.yml (2)

42-48: Simplify label condition check

The current label checking logic using reduce could be simplified using some().

-            if(labels.data.reduce((a, c)=>a||["dependencies"].includes(c.name), false))
+            if(labels.data.some(label => ["dependencies"].includes(label.name)))

49-55: Consider combining label conditions

The label conditions could be combined to reduce code duplication.

-            else if(labels.data.reduce((a, c)=>a||["security", "ui/ux"].includes(c.name), false))
-              await github.rest.issues.addLabels({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                issue_number: context.issue.number,
-                labels: ["good first issue"]
-              });
+            const labelSets = {
+              'dependencies': ["good first issue", "security"],
+              'security': ["good first issue"],
+              'ui/ux': ["good first issue"]
+            };
+            
+            for (const [trigger, toAdd] of Object.entries(labelSets)) {
+              if (labels.data.some(label => label.name === trigger)) {
+                await github.rest.issues.addLabels({
+                  ...apiParams,
+                  labels: toAdd
+                });
+                break;
+              }
+            }
README.md (1)

53-53: Fix heading formatting

Remove extra spaces after the hash symbol in the "Videos" heading.

-#  Videos
+# Videos
🧰 Tools
🪛 Markdownlint (0.37.0)

53-53: null
Multiple spaces after hash on atx style heading

(MD019, no-multiple-space-atx)

.github/workflows/pull-request-target.yml (2)

1-77: Clean up trailing spaces in the YAML file

The file contains multiple trailing spaces that should be removed for consistency.

Affected lines: 6, 13, 15, 27-29, 31, 33-34, 36, 41, 46, 71

You can use the following command to remove trailing spaces:

#!/bin/bash
# Remove trailing spaces from the YAML file
sed -i 's/[[:space:]]*$//' .github/workflows/pull-request-target.yml
🧰 Tools
🪛 yamllint (1.35.1)

[error] 6-6: trailing spaces

(trailing-spaces)


[error] 13-13: trailing spaces

(trailing-spaces)


[error] 15-15: trailing spaces

(trailing-spaces)


[error] 27-27: trailing spaces

(trailing-spaces)


[error] 28-28: trailing spaces

(trailing-spaces)


[error] 29-29: trailing spaces

(trailing-spaces)


[error] 31-31: trailing spaces

(trailing-spaces)


[error] 33-33: trailing spaces

(trailing-spaces)


[error] 34-34: trailing spaces

(trailing-spaces)


[error] 36-36: trailing spaces

(trailing-spaces)


[error] 41-41: trailing spaces

(trailing-spaces)


[error] 46-46: trailing spaces

(trailing-spaces)


[error] 71-71: trailing spaces

(trailing-spaces)


71-72: Fix incomplete sentence

The sentence appears to be cut off.

-2. Read the CONTRIBUTING.md file make 
+2. Read the CONTRIBUTING.md file for more information.
🧰 Tools
🪛 yamllint (1.35.1)

[error] 71-71: trailing spaces

(trailing-spaces)

PR_GUIDELINES.md (2)

3-3: Improve emoji spacing for better readability.

Add spaces around the emojis for better visual separation.

-:+1::tada: First off, thanks for taking the time to contribute! :tada::+1:
+:+1: :tada: First off, thanks for taking the time to contribute! :tada: :+1:

4-5: Simplify the wording for clarity.

The sentence is wordy and can be more concise.

-In order to give everyone a chance to submit a pull request and contribute to the Talawa project, we have put restrictions in place.
+To ensure fair contribution opportunities in the Talawa project, we have established the following restrictions.
🧰 Tools
🪛 LanguageTool

[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a pull...

(IN_ORDER_TO_PREMIUM)

package.json (1)

160-162: Consider lowering the Node.js version requirement.

The requirement of Node.js >=20.x might be unnecessarily restrictive. Consider if Node.js 18 LTS would be sufficient, as it's still actively maintained and more widely adopted.

CODE_STYLE.md (2)

58-62: Add language specifiers to code blocks.

Code blocks should specify the language for proper syntax highlighting.

-```
+```jsx
 <div className="myCustomClass">...</div>

Also applies to: 64-69

🧰 Tools
🪛 Markdownlint (0.37.0)

58-58: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


49-52: Clarify file naming conventions.

The distinction between PascalCase and camelCase usage could be more specific.

-All React components *must* be written in PascalCase, with their file names, and associated CSS modules being written in PascalCase
-All other files may follow the camelCase naming convention
+All React components *must* be written in PascalCase (e.g., MyComponent.tsx)
+All component-specific CSS modules must use PascalCase (e.g., MyComponent.module.css)
+All utility files, hooks, and non-component files should use camelCase (e.g., useCustomHook.ts, helperFunction.ts)
.github/workflows/pull-request.yml (1)

85-136: Add documentation for sensitive files protection.

Consider adding comments explaining why each file is considered sensitive and the impact of unauthorized changes.

🧰 Tools
🪛 yamllint (1.35.1)

[error] 92-92: trailing spaces

(trailing-spaces)


[error] 126-126: trailing spaces

(trailing-spaces)


[error] 129-129: trailing spaces

(trailing-spaces)

CONTRIBUTING.md (3)

33-34: Fix indentation in table of contents.

The indentation for pre-commit and post-merge hook entries should be 4 spaces, not 6.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~34-~34: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors. ## Ways to Contribute I...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


142-145: Add language specifiers to code blocks.

Add appropriate language specifiers to fenced code blocks for better syntax highlighting.

Example:

-```
+```bash

Also applies to: 164-166, 188-190, 194-196, 200-202, 208-210, 214-216, 220-222, 240-242, 256-258, 264-266, 270-272, 292-294, 300-303, 313-315

🧰 Tools
🪛 Markdownlint (0.37.0)

143-143: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


Line range hint 327-327: Use consistent code block style.

Convert indented code blocks to fenced code blocks for consistency.

-        git commit -m "commit message" --no-verify
+```bash
+git commit -m "commit message" --no-verify
+```

Also applies to: 335-335

🧰 Tools
🪛 LanguageTool

[uncategorized] ~5-~5: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...ibuting to open source, please read the Open Source Guides on [How to Contribute to Open So...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


[style] ~27-~27: This expression usually appears with a “please” in front of it.
Context: ...DUCT.md) to understand what this means. Let us know immediately if you have unacceptable ex...

(INSERT_PLEASE)


[uncategorized] ~34-~34: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors. ## Ways to Contribute I...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


[grammar] ~62-~62: A determiner may be missing.
Context: ...l Request guidelines](PR_GUIDELINES.md) is best resource to follow to start working on ...

(THE_SUPERLATIVE)


[uncategorized] ~68-~68: Loose punctuation mark.
Context: ...ushed to the main branch: - develop: For unstable code and bug fixing - `mai...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~69-~69: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...d bug fixing - main: Where the stable production ready code lies. This is our default branch. ...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


[typographical] ~73-~73: Consider adding a comma.
Context: ...ultiple developers are working on issues there is bound to be a conflict of interest (...

(IF_THERE_COMMA)


[typographical] ~73-~73: Consider adding a comma after ‘Usually’ for more clarity.
Context: ...licts) among issues, PRs or even ideas. Usually these conflicts are resolved in a **Fir...

(RB_LY_COMMA)


[grammar] ~73-~73: Did you mean “served” (as in the idiom ‘first come, first served’)?
Context: ...ts are resolved in a First Come First Serve basis however there are certain excep...

(FIRST_SERVED)


[uncategorized] ~75-~75: Possible missing comma found.
Context: ... an extension or in conflict with other PRs it is important to ask the author of th...

(AI_HYDRA_LEO_MISSING_COMMA)


[grammar] ~75-~75: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...tant to ask the author of the PR in the slack channel or in their PRs or issues thems...

(ON_SKYPE)


[style] ~77-~77: ‘Last but not the least’ might be wordy. Consider a shorter alternative.
Context: ...y and test that function when needed. - Last but not the least, communication is important make sure t...

(EN_WORDINESS_PREMIUM_LAST_BUT_NOT_THE_LEAST)


[grammar] ~77-~77: It seems that “to” is missing before the verb.
Context: ...t the least, communication is important make sure to talk to other contributors, in ...

(MISSING_TO_BETWEEN_BE_AND_VB)


[grammar] ~77-~77: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ... other contributors, in these cases, in slack channel or in a issue/PR thread. - As a...

(ON_SKYPE)


[misspelling] ~77-~77: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... in these cases, in slack channel or in a issue/PR thread. - As a last resort the...

(EN_A_VS_AN)


[typographical] ~78-~78: It appears that a comma is missing.
Context: ...el or in a issue/PR thread. - As a last resort the Admins would be responsible for dec...

(DURING_THAT_TIME_COMMA)

INSTALLATION.md (2)

105-105: Fix grammatical and formatting issues.

  1. Line 105: Use proper URL formatting
  2. Line 246: Fix sentence structure
  3. Line 278: Add missing articles and commas
-   1. first install `node.js` from their website at https://nodejs.org
+   1. first install `node.js` from their website at [nodejs.org](https://nodejs.org)

-Set the `ALLOW_LOGS` to "YES" if you want warnings , info and error messages in your console or leave it blank if you dont need them or want to keep the console clean
+Set the `ALLOW_LOGS` to "YES" if you want warnings, info, and error messages in your console, or leave it blank if you don't need them or want to keep the console clean.

-The first time you navigate to the running talawa-admin's website you'll land at talawa-admin registration page.
+The first time you navigate to the running talawa-admin's website, you'll land at the talawa-admin registration page.

Also applies to: 246-246, 278-278

🧰 Tools
🪛 Markdownlint (0.37.0)

105-105: null
Bare URL used

(MD034, no-bare-urls)


321-335: Fix heading hierarchy.

The Git hooks sections should use h3 headings (###) instead of h4 (####) for proper hierarchy.

-#### pre-commit hook
+### pre-commit hook

-#### post-merge hook
+### post-merge hook
🧰 Tools
🪛 Markdownlint (0.37.0)

321-321: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

(MD001, heading-increment)


327-327: Expected: fenced; Actual: indented
Code block style

(MD046, code-block-style)


335-335: Expected: fenced; Actual: indented
Code block style

(MD046, code-block-style)

schema.graphql (1)

1114-1117: Enhance subscription definitions.

The subscription definitions could be improved:

  • messageSentToChat should clarify if userId is for sender or receiver
  • Consider adding subscriptions for other real-time events

Consider adding these subscriptions:

 type Subscription {
   messageSentToChat(userId: ID!): ChatMessage
   onPluginUpdate: Plugin
+  # Add subscriptions for other real-time events
+  onEventUpdate(eventId: ID!): Event
+  onNewPost(organizationId: ID!): Post
+  onUserStatusChange(userId: ID!): User
 }
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22b267a and d5ebc03.

⛔ Files ignored due to path filters (75)
  • package-lock.json is excluded by !**/package-lock.json
  • public/favicon.ico is excluded by !**/*.ico
  • public/favicon_palisadoes.ico is excluded by !**/*.ico
  • public/images/logo512.png is excluded by !**/*.png
  • public/images/svg/angleDown.svg is excluded by !**/*.svg
  • public/images/svg/arrow-left.svg is excluded by !**/*.svg
  • public/images/svg/arrow-right.svg is excluded by !**/*.svg
  • public/images/svg/attendees.svg is excluded by !**/*.svg
  • public/images/svg/feedback.svg is excluded by !**/*.svg
  • public/images/svg/profiledefault.svg is excluded by !**/*.svg
  • public/images/svg/up-down.svg is excluded by !**/*.svg
  • public/logo192.png is excluded by !**/*.png
  • public/markdown/images/install1.png is excluded by !**/*.png
  • public/markdown/images/install2.png is excluded by !**/*.png
  • src/assets/css/app.css.map is excluded by !**/*.map
  • src/assets/images/blank.png is excluded by !**/*.png
  • src/assets/images/bronze.png is excluded by !**/*.png
  • src/assets/images/defaultImg.png is excluded by !**/*.png
  • src/assets/images/gold.png is excluded by !**/*.png
  • src/assets/images/palisadoes_logo.png is excluded by !**/*.png
  • src/assets/images/silver.png is excluded by !**/*.png
  • src/assets/images/talawa-logo-600x600.png is excluded by !**/*.png
  • src/assets/images/talawa-logo-dark-200x200.png is excluded by !**/*.png
  • src/assets/images/talawa-logo-lite-200x200.png is excluded by !**/*.png
  • src/assets/svgs/Attendance.svg is excluded by !**/*.svg
  • src/assets/svgs/actionItem.svg is excluded by !**/*.svg
  • src/assets/svgs/admin.svg is excluded by !**/*.svg
  • src/assets/svgs/agenda-category-icon.svg is excluded by !**/*.svg
  • src/assets/svgs/agenda-items.svg is excluded by !**/*.svg
  • src/assets/svgs/angleRight.svg is excluded by !**/*.svg
  • src/assets/svgs/article.svg is excluded by !**/*.svg
  • src/assets/svgs/blockUser.svg is excluded by !**/*.svg
  • src/assets/svgs/blockedUser.svg is excluded by !**/*.svg
  • src/assets/svgs/cardItemDate.svg is excluded by !**/*.svg
  • src/assets/svgs/cardItemEvent.svg is excluded by !**/*.svg
  • src/assets/svgs/cardItemLocation.svg is excluded by !**/*.svg
  • src/assets/svgs/chat.svg is excluded by !**/*.svg
  • src/assets/svgs/checkInRegistrants.svg is excluded by !**/*.svg
  • src/assets/svgs/dashboard.svg is excluded by !**/*.svg
  • src/assets/svgs/date.svg is excluded by !**/*.svg
  • src/assets/svgs/event.svg is excluded by !**/*.svg
  • src/assets/svgs/events.svg is excluded by !**/*.svg
  • src/assets/svgs/flask.svg is excluded by !**/*.svg
  • src/assets/svgs/funds.svg is excluded by !**/*.svg
  • src/assets/svgs/key.svg is excluded by !**/*.svg
  • src/assets/svgs/listEventRegistrants.svg is excluded by !**/*.svg
  • src/assets/svgs/location.svg is excluded by !**/*.svg
  • src/assets/svgs/logout.svg is excluded by !**/*.svg
  • src/assets/svgs/media.svg is excluded by !**/*.svg
  • src/assets/svgs/newChat.svg is excluded by !**/*.svg
  • src/assets/svgs/organizations.svg is excluded by !**/*.svg
  • src/assets/svgs/palisadoes.svg is excluded by !**/*.svg
  • src/assets/svgs/people.svg is excluded by !**/*.svg
  • src/assets/svgs/plugins.svg is excluded by !**/*.svg
  • src/assets/svgs/post.svg is excluded by !**/*.svg
  • src/assets/svgs/posts.svg is excluded by !**/*.svg
  • src/assets/svgs/requests.svg is excluded by !**/*.svg
  • src/assets/svgs/roles.svg is excluded by !**/*.svg
  • src/assets/svgs/settings.svg is excluded by !**/*.svg
  • src/assets/svgs/social-icons/Facebook-Logo.svg is excluded by !**/*.svg
  • src/assets/svgs/social-icons/Github-Logo.svg is excluded by !**/*.svg
  • src/assets/svgs/social-icons/Instagram-Logo.svg is excluded by !**/*.svg
  • src/assets/svgs/social-icons/Linkedin-Logo.svg is excluded by !**/*.svg
  • src/assets/svgs/social-icons/Reddit-Logo.svg is excluded by !**/*.svg
  • src/assets/svgs/social-icons/Slack-Logo.svg is excluded by !**/*.svg
  • src/assets/svgs/social-icons/X-Logo.svg is excluded by !**/*.svg
  • src/assets/svgs/social-icons/Youtube-Logo.svg is excluded by !**/*.svg
  • src/assets/svgs/tag.svg is excluded by !**/*.svg
  • src/assets/svgs/tags.svg is excluded by !**/*.svg
  • src/assets/svgs/talawa.svg is excluded by !**/*.svg
  • src/assets/svgs/user.svg is excluded by !**/*.svg
  • src/assets/svgs/userEvent.svg is excluded by !**/*.svg
  • src/assets/svgs/users.svg is excluded by !**/*.svg
  • src/assets/svgs/venues.svg is excluded by !**/*.svg
  • src/assets/talawa-logo-lite-200x200.png is excluded by !**/*.png
📒 Files selected for processing (82)
  • .coderabbit.yaml (1 hunks)
  • .env.example (1 hunks)
  • .eslintignore (1 hunks)
  • .eslintrc.json (4 hunks)
  • .github/ISSUE_TEMPLATE/bug-report.md (2 hunks)
  • .github/ISSUE_TEMPLATE/feature-request.md (2 hunks)
  • .github/dependabot.yaml (1 hunks)
  • .github/pull_request_template.md (2 hunks)
  • .github/workflows/README.md (1 hunks)
  • .github/workflows/auto-label.json5 (1 hunks)
  • .github/workflows/check-tsdoc.js (1 hunks)
  • .github/workflows/ci.yml (0 hunks)
  • .github/workflows/codeql-analysis.yml (0 hunks)
  • .github/workflows/codeql-codescan.yml (1 hunks)
  • .github/workflows/compare_translations.py (1 hunks)
  • .github/workflows/countline.py (1 hunks)
  • .github/workflows/eslint_disable_check.py (1 hunks)
  • .github/workflows/issue.yml (1 hunks)
  • .github/workflows/linter.yml (0 hunks)
  • .github/workflows/npm-publish.yml (0 hunks)
  • .github/workflows/pull-request-target.yml (1 hunks)
  • .github/workflows/pull-request.yml (1 hunks)
  • .github/workflows/push.yml (1 hunks)
  • .github/workflows/stale.yml (1 hunks)
  • .github/workflows/talawa_admin_md_mdx_format_adjuster.py (1 hunks)
  • .gitignore (2 hunks)
  • .husky/post-merge (1 hunks)
  • .husky/pre-commit (1 hunks)
  • .lintstagedrc.json (1 hunks)
  • .node-version (1 hunks)
  • .prettierignore (1 hunks)
  • .prettierrc (1 hunks)
  • CODEOWNERS (1 hunks)
  • CODE_OF_CONDUCT.md (1 hunks)
  • CODE_STYLE.md (1 hunks)
  • CONTRIBUTING.md (2 hunks)
  • DOCUMENTATION.md (1 hunks)
  • Docker_Container/.dockerignore (0 hunks)
  • Docker_Container/README.md (0 hunks)
  • Docker_Container/docker-compose.yml (0 hunks)
  • Docker_Container/dockerfile (0 hunks)
  • INSTALLATION.md (1 hunks)
  • ISSUE_GUIDELINES.md (1 hunks)
  • ISSUE_TEMPLATE.md (0 hunks)
  • PR-guidelines.md (0 hunks)
  • PR_GUIDELINES.md (1 hunks)
  • PULL_REQUEST_TEMPLATE.md (0 hunks)
  • README.md (3 hunks)
  • config/babel.config.cjs (1 hunks)
  • config/vite.config.ts (1 hunks)
  • index.html (1 hunks)
  • issue-guidelines.md (0 hunks)
  • jest-preview.config.ts (1 hunks)
  • jest.config.js (1 hunks)
  • package.json (2 hunks)
  • public/index.html (0 hunks)
  • public/locales/en/common.json (1 hunks)
  • public/locales/en/errors.json (1 hunks)
  • public/locales/en/translation.json (1 hunks)
  • public/locales/fr/common.json (1 hunks)
  • public/locales/fr/errors.json (1 hunks)
  • public/locales/fr/translation.json (1 hunks)
  • public/locales/hi/common.json (1 hunks)
  • public/locales/hi/errors.json (1 hunks)
  • public/locales/hi/translation.json (1 hunks)
  • public/locales/sp/common.json (1 hunks)
  • public/locales/sp/errors.json (1 hunks)
  • public/locales/sp/translation.json (1 hunks)
  • public/locales/zh/common.json (1 hunks)
  • public/locales/zh/errors.json (1 hunks)
  • public/locales/zh/translation.json (1 hunks)
  • public/manifest.json (1 hunks)
  • schema.graphql (1 hunks)
  • scripts/__mocks__/@dicebear/collection.ts (1 hunks)
  • scripts/__mocks__/@dicebear/core.ts (1 hunks)
  • scripts/__mocks__/@pdfme/generator.test.ts (1 hunks)
  • scripts/__mocks__/@pdfme/generator.ts (1 hunks)
  • scripts/__mocks__/fileMock.js (1 hunks)
  • scripts/custom-test-env.js (1 hunks)
  • scripts/githooks/check-localstorage-usage.js (1 hunks)
  • scripts/githooks/update-toc.js (1 hunks)
  • setup.ts (1 hunks)
⛔ Files not processed due to max files limit (28)
  • src/App.test.tsx
  • src/App.tsx
  • src/Constant/constant.spec.ts
  • src/Constant/constant.ts
  • src/GraphQl/Mutations/ActionItemCategoryMutations.ts
  • src/GraphQl/Mutations/ActionItemMutations.ts
  • src/GraphQl/Mutations/AgendaCategoryMutations.ts
  • src/GraphQl/Mutations/AgendaItemMutations.ts
  • src/GraphQl/Mutations/CampaignMutation.ts
  • src/GraphQl/Mutations/CommentMutations.ts
  • src/GraphQl/Mutations/EventAttendeeMutations.ts
  • src/GraphQl/Mutations/EventVolunteerMutation.ts
  • src/GraphQl/Mutations/FundMutation.ts
  • src/GraphQl/Mutations/OrganizationMutations.ts
  • src/GraphQl/Mutations/PledgeMutation.ts
  • src/GraphQl/Mutations/TagMutations.ts
  • src/GraphQl/Mutations/VenueMutations.ts
  • src/GraphQl/Mutations/mutations.ts
  • src/GraphQl/Queries/ActionItemCategoryQueries.ts
  • src/GraphQl/Queries/ActionItemQueries.ts
  • src/GraphQl/Queries/AgendaCategoryQueries.ts
  • src/GraphQl/Queries/AgendaItemQueries.ts
  • src/GraphQl/Queries/EventVolunteerQueries.ts
  • src/GraphQl/Queries/OrganizationQueries.ts
  • src/GraphQl/Queries/PlugInQueries.ts
  • src/GraphQl/Queries/Queries.ts
  • src/GraphQl/Queries/fundQueries.ts
  • src/GraphQl/Queries/userTagQueries.ts
💤 Files with no reviewable changes (13)
  • Docker_Container/.dockerignore
  • Docker_Container/docker-compose.yml
  • PR-guidelines.md
  • .github/workflows/codeql-analysis.yml
  • issue-guidelines.md
  • public/index.html
  • Docker_Container/README.md
  • ISSUE_TEMPLATE.md
  • PULL_REQUEST_TEMPLATE.md
  • .github/workflows/ci.yml
  • .github/workflows/linter.yml
  • Docker_Container/dockerfile
  • .github/workflows/npm-publish.yml
✅ Files skipped from review due to trivial changes (22)
  • scripts/mocks/fileMock.js
  • .eslintignore
  • scripts/mocks/@dicebear/collection.ts
  • .prettierrc
  • config/babel.config.cjs
  • .node-version
  • .prettierignore
  • CODEOWNERS
  • public/locales/sp/errors.json
  • .lintstagedrc.json
  • .github/dependabot.yaml
  • public/locales/zh/translation.json
  • public/locales/sp/translation.json
  • public/locales/fr/errors.json
  • index.html
  • public/locales/en/translation.json
  • .env.example
  • public/locales/hi/translation.json
  • public/locales/zh/errors.json
  • public/locales/hi/errors.json
  • public/locales/en/common.json
  • public/locales/fr/common.json
🧰 Additional context used
📓 Learnings (1)
scripts/githooks/check-localstorage-usage.js (1)
Learnt from: MayankJha014
PR: PalisadoesFoundation/talawa-admin#2612
File: scripts/githooks/check-localstorage-usage.js:10-18
Timestamp: 2024-12-07T14:25:09.928Z
Learning: TypeScript type annotations should not be added to JavaScript (`.js`) files in this project. Type annotations can only be used in TypeScript (`.ts` or `.tsx`) files.
🪛 eslint
scripts/custom-test-env.js

[error] 5-5: tsdoc-undefined-tag: The TSDoc tag "@pdfme" is not defined in this configuration

(tsdoc/syntax)


[error] 9-9: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)


[error] 9-9: Missing return type on function.

(@typescript-eslint/explicit-module-boundary-types)

jest.config.js

[error] 33-33: Delete ·

(prettier/prettier)


[error] 34-34: Insert ,

(prettier/prettier)

scripts/githooks/update-toc.js

[error] 11-12: Delete ··⏎

(prettier/prettier)

scripts/githooks/check-localstorage-usage.js

[error] 10-10: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)


[error] 20-20: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)


[error] 43-43: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)


[error] 89-89: Insert ,

(prettier/prettier)


[error] 92-92: Insert ,

(prettier/prettier)

🪛 actionlint (1.7.4)
.github/workflows/stale.yml

28-28: the runner of "actions/stale@v8" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

.github/workflows/codeql-codescan.yml

35-35: the runner of "github/codeql-action/init@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)


41-41: the runner of "github/codeql-action/autobuild@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)


44-44: the runner of "github/codeql-action/analyze@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

.github/workflows/pull-request.yml

61-61: property "changed_files" is not defined in object type {changed-files: {conclusion: string; outcome: string; outputs: {string => string}}}

(expression)


62-62: shellcheck reported issue in this script: SC2086:info:1:12: Double quote to prevent globbing and word splitting

(shellcheck)


79-79: "github.event.pull_request.head.ref" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions for more details

(expression)

.github/workflows/issue.yml

29-29: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🪛 yamllint (1.35.1)
.github/workflows/stale.yml

[error] 6-6: trailing spaces

(trailing-spaces)


[error] 20-20: trailing spaces

(trailing-spaces)


[error] 21-21: trailing spaces

(trailing-spaces)

.github/workflows/codeql-codescan.yml

[error] 6-6: trailing spaces

(trailing-spaces)


[error] 17-17: trailing spaces

(trailing-spaces)


[error] 20-20: trailing spaces

(trailing-spaces)


[warning] 31-31: wrong indentation: expected 6 but found 7

(indentation)


[warning] 37-37: wrong indentation: expected 11 but found 10

(indentation)

.github/workflows/pull-request-target.yml

[error] 6-6: trailing spaces

(trailing-spaces)


[error] 13-13: trailing spaces

(trailing-spaces)


[error] 15-15: trailing spaces

(trailing-spaces)


[error] 27-27: trailing spaces

(trailing-spaces)


[error] 28-28: trailing spaces

(trailing-spaces)


[error] 29-29: trailing spaces

(trailing-spaces)


[error] 31-31: trailing spaces

(trailing-spaces)


[error] 33-33: trailing spaces

(trailing-spaces)


[error] 34-34: trailing spaces

(trailing-spaces)


[error] 36-36: trailing spaces

(trailing-spaces)


[error] 41-41: trailing spaces

(trailing-spaces)


[error] 46-46: trailing spaces

(trailing-spaces)


[error] 71-71: trailing spaces

(trailing-spaces)

.github/workflows/pull-request.yml

[error] 49-49: trailing spaces

(trailing-spaces)


[error] 60-60: trailing spaces

(trailing-spaces)


[error] 63-63: trailing spaces

(trailing-spaces)


[error] 92-92: trailing spaces

(trailing-spaces)


[error] 126-126: trailing spaces

(trailing-spaces)


[error] 129-129: trailing spaces

(trailing-spaces)


[error] 150-150: trailing spaces

(trailing-spaces)


[error] 157-157: trailing spaces

(trailing-spaces)


[error] 197-197: trailing spaces

(trailing-spaces)


[error] 201-201: trailing spaces

(trailing-spaces)


[error] 204-204: trailing spaces

(trailing-spaces)


[error] 205-205: trailing spaces

(trailing-spaces)


[error] 213-213: trailing spaces

(trailing-spaces)


[error] 243-243: trailing spaces

(trailing-spaces)


[error] 249-249: trailing spaces

(trailing-spaces)


[error] 251-251: trailing spaces

(trailing-spaces)

.github/workflows/push.yml

[error] 6-6: trailing spaces

(trailing-spaces)


[error] 17-17: trailing spaces

(trailing-spaces)


[error] 18-18: trailing spaces

(trailing-spaces)


[warning] 20-20: wrong indentation: expected 2 but found 4

(indentation)


[error] 21-21: trailing spaces

(trailing-spaces)


[error] 50-50: trailing spaces

(trailing-spaces)


[warning] 62-62: too many blank lines

(1 > 0) (empty-lines)

.github/workflows/issue.yml

[error] 6-6: trailing spaces

(trailing-spaces)


[warning] 15-15: wrong indentation: expected 4 but found 6

(indentation)


[warning] 66-66: too many blank lines

(1 > 0) (empty-lines)

🪛 LanguageTool
.github/workflows/README.md

[uncategorized] ~13-~13: Possible missing comma found.
Context: ...ding on the type of workflow. Whenever possible you must ensure that: 1. The file roles...

(AI_HYDRA_LEO_MISSING_COMMA)


[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...ors: 1. Place all actions related to to this in the pull-request-target.yml f...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~35-~35: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...orrectly if they have a dedicated file (eg. CodeQL) ## Scripts Follow these gui...

(E_G)

CONTRIBUTING.md

[style] ~27-~27: This expression usually appears with a “please” in front of it.
Context: ...DUCT.md) to understand what this means. Let us know immediately if you have unacceptable ex...

(INSERT_PLEASE)


[uncategorized] ~34-~34: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors. ## Ways to Contribute I...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


[grammar] ~62-~62: A determiner may be missing.
Context: ...l Request guidelines](PR_GUIDELINES.md) is best resource to follow to start working on ...

(THE_SUPERLATIVE)


[uncategorized] ~68-~68: Loose punctuation mark.
Context: ...ushed to the main branch: - develop: For unstable code and bug fixing - `mai...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~69-~69: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...d bug fixing - main: Where the stable production ready code lies. This is our default branch. ...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


[typographical] ~73-~73: Consider adding a comma.
Context: ...ultiple developers are working on issues there is bound to be a conflict of interest (...

(IF_THERE_COMMA)


[typographical] ~73-~73: Consider adding a comma after ‘Usually’ for more clarity.
Context: ...licts) among issues, PRs or even ideas. Usually these conflicts are resolved in a **Fir...

(RB_LY_COMMA)


[grammar] ~73-~73: Did you mean “served” (as in the idiom ‘first come, first served’)?
Context: ...ts are resolved in a First Come First Serve basis however there are certain excep...

(FIRST_SERVED)


[uncategorized] ~75-~75: Possible missing comma found.
Context: ... an extension or in conflict with other PRs it is important to ask the author of th...

(AI_HYDRA_LEO_MISSING_COMMA)


[grammar] ~75-~75: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...tant to ask the author of the PR in the slack channel or in their PRs or issues thems...

(ON_SKYPE)


[style] ~77-~77: ‘Last but not the least’ might be wordy. Consider a shorter alternative.
Context: ...y and test that function when needed. - Last but not the least, communication is important make sure t...

(EN_WORDINESS_PREMIUM_LAST_BUT_NOT_THE_LEAST)


[grammar] ~77-~77: It seems that “to” is missing before the verb.
Context: ...t the least, communication is important make sure to talk to other contributors, in ...

(MISSING_TO_BETWEEN_BE_AND_VB)


[grammar] ~77-~77: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ... other contributors, in these cases, in slack channel or in a issue/PR thread. - As a...

(ON_SKYPE)


[misspelling] ~77-~77: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... in these cases, in slack channel or in a issue/PR thread. - As a last resort the...

(EN_A_VS_AN)


[typographical] ~78-~78: It appears that a comma is missing.
Context: ...el or in a issue/PR thread. - As a last resort the Admins would be responsible for dec...

(DURING_THAT_TIME_COMMA)


[grammar] ~135-~135: The operating system from Apple is written “macOS”.
Context: ...r packages can be found for Windows and MacOS. 6. The currently acceptable c...

(MAC_OS)


[uncategorized] ~163-~163: Possible missing comma found.
Context: ...odecov/results.jpg)]() 1. After making changes you can add them to git locally using `...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~165-~165: Possible missing comma found.
Context: ...using: git push origin <branch_name>.(Here branch name must be name of the branch ...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~165-~165: Possible missing article found.
Context: ...: git push origin <branch_name>.(Here branch name must be name of the branch you wan...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~165-~165: Possible missing article found.
Context: ...branch_name>`.(Here branch name must be name of the branch you want to push the chan...

(AI_HYDRA_LEO_MISSING_THE)


[uncategorized] ~167-~167: Possible missing comma found.
Context: ...test suite passes, either locally or on CI once a PR has been created. 1. Review a...

(AI_HYDRA_LEO_MISSING_COMMA)


[grammar] ~178-~178: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...dation/talawa) for the link to join our slack channel. 1. We also have a technical em...

(ON_SKYPE)

README.md

[uncategorized] ~56-~56: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...)" videos are extremely helpful for new open source contributors.

(EN_COMPOUND_ADJECTIVE_INTERNAL)

PR_GUIDELINES.md

[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Pull Request Guidelines 👍🎉 First off, thanks for taking t...

(UNLIKELY_OPENING_PUNCTUATION)


[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a pull...

(IN_ORDER_TO_PREMIUM)


[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...

(SPLIT_INFINITIVE)


[style] ~56-~56: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...o be closed. The quality of our code is very important to us. Therefore we make experienced ma...

(EN_WEAK_ADJECTIVE)


[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ty of our code is very important to us. Therefore we make experienced maintainers of our ...

(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)


[style] ~59-~59: Consider using a different verb for a more formal wording.
Context: ...check if all tests are passing; if not, fix the issues and then create a pull reque...

(FIX_RESOLVE)


[style] ~64-~64: This expression is wordy and overused. Consider replacing it with a more concise and formal alternative.
Context: ...wer your questions, but we'll get to it sooner or later. @mentioning someone just adds to the p...

(SOONER_OR_LATER)


[uncategorized] ~64-~64: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...adds to the pile of notifications we get and it won't make us look at your issue fas...

(COMMA_COMPOUND_SENTENCE)


[style] ~65-~65: Consider shortening or rephrasing this to strengthen your wording.
Context: ...ue faster. 1. Do not force push. If you make changes to your pull request, please simply add a ...

(MAKE_CHANGES)

ISSUE_GUIDELINES.md

[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Issue Report Guidelines 👍🎉 First off, thanks for taking t...

(UNLIKELY_OPENING_PUNCTUATION)


[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a issu...

(IN_ORDER_TO_PREMIUM)


[misspelling] ~5-~5: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...der to give everyone a chance to submit a issues reports and contribute to the Ta...

(EN_A_VS_AN)


[typographical] ~24-~24: Consider adding a comma here.
Context: ...> ___ ## Issue Management In all cases please use the [GitHub open issue search](http...

(PLEASE_COMMA)


[uncategorized] ~27-~27: A comma might be missing here.
Context: ...reported. ### New Issues To create new issues follow these steps: 1. Your issue may ...

(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)


[style] ~30-~30: Consider using a different verb for a more formal wording.
Context: .... 1. Verify whether the issue has been fixed by trying to reproduce it using the lat...

(FIX_RESOLVE)


[uncategorized] ~32-~32: Possible missing preposition found.
Context: ...lawa-admin/issues/new/choose) button 1. Use the templates to create a standardized ...

(AI_HYDRA_LEO_MISSING_TO)


[style] ~35-~35: The wording of this phrase can be improved.
Context: ...lcome contributors who find new ways to make the code better. ### Existing Issues You can also be ...

(MAKE_STYLE_BETTER)


[grammar] ~44-~44: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...butors to assign it to you in #talawa slack channel. Working on these types of exi...

(ON_SKYPE)


[grammar] ~53-~53: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...ew Issues 1. Join our #talawa-github slack channel for automatic issue and pull re...

(ON_SKYPE)


[grammar] ~57-~57: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...lines 1. Discuss issues in our various slack channels when necessary 2. Please do no...

(ON_SKYPE)


[typographical] ~57-~57: Consider adding a comma here.
Context: ...ur various slack channels when necessary 2. Please do not derail or troll issues. 3. Keep...

(PLEASE_COMMA)

DOCUMENTATION.md

[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...f docs.talawa.io should automatically launched in your browser at http://localhost:300...

(MD_BASEFORM)


[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to the docs/ directory of t...

(MARKDOWN_NNP)


[uncategorized] ~32-~32: The preposition “to” seems more likely in this position.
Context: ... PLEASE do not add markdown files in this repository. Add them to `talawa-do...

(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)

CODE_STYLE.md

[style] ~127-~127: Consider removing “of” to be more concise
Context: ...tories of src assets - This houses all of the static assets used in the project - `...

(ALL_OF_THE)


[style] ~128-~128: Consider removing “of” to be more concise
Context: ... in the project - css - This houses all of the css files used in the project - `imag...

(ALL_OF_THE)


[style] ~129-~129: Consider removing “of” to be more concise
Context: ... the project - images - This houses all of the images used in the project - scss -...

(ALL_OF_THE)


[style] ~130-~130: Consider removing “of” to be more concise
Context: ...in the project - scss - This houses all of the scss files used in the project - `c...

(ALL_OF_THE)


[grammar] ~134-~134: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ...rms - _talawa.scss - Partial Sass file for Talawa - _utilities.scss - Pa...

(HE_VERB_AGR)


[grammar] ~135-~135: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... - _utilities.scss - Partial Sass file for utilities - _variables.scss -...

(HE_VERB_AGR)


[grammar] ~136-~136: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... - _variables.scss - Partial Sass file for variables - app.scss - Main S...

(HE_VERB_AGR)


[style] ~141-~141: Consider removing “of” to be more concise
Context: ...views/screens Constant - This houses all of the constants used in the project `GraphQl...

(ALL_OF_THE)


[style] ~143-~143: Consider removing “of” to be more concise
Context: ...in the project GraphQl - This houses all of the GraphQL queries and mutations used in t...

(ALL_OF_THE)


[style] ~145-~145: Consider removing “of” to be more concise
Context: ...in the project screens - This houses all of the views/screens to be navigated through i...

(ALL_OF_THE)


[style] ~147-~147: Consider removing “of” to be more concise
Context: ... in Talawa-Admin state - This houses all of the state management code for the project ...

(ALL_OF_THE)


[uncategorized] ~165-~165: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...following order: - React imports - Third party imports - Local imports If there is...

(EN_COMPOUND_ADJECTIVE_INTERNAL)

INSTALLATION.md

[duplication] ~25-~25: Possible typo: you repeated a word
Context: ...](#running-talawa-admin) - Accessing Talawa-Admin - [Talawa-Admin Registration](#talawa-admin-registratio...

(ENGLISH_WORD_REPEAT_RULE)


[typographical] ~55-~55: It appears that a comma is missing.
Context: ... that follow. # Prerequisites In this section we'll explain how to set up all the pre...

(DURING_THAT_TIME_COMMA)


[uncategorized] ~61-~61: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: .... Basic git knowledge is required for open source contribution so make sure you're comfor...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


[uncategorized] ~64-~64: Possible missing comma found.
Context: ...ithub. ## Setting up this repository First you need a local copy of talawa-admin`...

(AI_HYDRA_LEO_MISSING_COMMA)


[grammar] ~67-~67: The word “setup” is a noun. The verb is spelled with a space.
Context: ...avigate to the folder where you want to setup the repository. 2. Open a cmd (Window...

(NOUN_VERB_CONFUSION)


[grammar] ~68-~68: The operating system from Apple is written “macOS”.
Context: ...cmd (Windows) or terminal (Linux or MacOS) session in this folder. 1. An easy ...

(MAC_OS)


[uncategorized] ~69-~69: You might be missing the article “the” here.
Context: ...to do this is to right-click and choose appropriate option based on your OS. 3. **For Our O...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~70-~70: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...e option based on your OS. 3. For Our Open Source Contributor Software Developers: ...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


[uncategorized] ~99-~99: A determiner appears to be missing. Consider inserting it.
Context: ...dmin.git ``` ## Install node.js Best way to install and manage node.js is ...

(AI_EN_LECTOR_MISSING_DETERMINER)


[uncategorized] ~100-~100: Possible missing preposition found.
Context: ... way to install and manage node.js is making use of node version managers. We recomm...

(AI_EN_LECTOR_MISSING_PREPOSITION)


[uncategorized] ~102-~102: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...steps to install the node.js packages in Windows, Linux and MacOS. 1. For Windo...

(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)


[grammar] ~102-~102: The operating system from Apple is written “macOS”.
Context: ...node.jspackages in Windows, Linux and MacOS. 1. For Windows: 1. first install...

(MAC_OS)


[duplication] ~116-~116: Possible typo: you repeated a word
Context: ... 5. Save the document. 6. Exit notepad 7. Exit PowerShell 8. This will ensure...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~118-~118: Possible missing comma found.
Context: ...ou are always using the correct version of node.js 2. For Linux and MacOS, use t...

(AI_HYDRA_LEO_MISSING_COMMA)


[grammar] ~119-~119: The operating system from Apple is written “macOS”.
Context: ...t version of node.js 2. For Linux and MacOS, use the terminal window. 1. install...

(MAC_OS)


[grammar] ~123-~123: The word “setup” is a noun. The verb is spelled with a white space.
Context: ... the respective recommended commands to setup your node environment 3. This wil...

(NOUN_VERB_CONFUSION)


[uncategorized] ~158-~158: Possible missing comma found.
Context: ...ions in "setup" can be done manually as well and here's how to do it. - [Creating .e...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~162-~162: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...at runtime. It is not a part of the repo and you will have to create it. For a sampl...

(COMMA_COMPOUND_SENTENCE)


[uncategorized] ~162-~162: Possible missing comma found.
Context: ...ve to create it. For a sample of .env file there is a file named .env.example in...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~162-~162: You might be missing the article “the” here.
Context: ...the contents of the .env.example into .env file. Use this command: ``` cp .e...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~224-~224: Possible missing preposition found.
Context: ... For additional details, please refer theHow to Access the Talawa-API URL` sect...

(AI_HYDRA_LEO_MISSING_TO)


[grammar] ~228-~228: The word “setup” is a noun. The verb is spelled with a space.
Context: ...E_KEY in .env file You may not want to setup reCAPTCHA since the project will still ...

(NOUN_VERB_CONFUSION)


[grammar] ~232-~232: The word “setup” is a noun. The verb is spelled with a space.
Context: ...ad the following steps. If you want to setup Google reCAPTCHA now, you may refer to ...

(NOUN_VERB_CONFUSION)


[uncategorized] ~234-~234: Possible missing comma found.
Context: ... service you set up during talawa-api installation as shown in this screenshot: ![reCAPTC...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~238-~238: You might be missing the article “the” here.
Context: ...named REACT_APP_RECAPTCHA_SITE_KEY in .env file. ``` REACT_APP_RECAPTCHA_SIT...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[typographical] ~246-~246: Except for inverted sentences, ‘need them’ requires a question mark at the end of the sentence.
Context: ...t need them or want to keep the console clean # Post Configuration Steps It's now t...

(MD_PRP_QUESTION_MARK)


[uncategorized] ~261-~261: Did you mean: “By default,”?
Context: ...n serve ``` ## Accessing Talawa-Admin By default talawa-admin runs on port `4321` on y...

(BY_DEFAULT_COMMA)


[uncategorized] ~278-~278: A comma might be missing here.
Context: ... navigate to the running talawa-admin's website you'll land at talawa-admin registratio...

(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)


[uncategorized] ~278-~278: You might be missing the article “the” here.
Context: ...g talawa-admin's website you'll land at talawa-admin registration page. Sign up using ...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[grammar] ~311-~311: The word ‘lint’ is a noun or an adjective. A verb or adverb is missing or misspelled here, or maybe a comma is missing.
Context: ...w.webp) ## Linting code files You can lint your code files using this command: ``...

(PRP_MD_NN)

CODE_OF_CONDUCT.md

[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...

(ENGLISH_WORD_REPEAT_RULE)

🪛 Markdownlint (0.37.0)
.github/ISSUE_TEMPLATE/feature-request.md

28-28: null
Bare URL used

(MD034, no-bare-urls)


25-25: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

CONTRIBUTING.md

104-104: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


113-113: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


128-128: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


139-139: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


143-143: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


158-158: null
No empty links

(MD042, no-empty-links)


159-159: null
No empty links

(MD042, no-empty-links)


161-161: null
No empty links

(MD042, no-empty-links)

.github/ISSUE_TEMPLATE/bug-report.md

36-36: null
Bare URL used

(MD034, no-bare-urls)


33-33: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

README.md

53-53: null
Multiple spaces after hash on atx style heading

(MD019, no-multiple-space-atx)

PR_GUIDELINES.md

31-31: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


39-39: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

DOCUMENTATION.md

25-25: null
Bare URL used

(MD034, no-bare-urls)

CODE_STYLE.md

128-128: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


129-129: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


130-130: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


131-131: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


132-132: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


133-133: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


134-134: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


135-135: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


136-136: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


137-137: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


164-164: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


165-165: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


166-166: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


57-57: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


73-73: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


75-75: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


92-92: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


190-190: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


230-230: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


58-58: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


65-65: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


78-78: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


95-95: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


158-158: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


173-173: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


181-181: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


239-239: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


245-245: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


251-251: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

INSTALLATION.md

321-321: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

(MD001, heading-increment)


33-33: Expected: 4; Actual: 6
Unordered list indentation

(MD007, ul-indent)


34-34: Expected: 4; Actual: 6
Unordered list indentation

(MD007, ul-indent)


95-95: null
Dollar signs used before commands without showing output

(MD014, commands-show-output)


105-105: null
Bare URL used

(MD034, no-bare-urls)


142-142: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


154-154: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


164-164: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


188-188: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


194-194: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


200-200: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


208-208: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


214-214: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


220-220: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


240-240: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


256-256: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


264-264: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


270-270: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


292-292: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


300-300: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


313-313: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


327-327: Expected: fenced; Actual: indented
Code block style

(MD046, code-block-style)


335-335: Expected: fenced; Actual: indented
Code block style

(MD046, code-block-style)


178-178: Expected: #setting-up-react_app_talawa_url-in-env-file; Actual: #setting-up-REACT_APP_TALAWA_URL-in-env-file
Link fragments should be valid

(MD051, link-fragments)


178-178: Expected: #setting-up-react_app_recaptcha_site_key-in-env-file; Actual: #setting-up-REACT_APP_RECAPTCHA_SITE_KEY-in-env-file
Link fragments should be valid

(MD051, link-fragments)

🪛 Ruff (0.8.2)
.github/workflows/eslint_disable_check.py

61-61: Loop control variable dirs not used within loop body

Rename unused dirs to _dirs

(B007)

.github/workflows/compare_translations.py

135-135: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling

(B904)

🔇 Additional comments (49)
.github/workflows/compare_translations.py (1)

63-90: Looks good: robust approach to detecting mismatching keys.
The two-pass validation ensures missing and unmatched keys are comprehensively flagged. This is a solid approach to prevent incomplete translations across languages.

config/vite.config.ts (4)

1-5: Imports look consistent and aligned with Vite ecosystem.
The set of imported plugins (React, TypeScript paths, SVGR, and Environment) is appropriate for a modern React + TypeScript project. No issues found.


7-11: Consider clarifying the build folder structure.
You're currently directing build artifacts to 'build'. If there is any established folder structure (e.g., 'dist', 'output', etc.) in other parts of the project or any relevant CI/CD pipeline steps relying on a particular folder name, ensure that 'build' aligns with the rest of the repository.


12-13: Review base URL settings.
The base field is set to an empty string. If your production environment requires assets to load from a specific path, you might need to match that or provide a fallback base path, such as '/'.


14-23: Plugins are adequately configured.
The mix of React, TypeScript paths resolution, environment variable management, and SVG handling is an efficient combination, particularly with svgrOptions set to icon: true.

scripts/githooks/update-toc.js (3)

1-2: Ensure the environment supports ES Modules.
You've used ES module imports (import fs from 'fs';). Confirm that your Node.js environment supports ESM or that you have "type": "module" in your package.json.


14-14: Confirm this message suits your development flow.
The success message is concise and helpful. Verify if there’s any additional context you’d like to provide (e.g., files updated, time taken, etc.) to aid troubleshooting.


8-12: 🛠️ Refactor suggestion

Handle potential errors or malicious file names.
You’re passing file names to execSync, which can cause issues with malicious file names. You may want to sanitize the file names or wrap them in quotes. Also, consider adding an error handler for execSync calls to ensure you can respond to exceptions gracefully.

Would you like me to generate a shell script to scan for suspicious file names or potential error patterns in the codebase?

🧰 Tools
🪛 eslint

[error] 11-12: Delete ··⏎

(prettier/prettier)

scripts/githooks/check-localstorage-usage.js (7)

1-2: Shebang usage looks good for Node scripts.
It ensures that the file can be run directly. No issues here.


3-6: ESM imports in a .js file.
Be aware that using ESM-style imports in Node.js scripts typically requires enabling ECMAScript modules or using a Node version supporting this feature. Verify that it doesn’t break older environments.


7-9: Argument parsing approach is clear.
The script extracts --scan-entire-repo from process.argv. This is a straightforward approach and is sufficient here.


10-18: No TypeScript annotations in JavaScript.
Static analysis incorrectly flags the missing function return type. As per your project’s guidelines and the retrieved learnings, note that .js files should not contain TypeScript annotations. You can safely ignore the ESLint error here or modify your config to skip these checks for .js files.

🧰 Tools
🪛 eslint

[error] 10-10: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)


20-37: Robustness of the getModifiedFiles function.
Your strategy to either scan the entire repo for .tsx? files or only the staged files is logical. However, keep in mind that grep might fail if no matches are found, which returns a non-zero exit code. Verify that this scenario is handled gracefully, or consider using a more resilient approach like rg or conditional checks.

🧰 Tools
🪛 eslint

[error] 20-20: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)


39-42: Informative naming.
filesWithLocalStorage clearly conveys intent, making the script self-documenting. This is good.


43-78: Local storage usage check.
Overall logic is straightforward. Any discovered usage of localStorage is collected in filesWithLocalStorage. The skip comment feature and file name filters seem well-structured.

🧰 Tools
🪛 eslint

[error] 43-43: Missing return type on function.

(@typescript-eslint/explicit-function-return-type)

.github/workflows/stale.yml (2)

14-17: LGTM! Appropriate scheduling configuration

The daily midnight schedule is well-suited for stale issue management.


43-43: Consider documenting the operations-per-run limit

The limit of 30 operations per run might need explanation or adjustment based on repository activity.

✅ Verification successful

Let me check the stale workflow configuration to better understand the context of operations-per-run setting.


The operations-per-run limit of 30 is appropriate and well-configured

Based on the repository activity (94 open issues and 24 open PRs) and the stale workflow configuration:

  • The workflow runs daily (cron: "0 0 * * *")
  • Items become stale after 10 days of inactivity
  • Items are closed after 180 days of being stale
  • The limit of 30 operations per run is sufficient because:
    • It processes a balanced number of items daily
    • Prevents API rate limiting
    • Allows for gradual processing of stale items over multiple runs
    • Matches the repository's activity level (118 total open items)
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check repository activity to assess if 30 operations per run is sufficient
echo "Checking open issues and PRs count:"
gh api graphql -f query='
query {
  repository(owner: "PalisadoesFoundation", name: "talawa-admin") {
    openIssues: issues(states: OPEN) {
      totalCount
    }
    openPRs: pullRequests(states: OPEN) {
      totalCount
    }
  }
}' | jq '.data.repository | .openIssues.totalCount, .openPRs.totalCount'

Length of output: 394


Script:

#!/bin/bash
# Check the stale workflow configuration
cat .github/workflows/stale.yml

Length of output: 1960

public/locales/fr/translation.json (1)

1-1483: LGTM! The translation file is well-structured and complete.

The JSON structure is clean and organized, with logical grouping of related translations. All required keys appear to be present with their French translations.

public/locales/en/errors.json (2)

9-10: ⚠️ Potential issue

Fix typo and improve operation failure messages

There's a typo in "occurred" and the messages could be more specific about what failed.

   "errorOccurredCouldntCreate": "An error occurred. Couldn't create {{entity}}",
-  "errorLoading": "Error occured while loading {{entity}} data"
+  "errorLoading": "Error occurred while loading {{entity}} data"

The {{entity}} template variable usage needs verification across the application to ensure consistent naming.

✅ Verification successful

Fix typo in error message and verify consistent entity usage

The search results confirm that both error messages are actively used throughout the application with consistent entity variable usage. The errorLoading message is used in multiple components with appropriate entity names like 'Volunteer Groups', 'Events', 'Pledges', etc. The errorOccurredCouldntCreate message is used in the AdvertisementRegister component with 'advertisement' as the entity.

  • Fix the typo "occured" → "occurred" in errorLoading message in public/locales/en/errors.json
  • The entity variable usage is consistent across all translations (en, sp, zh, fr, hi) and components
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for usage of these error messages to verify entity variable handling
rg -A 2 'errorOccurredCouldntCreate|errorLoading' --type ts --type tsx

Length of output: 100


Script:

#!/bin/bash
# Search for usage of these error messages in all files
rg -A 2 'errorOccurredCouldntCreate|errorLoading'

Length of output: 5662


Script:

#!/bin/bash
# Find all TypeScript and JavaScript files that might use these error messages
fd '\.(ts|tsx|js|jsx)$' -x rg -A 2 'errorOccurredCouldntCreate|errorLoading' {}

Length of output: 1726


Script:

#!/bin/bash
# Look for i18n translation usage patterns with these keys
rg -A 2 "t\(['\"]errors\.(errorOccurredCouldntCreate|errorLoading)"

Length of output: 71


1-11: Verify completeness of error messages

Since this is a new localization file, we should verify that all error scenarios in the application are covered.

ISSUE_GUIDELINES.md (1)

1-1: Verify PR description accuracy

The PR description mentions CSS refactoring in the Leaderboard component, but these changes are related to issue templates and guidelines. Please update the PR description to accurately reflect the changes being made.

.github/workflows/eslint_disable_check.py (2)

1-28: Thorough documentation and adherence to Python standards.

The overall structure and docstring-based explanations are clear, providing maintainers with a cohesive overview of the script’s purpose and methodology.


115-118: Early exit upon ESLint-disable detection is appropriate.

Exiting with code 1 is a concise and effective approach to fail-fast in CI pipelines, ensuring non-compliant files can't be merged.

scripts/__mocks__/@dicebear/core.ts (1)

1-5: Mock approach is effective.

Your mocking strategy is straightforward and clean, enabling isolation of external avatar generation logic during tests.

.husky/pre-commit (1)

10-10: Double-check whether adding all changes is intentional.

Using git add . can inadvertently include updates to unrelated files. If partial commits are desired, consider specifying tracked files or using a more targeted approach.

scripts/__mocks__/@pdfme/generator.ts (1)

3-22: Overall functionality is well-implemented.

This mock generator effectively tests PDF generation scenarios by throwing errors on empty inputs and producing a placeholder PDF-like byte array. Good job ensuring thorough validation logic.

scripts/__mocks__/@pdfme/generator.test.ts (1)

21-46: Effective negative test coverage for empty inputs and templates.

The tests correctly verify that the generate function throws the expected error when supplied with invalid or empty parameters. This comprehensive negative test coverage ensures high reliability.

.github/workflows/check-tsdoc.js (1)

1-2: **Use ES module imports carefully **

You are importing fs and path directly from 'fs/promises' and 'path'. In some Node.js environments or versions, certain import statements might behave differently when used with ES modules vs. CommonJS. Verify that your Node.js version and environment fully support these imports without any unexpected behavior.

To verify compatibility:

✅ Verification successful

**ES module imports are properly configured and supported **

The codebase is correctly set up for ES module imports:

  • Package.json has "type": "module" configured
  • Node.js version v22.9.0 fully supports ES modules
  • Multiple files across the codebase consistently use ES module imports
  • The imports of fs/promises and path in .github/workflows/check-tsdoc.js are compatible with this setup
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check that "type": "module" is set or relevant Node version supports these imports
ast-grep --pattern $'{"type":"module"}'
node -v

Length of output: 58


Script:

#!/bin/bash
# Check package.json for type module
rg '"type":\s*"module"' package.json

# Check if there are any .mjs files or other ES module indicators
fd -e mjs

# Look for other ES module imports in the codebase
rg "import\s+.*\s+from\s+'[^']+'" -g '*.{js,mjs,ts}'

Length of output: 18370

jest.config.js (2)

1-2: **Leverage existing test configuration **

Your Jest configuration looks good overall. It sets appropriate roots, coverage thresholds, transformation rules, and environment settings for a React/TypeScript codebase.


33-34: ⚠️ Potential issue

**Address Prettier lint errors **

Static analysis indicates a formatting conflict with Prettier around these lines. Possibly an extra space or comma is missing. Update or remove the erroneous spacing or missing comma to align with Prettier rules.

Example fix:

-    '\\.svg\\?react$': '<rootDir>/scripts/__mocks__/fileMock.js',
-    '\\.svg$': '<rootDir>/scripts/__mocks__/fileMock.js',
+    '\\.svg\\?react$': '<rootDir>/scripts/__mocks__/fileMock.js',
+    '\\.svg$': '<rootDir>/scripts/__mocks__/fileMock.js'

Likely invalid or redundant comment.

🧰 Tools
🪛 eslint

[error] 33-33: Delete ·

(prettier/prettier)


[error] 34-34: Insert ,

(prettier/prettier)

.github/workflows/talawa_admin_md_mdx_format_adjuster.py (1)

45-65: **Graceful file handling approach **

Your flow for reading, processing, and conditionally writing the file is well-organized. Minimizing unnecessary writes is a good performance practice.

setup.ts (1)

13-21: **Handle missing .env.example gracefully **

If .env.example is missing or corrupted, the script might fail. Consider verifying .env.example's existence before attempting to parse it, and provide a helpful error message if it’s missing or invalid.

.coderabbit.yaml (1)

1-18: Configuration looks correct
No issues are apparent in your .coderabbit.yaml file. The YAML structure, keys, and values are valid. Nice work!

public/manifest.json (1)

16-16: Updated icon source
The "src": "images/logo512.png" update is fine, as long as the path is valid and accessible relative to your application.

.gitignore (5)

3-5: Lock files
Good practice adding yarn.lock and pnpm-lock.yaml to ensure consistent dependency management across different package managers while preventing conflicts in the repo.


13-14: Coverage outputs
Ignoring the coverage/ directory and codecov marks a clean separation between versioned code and generated reports, keeping the repository size minimal.


21-21: Environment variables
Adding .env to .gitignore helps protect sensitive data such as API keys and credentials from accidental commits.


32-32: Debug logs
Excluding debug.log is sensible, avoiding unintentional commits of local debugging artifacts.


35-37: Editor files
Ignoring .idea, .vscode, and *.swp ensures that personal IDE/editor configurations aren’t committed. This is standard practice.

.github/workflows/push.yml (2)

36-49: Cache configuration looks good

The cache configuration is well-structured with:

  • Proper cache key based on package-lock.json
  • Fallback restore-keys
  • Appropriate paths for npm cache

28-29: Review Node.js version compatibility

Using Node.js 22.x might be too aggressive as it's a very recent version. Consider using an LTS version for better stability.

    strategy:
      matrix:
-        node-version: [22.x]
+        node-version: [18.x]
README.md (1)

Line range hint 3-51: LGTM! Documentation improvements look good

The changes enhance the documentation's structure and readability by adding:

  • Community engagement section
  • Clear table of contents
  • Better organized installation and contribution guidelines
🧰 Tools
🪛 Markdownlint (0.37.0)

22-22: Missing link or image reference definition: "pfd"
Reference links and images should use a label that is defined

(MD052, reference-links-images)

🪛 LanguageTool

[uncategorized] ~22-~22: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...university students to work on selected open source projects. They are mentored by software...

(EN_COMPOUND_ADJECTIVE_INTERNAL)

.github/workflows/pull-request-target.yml (1)

12-77: LGTM! Well-structured PR automation workflow

The workflow effectively automates PR processes by:

  • Adding clear review policy comments
  • Providing first-time contributor greetings
  • Setting clear expectations for PR reviews
🧰 Tools
🪛 yamllint (1.35.1)

[error] 13-13: trailing spaces

(trailing-spaces)


[error] 15-15: trailing spaces

(trailing-spaces)


[error] 27-27: trailing spaces

(trailing-spaces)


[error] 28-28: trailing spaces

(trailing-spaces)


[error] 29-29: trailing spaces

(trailing-spaces)


[error] 31-31: trailing spaces

(trailing-spaces)


[error] 33-33: trailing spaces

(trailing-spaces)


[error] 34-34: trailing spaces

(trailing-spaces)


[error] 36-36: trailing spaces

(trailing-spaces)


[error] 41-41: trailing spaces

(trailing-spaces)


[error] 46-46: trailing spaces

(trailing-spaces)


[error] 71-71: trailing spaces

(trailing-spaces)

.eslintrc.json (2)

4-4: LGTM! Enhanced environment and extension configuration

Good addition of Node.js environment and proper integration with TypeScript and Prettier configurations.

Also applies to: 14-16


32-39: LGTM! Well-chosen plugin selection

The added plugins enhance the linting capabilities with:

  • TypeScript support
  • Import management
  • TSDoc validation
  • Prettier integration
PR_GUIDELINES.md (1)

1-69: LGTM! Well-structured guidelines document.

The PR guidelines are comprehensive and clearly outline the expectations for contributors. The document effectively covers all essential aspects of the PR process.

🧰 Tools
🪛 Markdownlint (0.37.0)

31-31: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


39-39: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🪛 LanguageTool

[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Pull Request Guidelines 👍🎉 First off, thanks for taking t...

(UNLIKELY_OPENING_PUNCTUATION)


[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a pull...

(IN_ORDER_TO_PREMIUM)


[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...

(SPLIT_INFINITIVE)


[style] ~56-~56: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...o be closed. The quality of our code is very important to us. Therefore we make experienced ma...

(EN_WEAK_ADJECTIVE)


[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ty of our code is very important to us. Therefore we make experienced maintainers of our ...

(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)


[style] ~59-~59: Consider using a different verb for a more formal wording.
Context: ...check if all tests are passing; if not, fix the issues and then create a pull reque...

(FIX_RESOLVE)


[style] ~64-~64: This expression is wordy and overused. Consider replacing it with a more concise and formal alternative.
Context: ...wer your questions, but we'll get to it sooner or later. @mentioning someone just adds to the p...

(SOONER_OR_LATER)


[uncategorized] ~64-~64: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...adds to the pile of notifications we get and it won't make us look at your issue fas...

(COMMA_COMPOUND_SENTENCE)


[style] ~65-~65: Consider shortening or rephrasing this to strengthen your wording.
Context: ...ue faster. 1. Do not force push. If you make changes to your pull request, please simply add a ...

(MAKE_CHANGES)

package.json (1)

2-3: Verify the major version bump implications.

The version change from 0.1.0 to 3.0.0 is significant and suggests breaking changes. Please ensure this aligns with semantic versioning principles and that all breaking changes are documented.

CODE_STYLE.md (1)

1-253: LGTM! Comprehensive style guide.

The document provides clear guidelines for maintaining consistent code style across the project. The examples and explanations are helpful for contributors.

🧰 Tools
🪛 LanguageTool

[style] ~127-~127: Consider removing “of” to be more concise
Context: ...tories of src assets - This houses all of the static assets used in the project - `...

(ALL_OF_THE)


[style] ~128-~128: Consider removing “of” to be more concise
Context: ... in the project - css - This houses all of the css files used in the project - `imag...

(ALL_OF_THE)


[style] ~129-~129: Consider removing “of” to be more concise
Context: ... the project - images - This houses all of the images used in the project - scss -...

(ALL_OF_THE)


[style] ~130-~130: Consider removing “of” to be more concise
Context: ...in the project - scss - This houses all of the scss files used in the project - `c...

(ALL_OF_THE)


[grammar] ~134-~134: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ...rms - _talawa.scss - Partial Sass file for Talawa - _utilities.scss - Pa...

(HE_VERB_AGR)


[grammar] ~135-~135: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... - _utilities.scss - Partial Sass file for utilities - _variables.scss -...

(HE_VERB_AGR)


[grammar] ~136-~136: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... - _variables.scss - Partial Sass file for variables - app.scss - Main S...

(HE_VERB_AGR)


[style] ~141-~141: Consider removing “of” to be more concise
Context: ...views/screens Constant - This houses all of the constants used in the project `GraphQl...

(ALL_OF_THE)


[style] ~143-~143: Consider removing “of” to be more concise
Context: ...in the project GraphQl - This houses all of the GraphQL queries and mutations used in t...

(ALL_OF_THE)


[style] ~145-~145: Consider removing “of” to be more concise
Context: ...in the project screens - This houses all of the views/screens to be navigated through i...

(ALL_OF_THE)


[style] ~147-~147: Consider removing “of” to be more concise
Context: ... in Talawa-Admin state - This houses all of the state management code for the project ...

(ALL_OF_THE)


[uncategorized] ~165-~165: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...following order: - React imports - Third party imports - Local imports If there is...

(EN_COMPOUND_ADJECTIVE_INTERNAL)

🪛 Markdownlint (0.37.0)

128-128: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


129-129: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


130-130: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


131-131: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


132-132: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


133-133: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


134-134: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


135-135: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


136-136: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


137-137: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


164-164: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


165-165: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


166-166: Expected: 0; Actual: 2
Unordered list indentation

(MD007, ul-indent)


57-57: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


73-73: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


75-75: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


92-92: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


190-190: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


230-230: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)


58-58: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


65-65: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


78-78: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


95-95: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


158-158: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


173-173: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


181-181: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


239-239: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


245-245: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


251-251: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

.github/workflows/pull-request.yml (1)

1-21: LGTM! Well-structured workflow configuration.

The workflow trigger and environment setup are properly configured.

runs-on: ubuntu-latest

steps:
- uses: actions/stale@v8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Update the stale action version for compatibility

The current version might have compatibility issues with the GitHub Actions runner.

- uses: actions/stale@v8
+ uses: actions/stale@v9
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- uses: actions/stale@v8
- uses: actions/stale@v9
🧰 Tools
🪛 actionlint (1.7.4)

28-28: the runner of "actions/stale@v8" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

Comment on lines +1 to +11
##############################################################################
##############################################################################
#
# NOTE!
#
# Please read the README.md file in this directory that defines what should
# be placed in this file
#
##############################################################################
##############################################################################

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing required stale workflow configuration in dedicated file

Based on the README.md guidelines, the stale workflow should be in a dedicated file since it requires a unique cron schedule, which falls under the "File Role Exceptions" section. However, the current file content only contains comments without any actual workflow configuration.

Key points from the guidelines that support this:

  • Jobs requiring unique cron: schedules should be in separate files
  • The file roles and sequences must be maintained
  • Changes should only be made on the advice of a contributor
🔗 Analysis chain

Verify the referenced README.md file exists

The header comments reference a README.md file that defines guidelines for this file. Let's verify its existence and content.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the README exists and contains workflow guidelines
if [[ -f ".github/workflows/README.md" ]]; then
    echo "README.md exists. Checking content:"
    cat ".github/workflows/README.md"
else
    echo "README.md not found in .github/workflows/"
fi

Length of output: 2225

🧰 Tools
🪛 yamllint (1.35.1)

[error] 6-6: trailing spaces

(trailing-spaces)

Comment on lines +1 to +98
{
"firstName": "First Name",
"lastName": "Last Name",
"searchByName": "Search By Name",
"loading": "Loading...",
"endOfResults": "End of results",
"noResultsFoundFor": "No results found for ",
"edit": "Edit",
"admins": "Admins",
"admin": "ADMIN",
"user": "USER",
"superAdmin": "SUPERADMIN",
"members": "Members",
"logout": "Logout",
"login": "Login",
"register": "Register",
"menu": "Menu",
"settings": "Settings",
"gender": "Género",
"users": "Users",
"requests": "Requests",
"OR": "OR",
"cancel": "Cancel",
"close": "Close",
"create": "Create",
"delete": "Delete",
"done": "Done",
"yes": "Yes",
"no": "No",
"filter": "Filter",
"search": "Search",
"description": "Description",
"saveChanges": "Save Changes",
"resetChanges": "Reset Changes",
"displayImage": "Display Image",
"enterEmail": "Enter Email",
"emailAddress": "Email Address",
"email": "Email",
"name": "Name",
"desc": "Description",
"enterPassword": "Enter Password",
"password": "Password",
"confirmPassword": "Confirm Password",
"forgotPassword": "Forgot Password ?",
"talawaAdminPortal": "Talawa Admin Portal",
"address": "Address",
"location": "Location",
"enterLocation": "Enter Location",
"joined": "Joined",
"startDate": "Start Date",
"endDate": "End Date",
"startTime": "Start Time",
"endTime": "End Time",
"My Organizations": "Mis Organizaciones",
"Dashboard": "Tablero",
"People": "Gente",
"Events": "Eventos",
"Venues": "Lugares",
"Action Items": "Elementos de Acción",
"Posts": "Publicaciones",
"Block/Unblock": "Bloquear/Desbloquear",
"Advertisement": "Publicidad",
"Funds": "Fondos",
"Membership Requests": "Solicitudes de Membresía",
"Plugins": "Complementos",
"Plugin Store": "Tienda de Complementos",
"Settings": "Configuraciones",
"createdOn": "Creado En",
"createdBy": "Creado Por",
"usersRole": "Rol del Usuario",
"changeRole": "Cambiar Rol",
"action": "Acción",
"removeUser": "Eliminar Usuario",
"remove": "Eliminar",
"viewProfile": "Ver Perfil",
"profile": "Perfil",
"noFiltersApplied": "No se aplicaron filtros",
"manage": "Administrar",
"searchResultsFor": "Resultados de búsqueda para {{text}}",
"none": "Ninguno",
"sort": "Ordenar",
"Donate": "Donar",
"addedSuccessfully": "{{item}} agregado con éxito",
"updatedSuccessfully": "{{item}} actualizado con éxito",
"removedSuccessfully": "{{item}} eliminado con éxito",
"successfullyUpdated": "Actualizado con éxito",
"sessionWarning": "Su sesión expirará pronto debido a la inactividad. Por favor, interactúe con la página para extender su sesión.",
"sessionLogOut": "Su sesión ha expirado debido a la inactividad. Por favor, inicie sesión nuevamente para continuar.",
"all": "Todos",
"active": "Activo",
"disabled": "Deshabilitado",
"pending": "Pendiente",
"completed": "Completado",
"late": "Tarde",
"createdLatest": "Creado más reciente",
"createdEarliest": "Creado más temprano",
"searchBy": "Buscar por {{item}}"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: Incorrect locale code and missing translations

  1. The locale code 'sp' should be 'es' according to ISO 639-1 standards.

  2. Most entries contain English text instead of Spanish translations (e.g., "firstName": "First Name" should be "firstName": "Nombre").

  3. Rename the file from sp/common.json to es/common.json

  4. Update the translations to Spanish. Here's a sample of corrections needed:

{
-  "firstName": "First Name",
+  "firstName": "Nombre",
-  "lastName": "Last Name",
+  "lastName": "Apellido",
-  "searchByName": "Search By Name",
+  "searchByName": "Buscar por nombre",
   // ... more translations needed
}

Committable suggestion skipped: line range outside the PR's diff.

"profile": "轮廓",
"noFiltersApplied": "未应用筛选器",
"manage": "管理",
"searchResultsFor": "搜索结果",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix inconsistent placeholder usage

The searchResultsFor translation uses a different placeholder than other locale files:

  • Other files: "searchResultsFor": "Resultados de búsqueda para {{text}}"
  • This file: "searchResultsFor": "搜索结果"
-  "searchResultsFor": "搜索结果",
+  "searchResultsFor": "搜索结果 {{text}}",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"searchResultsFor": "搜索结果",
"searchResultsFor": "搜索结果 {{text}}",

Comment on lines +282 to +283
"volunteerRankings": "Classement des Bénévoles",
"noVolunteers": "Aucun Bénévole Trouvé!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix inconsistent translations for "No Volunteers Found"

The same English text is translated differently in two places:

-    "volunteerRankings": "Classement des Bénévoles",
-    "noVolunteers": "Aucun Bénévole Trouvé!"
+    "volunteerRankings": "Classement des bénévoles",
+    "noVolunteers": "Aucun bénévole trouvé"

-    "noVolunteers": "Aucun Bénévole",
-    "noVolunteerGroups": "Aucun Groupe de Bénévoles",
+    "noVolunteers": "Aucun bénévole trouvé",
+    "noVolunteerGroups": "Aucun groupe de bénévoles trouvé",

Also applies to: 1415-1416

Comment on lines +776 to +788
type OrganizationCustomField {
_id: ID!
name: String!
organizationId: String!
type: String!
}

type OrganizationCustomField {
_id: ID!
name: String!
organizationId: String!
type: String!
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove duplicate type definitions.

The following types are defined multiple times:

  • OrganizationCustomField (lines 776-781 and 783-788)
  • UserPhone (lines 1348-1352 and 1407-1411)

This can cause schema validation errors.

Remove the duplicate definitions and keep only one instance of each type.

Also applies to: 1348-1352, 1407-1411

Comment on lines +67 to +71
enum AdvertisementType {
BANNER
MENU
POPUP
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove duplicate enum definition.

The AdvertisementType enum is defined twice with identical values. This will cause schema validation errors.

Remove one of the duplicate enum definitions.

Also applies to: 554-558

Comment on lines +618 to +625
createAdvertisement(
endDate: Date!
link: String!
name: String!
orgId: ID!
startDate: Date!
type: String!
): Advertisement!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Align createAdvertisement mutation with its input type.

The createAdvertisement mutation parameters don't match the CreateAdvertisementInput type:

  • Mutation uses link while input uses mediaFile
  • Input type is more structured and reusable

Update the mutation to use the input type:

-  createAdvertisement(
-    endDate: Date!
-    link: String!
-    name: String!
-    orgId: ID!
-    startDate: Date!
-    type: String!
-  ): Advertisement!
+  createAdvertisement(input: CreateAdvertisementInput!): CreateAdvertisementPayload!

Also applies to: 560-567

Comment on lines +271 to +273
interface Error {
message: String!
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Implement consistent error handling across the schema.

The schema has error interfaces but they aren't consistently used. Some mutations return simple types while others use payload types with error fields.

Implement a consistent error handling approach:

  1. Create a base MutationResponse interface:
interface MutationResponse {
  success: Boolean!
  message: String
  errors: [Error!]
}
  1. Create payload types for all mutations:
type CreateAdvertisementResponse implements MutationResponse {
  success: Boolean!
  message: String
  errors: [Error!]
  advertisement: Advertisement
}
  1. Update mutation return types to use response types:
-createAdvertisement(...): Advertisement!
+createAdvertisement(...): CreateAdvertisementResponse!

Also applies to: 1140-1146

Comment on lines +1 to +3
directive @auth on FIELD_DEFINITION

directive @role(requires: UserType) on FIELD_DEFINITION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Enhance authentication directive definition.

The @auth directive lacks parameter definitions which could limit its functionality for fine-grained access control.

Consider adding parameters to the directive:

-directive @auth on FIELD_DEFINITION
+directive @auth(
+  requires: UserType
+  allowedRoles: [String!]
+  allowSelf: Boolean = false
+) on FIELD_DEFINITION
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
directive @auth on FIELD_DEFINITION
directive @role(requires: UserType) on FIELD_DEFINITION
directive @auth(
requires: UserType
allowedRoles: [String!]
allowSelf: Boolean = false
) on FIELD_DEFINITION
directive @role(requires: UserType) on FIELD_DEFINITION

@palisadoes
Copy link
Contributor

This PR has too many submitted files that are out of scope of the original issue.

Please ensure the following:

  1. Fetch the latest upstream/develop-postgres files
  2. Make your PR modifications based on the local copy of this develop-postgres branch
  3. Submit your PRs against our develop-postgres branch.
  4. Your source branch in your local repository must not be the same as the target branch

Please ask the slack channels for assistance.

Closing

@pranavnathe pranavnathe deleted the Refactor-CSS-files branch December 24, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants