-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX]: Smooth scroll interruption resolved for USERS list. #2726
[FIX]: Smooth scroll interruption resolved for USERS list. #2726
Conversation
WalkthroughThe Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (1)
src/screens/Users/Users.tsx (1)
73-73
: Consider aligning tableLoaderRowLength with perPageResultThe loader displays 4 rows while actual data loads 12 rows per page. This mismatch could cause visual jumping when transitioning from loading to loaded state, potentially contributing to the scroll interruption issue.
- const tableLoaderRowLength = 4; + const tableLoaderRowLength = perPageResult;
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #2726 +/- ##
====================================================
+ Coverage 79.58% 86.35% +6.77%
====================================================
Files 295 312 +17
Lines 7274 8135 +861
Branches 1592 1841 +249
====================================================
+ Hits 5789 7025 +1236
+ Misses 1222 933 -289
+ Partials 263 177 -86 ☔ View full report in Codecov by Sentry. |
8a21cbb
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
This PR fixes bug related to interrupted scrolling of users list. Now the infinite scrolling of user list provides smoother experience.
Issue Number:
Fixes #2437
Did you add tests for your changes?
No
Snapshots/Videos:
Infinite-scroll-users-list.mp4
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit
New Features
Bug Fixes
Refactor