Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS in src/components/UserPortal/CreateGroupChat/CreateGroupChat.tsx #2894

Closed
palisadoes opened this issue Dec 26, 2024 · 9 comments
Assignees
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@palisadoes
Copy link
Contributor

Refactor CSS in this file

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

This file contains embedded CSS references that should be completely moved to:

  • src/style/app.module.css

Additional information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

The challenge:

The goal is for this file to use this new design pattern. This means that:

  1. All embedded CSS in this file must be merged into the global CSS file using pre-existing CSS.
  2. All embedded CSS in this file must be removed
@github-actions github-actions bot added refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Dec 26, 2024
@palisadoes palisadoes changed the title Refactor CSS in /src/components/UserPortal/CreateGroupChat/CreateGroupChat.tsx Refactor CSS in src/components/UserPortal/CreateGroupChat/CreateGroupChat.tsx Dec 26, 2024
@Coolsheru2526
Copy link

@palisadoes can I work on this issue?

Copy link

github-actions bot commented Jan 6, 2025

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 6, 2025
@Cioppolo14
Copy link
Contributor

Unassigning due to no activity.

@Coolsheru2526
Copy link

i am working on it will do it in 2 3 days

@palisadoes can I work on this issue?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 7, 2025
@palisadoes
Copy link
Contributor Author

We created an this issue to do basic changes to the CSS colors for consistency

The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly.

We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read.

When this is done we'll need your assistance to merge the screens into the develop branch with this issue.

If your screens have not been affected, then you should use the new methodology to refactor them.

This is an extraordinary circumstance. I hope you will appreciate the decision.

@palisadoes
Copy link
Contributor Author

Please proceed. The changes mentioned previously are mostly in components

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 25, 2025
@palisadoes
Copy link
Contributor Author

Unassigning. Inactivity

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 25, 2025
@pranavnathe
Copy link
Contributor

Please assign this issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: Done
Status: Done
Development

No branches or pull requests

4 participants