Resolve remaining method ambiguities #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sostock
commented
Mar 11, 2023
Comment on lines
-280
to
-282
| function Base.promote_rule(::Type{Level{L,R,S}}, ::Type{Quantity{T,D,U}}) where {L,R,S,T,D,U} | ||
| return promote_type(S, Quantity{T,D,U}) | ||
| end |
There was a problem hiding this comment.
Removing this method does not resolve ambiguities. I just removed it because it isn’t necessary.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #626 +/- ##
==========================================
+ Coverage 89.03% 89.07% +0.04%
==========================================
Files 16 16
Lines 1495 1492 -3
==========================================
- Hits 1331 1329 -2
+ Misses 164 163 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Julia ≥1.1, this resolves all method ambiguities
(edit: all method ambiguities that are found by. On Julia 1.0, there are 5 ambiguities remaining.AquaorTest.detect_ambiguities. #469 is still broken)Closes #604.
Edit 2: this PR now resolves #469 as well.