Merge pull request #3 from PaintSwap/calldata

use calldata

contracts/SamWitchVRF.sol

@@ -77,10 +77,10 @@ contract SamWitchVRF is ISamWitchVRF, UUPSUpgradeable, OwnableUpgradeable {
     address fulfillAddress,
     uint256 callbackGasLimit,
     uint256 numWords,
-    uint256[2] memory publicKey,
-    uint256[4] memory proof,
-    uint256[2] memory uPoint,
-    uint256[4] memory vComponents
+    uint256[2] calldata publicKey,
+    uint256[4] calldata proof,
+    uint256[2] calldata uPoint,
+    uint256[4] calldata vComponents
   ) external override returns (bool callSuccess) {
     if (!oracles[oracle]) {
       revert OnlyOracle();
@@ -127,9 +127,9 @@ contract SamWitchVRF is ISamWitchVRF, UUPSUpgradeable, OwnableUpgradeable {
   /// @param message The message (in bytes) used for computing the VRF
   /// @return The fast verify required parameters as the tuple `([uPointX, uPointY], [sHX, sHY, cGammaX, cGammaY])`
   function computeFastVerifyParams(
-    uint256[2] memory publicKey,
-    uint256[4] memory proof,
-    bytes memory message
+    uint256[2] calldata publicKey,
+    uint256[4] calldata proof,
+    bytes calldata message
   ) external pure returns (uint256[2] memory, uint256[4] memory) {
     return VRF.computeFastVerifyParams(publicKey, proof, message);
   }
@@ -177,7 +177,7 @@ contract SamWitchVRF is ISamWitchVRF, UUPSUpgradeable, OwnableUpgradeable {
     return success;
   }
 
-  function _randomValueFromVRFProof(uint256[4] memory _proof) private view returns (uint256 output) {
+  function _randomValueFromVRFProof(uint256[4] calldata _proof) private view returns (uint256 output) {
     return uint256(keccak256(abi.encode(block.chainid, _proof[0], _proof[1], _proof[2], _proof[3])));
   }
 

contracts/libraries/VRF.sol

@@ -75,8 +75,8 @@ library VRF {
   /// @param _message The message (in bytes) used for computing the VRF
   /// @return true, if VRF proof is valid
   function verify(
-    uint256[2] memory _publicKey,
-    uint256[4] memory _proof,
+    uint256[2] calldata _publicKey,
+    uint256[4] calldata _proof,
     bytes memory _message
   ) internal pure returns (bool) {
     // Step 2: Hash to try and increment (outputs a hashed value, a finite EC point in G)
@@ -105,11 +105,11 @@ library VRF {
   /// @param _vComponents The components required to compute `v` as `V = s*H - c*Gamma`
   /// @return true, if VRF proof is valid
   function fastVerify(
-    uint256[2] memory _publicKey,
-    uint256[4] memory _proof,
+    uint256[2] calldata _publicKey,
+    uint256[4] calldata _proof,
     bytes memory _message,
-    uint256[2] memory _uPoint,
-    uint256[4] memory _vComponents
+    uint256[2] calldata _uPoint,
+    uint256[4] calldata _vComponents
   ) internal pure returns (bool) {
     // Step 2: Hash to try and increment -> hashed value, a finite EC point in G
     (uint256 hPointX, uint256 hPointY) = hashToTryAndIncrement(_publicKey, _message);
@@ -186,8 +186,8 @@ library VRF {
   /// @param _message The message (in bytes) used for computing the VRF
   /// @return The fast verify required parameters as the tuple `([uPointX, uPointY], [sHX, sHY, cGammaX, cGammaY])`
   function computeFastVerifyParams(
-    uint256[2] memory _publicKey,
-    uint256[4] memory _proof,
+    uint256[2] calldata _publicKey,
+    uint256[4] calldata _proof,
     bytes memory _message
   ) internal pure returns (uint256[2] memory, uint256[4] memory) {
     // Requirements for Step 3: U = s*B - c*Y (where B is the generator)
@@ -206,7 +206,7 @@ library VRF {
   /// @param _message The message used for computing the VRF
   /// @return The hash point in affine cooridnates
   function hashToTryAndIncrement(
-    uint256[2] memory _publicKey,
+    uint256[2] calldata _publicKey,
     bytes memory _message
   ) internal pure returns (uint, uint) {
     // Step 1: public key to bytes