Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query to vendor #64

Merged
merged 1 commit into from
Mar 1, 2017
Merged

Add query to vendor #64

merged 1 commit into from
Mar 1, 2017

Conversation

heimweh
Copy link
Contributor

@heimweh heimweh commented Feb 2, 2017

This PR adds support for querying vendors.

This allows us to easier find vendors by name.

Example:

client.ListVendors(&pagerduty.ListVendorOptions{
    Query: "Datadog",
}

Tested and seems to work quite well.

@heimweh
Copy link
Contributor Author

heimweh commented Feb 20, 2017

Would be awesome to be able to query vendors by name like this.
Would any of you mind taking a look? :)

I'm not 100% sure if there are other options that should be in there as well.

//cc @ranjib @Deconstrained

@lfepp lfepp self-requested a review March 1, 2017 18:20
Copy link
Contributor

@lfepp lfepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfepp lfepp merged commit 473410b into PagerDuty:master Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants