Skip to content
This repository has been archived by the owner on Feb 5, 2018. It is now read-only.

Added statd host argument #56

Merged
merged 2 commits into from
Jan 27, 2017
Merged

Added statd host argument #56

merged 2 commits into from
Jan 27, 2017

Conversation

andrecloutier-pd
Copy link
Contributor

No description provided.

Copy link
Contributor

@theckman theckman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase this against my fork and open the PR there? I'd be more than happy to review it and cut a new release with it in it.

I've still been unable to get a commitment from PagerDuty to properly maintain this project. I'm worried this change won't get merged, and even if it does that a release won't be cut. I'm not even sure there's anyone still at PD who wants to maintain cronner.

@theckman
Copy link
Contributor

Unless this PR is inherently that commitment from PagerDuty...

@theckman
Copy link
Contributor

Also, I'd suggest not bumping the version in this PR. Instead I would merge this without the version change, and then increase the version to 0.3.0 in a separate change.

Version releases should be disjointed from feature additions.

@andrecloutier-pd
Copy link
Contributor Author

Hi @theckman . It certainly looks like you've been more active at maintaining cronner than we have. I'll merge your PR indicating that this repo is deprecated with a link to your fork. Though, for this particular change, I'm going to go ahead and apply it to our version.

@andrecloutier-pd andrecloutier-pd merged commit b355fd0 into master Jan 27, 2017
@theckman
Copy link
Contributor

@andrecloutier-pd thank you so much.

If you'd be interested in contributing your change, I'd love to have it in my version of cronner. I was thinking of doing this very recently as well, and would much-prefer the original author get the credit they deserve.

If you don't have time to contribute to the forked repo, I'd be more-than-happy to cherry-pick the change while ensuring you retain authorship for the feature.

@andrecloutier-pd
Copy link
Contributor Author

No worries. I'll send a PR your way either today or early next week. 👍

@andrecloutier-pd andrecloutier-pd deleted the add-statd-host-arg branch January 28, 2017 19:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants