Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decoder for deep asr model #753

Merged
merged 11 commits into from
Mar 27, 2018
Merged

Add decoder for deep asr model #753

merged 11 commits into from
Mar 27, 2018

Conversation

kuke
Copy link
Collaborator

@kuke kuke commented Mar 21, 2018 •
edited
Loading

Resolve #752

@kuke
Copy link
Collaborator Author

kuke commented Mar 22, 2018 •
edited
Loading

Usage

$python
>>>from post_decode_faster import Decoder
>>>decoder = Decoder(u"./graph/words.txt", u"./graph/TLG.fst", u"./logprior")
>>>res=decoder.decode("ark:kaldi_score.example")
>>> print res[0],'\n', res[1]
比于二零一五年一月将起抓获
饮片发布了第一批定中ANG照
>>>import numpy as np
>>>res=decoder.decode("BAC009S0765W0450", np.loadtxt("BAC009S0765W0450.txt"))
>>>print res
比于二零一五年一月将起抓获

@kuke kuke requested review from pengeorge, zhxfl and pkuyym March 22, 2018 02:40
pkuyym
pkuyym reviewed Mar 22, 2018
View reviewed changes
fluid/DeepASR/decoder/post_decode_faster.cc Outdated

#include "post_decode_faster.h"

using namespace kaldi;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid importing the whole namespace.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove later

fluid/DeepASR/decoder/post_decode_faster.cc Outdated
res += s;
if (s == "")
KALDI_ERR << "Word-id " << words[i] << " not in symbol table.";
std::cerr << s << ' ';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use KALDI_ERR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

zhxfl
zhxfl reviewed Mar 26, 2018
View reviewed changes
Copy link
Member

@zhxfl zhxfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkuyym
pkuyym reviewed Mar 26, 2018
View reviewed changes
fluid/DeepASR/decoder/post_decode_faster.cc Outdated
@@ -0,0 +1,143 @@
/* Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change 2016 to 2018?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

fluid/DeepASR/decoder/post_decode_faster.cc Outdated
}

std::string Decoder::decode(
std::string key, std::vector<std::vector<kaldi::BaseFloat>>& log_probs) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::vector<std::vectorkaldi::BaseFloat>& log_probs --> const std::vector<std::vectorkaldi::BaseFloat>& log_probs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

fluid/DeepASR/decoder/post_decode_faster.cc

kaldi::ParseOptions po(usage);
binary = true;
acoustic_scale = 1.5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these settings be configurable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily not necessary.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if acoustic_scale is configurable.

pkuyym
pkuyym approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@pkuyym pkuyym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuke kuke merged commit 4d9d141 into PaddlePaddle:develop Mar 27, 2018
pengeorge
pengeorge reviewed Mar 27, 2018
View reviewed changes
Copy link

@pengeorge pengeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengeorge pengeorge pengeorge left review comments

@zhxfl zhxfl zhxfl left review comments

@pkuyym pkuyym pkuyym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kuke @pengeorge @zhxfl @pkuyym