-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rnn_search_model #729
base: dev-static
Are you sure you want to change the base?
Add rnn_search_model #729
Conversation
ce13bd5
to
3fd720b
Compare
@peterzhang2029 I hope to know whether the multi-threaded/multi-card training can correctly work for RNN search model? Thank you. |
@lcy-seso 目前在多线程上面测试是可以work的,在多卡上面现在用的机器环境会有显存的问题,需要再验证一下。 |
好的~ 感谢。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small modifications.
@@ -0,0 +1,25 @@ | |||
source_dict_dim = 10000 | |||
target_dict_dim = 10000 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move line 1 ~ 2 into ModelConfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
target_dict_dim = model_conf.target_dict_dim | ||
is_generating = model_conf.is_generating | ||
beam_size = model_conf.beam_size | ||
max_length = model_conf.max_length |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 34 ~ 41, pass these configurations as function parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
paddle.reader.shuffle( | ||
paddle.dataset.wmt16.train(train_conf.source_dict_dim, | ||
train_conf.target_dict_dim), | ||
buf_size=1000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make buf_size
larger, for example, 100000.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
paddle.reader.shuffle( | ||
paddle.dataset.wmt16.test(train_conf.source_dict_dim, | ||
train_conf.target_dict_dim), | ||
buf_size=1000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make buf_size larger, for example, 100000.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
resolve #728