Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GRU support for DS2 model. #214

Merged
merged 4 commits into from
Sep 4, 2017
Merged

Add GRU support for DS2 model. #214

merged 4 commits into from
Sep 4, 2017

Conversation

xinghai-sun
Copy link
Contributor

@xinghai-sun xinghai-sun commented Aug 21, 2017 •
edited
Loading

Resolve #213

  1. Add GRU support for DS2 model.
  2. Replace all BRelu activator with Relu
  3. Set default GRU size to 1280.
  4. Set default striding step of first conv layer to 2 (from 3).

@xinghai-sun xinghai-sun requested review from kuke and pkuyym August 21, 2017 14:09
kuke
kuke reviewed Sep 4, 2017
View reviewed changes
Copy link
Collaborator

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkuyym
pkuyym approved these changes Sep 4, 2017
View reviewed changes
Copy link
Contributor

@pkuyym pkuyym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deep_speech_2/train.py
@@ -37,10 +37,15 @@
help="RNN layer number. (default: %(default)s)")
parser.add_argument(
"--rnn_layer_size",
default=512,
default=1280,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark here, replace by actual size later.

@lcy-seso lcy-seso merged commit 0d44c20 into PaddlePaddle:develop Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuke kuke kuke left review comments

@pkuyym pkuyym pkuyym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xinghai-sun @kuke @pkuyym @lcy-seso