Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 5th No.12】为Paddle新增AdaptiveLogSoftmaxWithLoss API #713

Closed

Conversation

liethann
Copy link

对之前放弃继续开发的AdaptiveLogSoftmaxWithLoss API的rfc进行修改,重新组织实现方式,将API分离为layer层和function,使API更易用,结构更清晰。并重新更换邮箱以解决pr中cla无法通过的问题

@paddle-bot
Copy link

paddle-bot bot commented Oct 20, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@@ -17,6 +17,8 @@ Paddle需要扩充API,新增 AdaptiveLogSoftmaxWithLoss API,
调用路径为:`paddle.nn.AdaptiveLogSoftmaxWithLoss` 和 `paddle.nn.functional.adaptive_log_softmax_with_loss`。
实现Softmax快速近似计算的功能。

## 2、功能目标
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

功能目标写上吧,写上这个API具体会做哪些事情,并补充计算公式

|提交作者<input type="checkbox" class="rowselector hidden"> | PeachML |
|提交时间<input type="checkbox" class="rowselector hidden"> | 2022-03-22 |
|提交作者<input type="checkbox" class="rowselector hidden"> | liethann |
|提交时间<input type="checkbox" class="rowselector hidden"> | 2023-10-20 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件名的时间也改一下吧

`paddle.nn.functional.adaptive_log_softmax_with_loss(input, label,
in_features, n_classes, cutoffs, div_value=4.0, head_bias=False, name=None)`, 返回为`NamedTuple` 包含 `output` 和 `loss`字段

- function API:`paddle.nn.functional.adaptive_log_softmax_with_loss(input, target, head_weight, head_bias, tail_weights, cutoffs, shortlist_size)` 用于训练计算
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充每个参数的含义

@luotao1
Copy link
Collaborator

luotao1 commented Dec 11, 2023

已经有 RFC 合入了,如果需要更新和完善,可以在原来的 RFC 上进行修改,感谢!

@luotao1 luotao1 closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants