Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 5th No.39】为 Paddle 新增 LPPool1D / LPPool2D API #709

Merged
merged 8 commits into from
Nov 21, 2023
Merged

【Hackathon 5th No.39】为 Paddle 新增 LPPool1D / LPPool2D API #709

merged 8 commits into from
Nov 21, 2023

Conversation

WintersMontagne10335
Copy link
Contributor

@WintersMontagne10335 WintersMontagne10335 commented Oct 19, 2023 •
edited
Loading

  • Description

本文档是第一部分的设计文档，主要关于上层实现。

@paddle-bot
Copy link

paddle-bot bot commented Oct 19, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备，具体请参考示例和模版。
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@Ligoml Ligoml mentioned this pull request Oct 20, 2023
Open
@WintersMontagne10335 WintersMontagne10335 deleted the winters011 branch October 25, 2023 03:13
@WintersMontagne10335 WintersMontagne10335 restored the winters011 branch October 25, 2023 03:15
@WintersMontagne10335 WintersMontagne10335 mentioned this pull request Oct 25, 2023
Closed
@WintersMontagne10335
Copy link
Contributor Author

@luotao1 涛姐，RFC可以review了

cyber-pioneer
cyber-pioneer reviewed Nov 7, 2023
View reviewed changes
rfcs/APIs/20231019_api_design_for_lp_pool.md
幂平均池化每个窗口的计算过程：

![39_1](https://github.com/WintersMontagne10335/doing/assets/118546135/eb928fe6-fff8-4c69-855a-82c933466583)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image 这里显示似乎有问题，请确认一下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

拖了好久才回您，抱歉哈 orz 。上周太忙了…
改了一下，您看现在可以吗？

cyber-pioneer
cyber-pioneer reviewed Nov 7, 2023
View reviewed changes
rfcs/APIs/20231019_api_design_for_lp_pool.md
`LPPool1d` 的公式如下:

![image](https://github.com/WintersMontagne10335/doing/assets/118546135/14e5652f-521c-4b2c-bda4-7857e481ec34)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

rfcs/APIs/20231019_api_design_for_lp_pool.md

`AVGPool1d` 的公式如下:
![image](https://github.com/WintersMontagne10335/doing/assets/118546135/9927757c-4c50-40aa-9e8a-ac3be01b54b0)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

cyber-pioneer
cyber-pioneer approved these changes Nov 21, 2023
View reviewed changes
Copy link

@cyber-pioneer cyber-pioneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyber-pioneer cyber-pioneer merged commit 7cd7577 into PaddlePaddle:master Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyber-pioneer cyber-pioneer cyber-pioneer approved these changes

Assignees

@luotao1 luotao1

@cyber-pioneer cyber-pioneer

Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WintersMontagne10335 @cyber-pioneer @luotao1