【Hackathon 5th No.29】为 Paddle 新增 cholesky_inverse API #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Charles-hit
reviewed
Oct 12, 2023
|
|
||
| 初步实现方案如下： | ||
|
|
||
| 1) 检查输入x, 对输入Tensor x做broadcast shape。 |
|
|
||
| 1) 检查输入x, 对输入Tensor x做broadcast shape。 | ||
| 2) 检查是否需要转置(行优先还是列优先)。 | ||
| 3) 调用paddle cholesky api进行计算。 |
| # 六、测试和验收的考量 | ||
| 1. 结果正确性: | ||
| - 前向计算: `paddle.cholesky_inverse`计算结果与 `torch.cholesky_inverse` 计算结果一致。 | ||
| - 反向计算:由 Python 组合新增 API 无需验证反向计算。 |
| 3) 调用paddle cholesky api进行计算。 | ||
| 4) 检查输出, 存储Tensor。 | ||
|
|
||
| # 六、测试和验收的考量 |
Charles-hit
reviewed
Oct 12, 2023
|
|
||
| # 六、测试和验收的考量 | ||
| 1. 结果正确性: | ||
| - 前向计算: `paddle.cholesky_inverse`计算结果与 `torch.cholesky_inverse` 计算结果一致。 |
There was a problem hiding this comment.
框架中测试应该是与numpy去比较，numpy若没有相应函数则需要用numpy进行组合。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Docs
Description
【Hackathon 5th No.29】为 Paddle 新增cholesky_inverse API