Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python path typo in the start dev server script #253

Merged
merged 4 commits into from
Feb 5, 2018
Merged

Fix python path typo in the start dev server script #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
863a1db
Fix python path typo in the start dev server script
jetfuel Feb 5, 2018
1ee852a
Switch to use trap
jetfuel Feb 5, 2018
c63c6c9
capture more signal.
jetfuel Feb 5, 2018
caa5f96
Merge branch 'develop' into statDevServerScript
jetfuel Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/setup_dev_env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ cd build
cmake ..
make -j $processors

export PYTHON_PATH=$PYTHON_PATH:"$SCRIPT_DIR/.."
export PYTHONPATH=$PYTHONPATH:"$SCRIPT_DIR/.."
12 changes: 11 additions & 1 deletion scripts/start_dev_server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,19 @@ CURRENT_DIR=`pwd`
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

cd $SCRIPT_DIR/../frontend
export PYTHONPATH=$PYTHONPATH:"$SCRIPT_DIR/.."

./node_modules/.bin/webpack --watch --config tool/webpack.dev.config.js --output-path=../visualdl/server/dist &
# Track webpack pid
WEBPACKPID=$!

function finish {
kill -9 $WEBPACKPID
}

export PYTHON_PATH=$PYTHON_PATH:"$SCRIPT_DIR/.."
trap finish EXIT HUP INT QUIT PIPE TERM

cd $CURRENT_DIR

#Run the visualDL with local PATH
python ${SCRIPT_DIR}/../visualdl/server/visualDL "$@"