Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace view with reshape in aishell/asr1 #3887

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Nov 14, 2024

PR types

Others

PR changes

Others

Describe

This pull request focuses on refactoring the code to replace the usage of the view method with the reshape method for better readability and consistency across multiple files. The changes primarily affect the paddlespeech/s2t/models/u2/u2.py and paddlespeech/s2t/modules/attention.py files.

Key Changes:

Refactoring view to reshape:

Copy link

paddle-bot bot commented Nov 14, 2024

Thanks for your contribution!

Copy link

mergify bot commented Nov 14, 2024

This pull request is now in conflict :(

@mergify mergify bot added conflicts S2T asr/st labels Nov 14, 2024
@mergify mergify bot removed the conflicts label Nov 14, 2024
Copy link
Collaborator

@zxcd zxcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxcd zxcd merged commit 62c21e9 into PaddlePaddle:develop Nov 15, 2024
5 checks passed
@GreatV GreatV deleted the replace_view_with_reshape branch November 15, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants