Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PPSCI Doc No.93-96, 98-102】 #730

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

NKNaN
Copy link
Contributor

@NKNaN NKNaN commented Dec 31, 2023

PR types

Others

PR changes

Docs

Describe

PPSCI Doc No.93-96, 98-102

Copy link

paddle-bot bot commented Dec 31, 2023

Thanks for your contribution!

Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦大佬

Comment on lines 245 to 251
>>> arr = np.array([[1., 2., 3.], [4., 5., 6.]])
>>> result = ppsci.utils.misc.convert_to_dict(arr, ("x", "y", "z"))
>>> print(result)
{'x': array([[1.],
[4.]]), 'y': array([[2.],
[5.]]), 'z': array([[3.],
[6.]])}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里可以打印一下arr.shape,然后用for循环打印一下result里的k, v.shape,这样子能更直观

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

Comment on lines 367 to 371
<BLANKLINE>
[[1., 2.],
[3., 4.]]]), 'y': array([[[5., 6.],
[7., 8.]],
<BLANKLINE>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的两处感觉不是很有必要,删掉也行?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除

Comment on lines 373 to 377

[[1., 2.],
[3., 4.]]]), 'y': array([[[5., 6.],
[7., 8.]],

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要空行的原因是什么呢,可以删除吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除

Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit fcdca41 into PaddlePaddle:develop Jan 3, 2024
3 checks passed
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants