【Hackathon 8th No.14】CoNFiLD 论文复现 #1094
Conversation
|
Thanks for your contribution! |
|
ADream_ki seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
你好，麻烦签署一下cla |
已经签署了，数据和权重文件还在转 |
|
请先提交 RFC 设计文档 |
已经加上了，请review |
|
请问权重文件和推理所用的文件该如何上传？ @HydrogenSulfate |
可以发送到[email protected]，我上传后发你链接，你再更新到文档里 |
权重文件已经发送过去了 |
| data_path: /home/xinyang/store/projects/nfdiff/algo/elbow/uvp.npy | ||
| coor_path: /home/xinyang/store/projects/nfdiff/algo/elbow/coor.npy |
There was a problem hiding this comment.
建议使用相对路径，可以是./data/xxx.npy
There was a problem hiding this comment.
建议使用相对路径，可以是./data/xxx.npy
推理文件我通过邮箱发过去了，这里是还没替换
There was a problem hiding this comment.
建议使用相对路径，可以是./data/xxx.npy
请问那些数据文件的链接可以提供一下吗？ 我发到邮箱了的
examples/confild/confild.py
Outdated
| from ppsci.utils import logger | ||
|
|
||
|
|
||
| class Normalizer(object): |
There was a problem hiding this comment.
| class Normalizer(object): | |
| class Normalizer: |
examples/confild/confild.py
Outdated
|
|
||
|
|
||
| class Normalizer(object): | ||
| def __init__(self, params=[], method="-11", dim=None): |
There was a problem hiding this comment.
参数最好不要使用如[]、{}这种可变类型
examples/confild/confild.py
Outdated
| class Normalizer(object): | ||
| def __init__(self, params=[], method="-11", dim=None): | ||
| self.params = params | ||
| self.method = method | ||
| self.dim = dim | ||
|
|
||
| def fit_normalize(self, data): | ||
| raise NotImplementedError | ||
|
|
||
| def normalize(self, new_data): | ||
| raise NotImplementedError | ||
|
|
||
| def denormalize(self, new_data_norm): | ||
| raise NotImplementedError | ||
|
|
||
| def get_params(self): | ||
| raise NotImplementedError | ||
|
|
There was a problem hiding this comment.
建议去掉Normalizer，直接合并到Normalizer_ts里代码会更简单
There was a problem hiding this comment.
建议去掉Normalizer，直接合并到Normalizer_ts里代码会更简单
Done
| data_path: /home/xinyang/store/projects/nfdiff/algo/elbow/uvp.npy | ||
| coor_path: /home/xinyang/store/projects/nfdiff/algo/elbow/coor.npy | ||
|
|
||
| normalizer: | ||
| method: '-11' | ||
| dim: 0 | ||
| batch_size: 4 |
There was a problem hiding this comment.
移动到INFER字段下面，并且batch_size是重复的字段
There was a problem hiding this comment.
移动到INFER字段下面，并且batch_size是重复的字段
Done
PR types
New features
PR changes
APIs
Describe
【Hackathon 8th No.14】CoNFiLD 论文复现
PaddlePaddle/community#1080