Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine readme #611

Merged
merged 10 commits into from
Feb 24, 2018
Merged

Refine readme #611

merged 10 commits into from
Feb 24, 2018

Conversation

typhoonzero
Copy link
Collaborator

Fix #591

Copy link
Collaborator

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar plugin may be useful.

README.md Outdated
@@ -3,148 +3,88 @@
[![Build Status](https://travis-ci.org/PaddlePaddle/cloud.svg?branch=develop)](https://travis-ci.org/PaddlePaddle/cloud)

PaddlePaddle Cloud is a Distributed Deep-Learning Cloud Platform for both cloud
providers and enterprises.
providers and enterprises. PaddlePaddle Cloud provide cluster Deep-Learning
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide=>provides

README.md Outdated
- Manage cluster Deep-Learning jobs use a command-line client very easily.
- Elastic Deep-Learning ([EDL](./doc/edl/README.md)) enables maximizing cluster resource utilities
and reduce average job pending time.
- Manages thousands of GPUs in cluster.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in cluster=>in a cluster

README.md Outdated
- Elastic Deep-Learning ([EDL](./doc/edl/README.md)) enables maximizing cluster resource utilities
and reduce average job pending time.
- Manages thousands of GPUs in cluster.
- Fault tolerant distributed training with zero down time.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

down time=>downtime

README.md Outdated
- Elastic Deep-Learning ([EDL](./doc/edl/README.md)) enables maximizing cluster resource utilities
and reduce average job pending time.
- Manages thousands of GPUs in cluster.
- Fault tolerant distributed training with zero down time.

PaddlePaddle Cloud use [Kubernetes](https://kubernetes.io) as it's backend job
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use=>uses

README.md Outdated
large scale GPU clusters.

## Using Command-line To Submit Cloud Training Jobs
as the deep-learning frame work.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frame work=>framework

README.md Outdated

- Server side components includes:
- Cloud Server
A REST API server accepts incomming request from lommand-line client, and submit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incomming=>incoming
lommand-line=>the command-line

README.md Outdated
A Kubernetes [Controller](https://kubernetes.io/docs/concepts/api-extension/custom-resources/#custom-controllers)
to enable automatically scale up/down jobs to maximize cluster performance.
- PaddlePaddle Cloud Job runtime Docker image.
- Client side component:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Client side=>Client-side

README.md Outdated
- PaddlePaddle Cloud Job runtime Docker image.
- Client side component:
- Command-Line client
Client for submit, list and kill cluster training jobs. Then code is under
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

submit=>submitting

README.md Outdated
- Client side component:
- Command-Line client
Client for submit, list and kill cluster training jobs. Then code is under
`go/cmd/paddlecloud`, And, code under `go/cmd/paddlecloud` will deprecate and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depreciate

README.md Outdated

## User Manuals

[快速开始](./doc/tutorial_cn.md)

[中文手册](./doc/usage_cn.md)

English tutorials(comming soon...)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coming

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated using Grammarly

Copy link
Collaborator

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar plugin may be useful.

README.md Outdated
- Cloud Server
A REST API server accepts incomming request from lommand-line client, and submit
`TrainingJob` resource to Kubernetes cluster. Cloud Server is written using
`Django` framework under `python` directory.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloud you add a link for the python directory.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use directory names in this section to prevent link change, detailed directory description can be found at the bottom.

README.md Outdated
`TrainingJob` resource to Kubernetes cluster. Cloud Server is written using
`Django` framework under `python` directory.
- PaddleFS
On cloud file management server used to upload user training job python programs,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Paddle FS is a general distributed file system on Cloud, so maybe it's not only used for training job python programs or trained models.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added "etc."

README.md Outdated
EMAIL_BACKEND = 'django_sendmail_backend.backends.EmailBackend'
.
├── demo: distributed version of https://github.com/PaddlePaddle/book programs
├── doc: documents
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are two sub dir in doc, design and deploy

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite easy to understand what they are under the doc directory, so I omitted them.

@typhoonzero typhoonzero requested a review from putcn February 11, 2018 07:42
Copy link

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @typhoonzero for this PR! I tried to make it slightly more concise in typhoonzero#1.

README.md Outdated
@@ -3,148 +3,88 @@
[![Build Status](https://travis-ci.org/PaddlePaddle/cloud.svg?branch=develop)](https://travis-ci.org/PaddlePaddle/cloud)

PaddlePaddle Cloud is a Distributed Deep-Learning Cloud Platform for both cloud
providers and enterprises.
providers and enterprises. PaddlePaddle Cloud provides cluster Deep-Learning

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can change this paragraph into:

PaddlePaddle Cloud is a combination of PaddlePaddle and Kubernetes. It supports fault-recoverable and fault-tolerant large-scaled distributed deep learning. We can deploy it on public cloud and on-premise clusters.

PaddlePaddle Cloud includes the following components:

README.md Outdated
providers and enterprises. PaddlePaddle Cloud provides cluster Deep-Learning
features including:

- Manage cluster Deep-Learning jobs use a command-line client very easily.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • paddlectl: A command-line tool that talks to paddlecloud, which in turn talks to Kbuernetes's API server.
  • paddlecloud: An HTTP server that is a portal of the deep learning cloud service. It exposes PaddlePaddle Cloud as a Web service.
  • EDL (elastic deep learning): A Kubernetes controller that supports elastic scheduling of deep learning jobs and other jobs.
  • Fault-tolerant distributed deep learning: This part is implemented in the Paddle repo.

doc/build.md Outdated

## Build paddlectl client

See [here](./build_edl_controller.md) to prepare Go and `glide` environment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems no ./build_edl_controller.md .

README.md Outdated
./manage.py runserver
PaddlePaddle Cloud is a combination of PaddlePaddle and Kubernetes. It
supports fault-recoverable and fault-tolerant large-scaled distributed
deep learning. We can deploy it on public cloud and on-premise
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A redundant blank space before the word We.

gongweibao
gongweibao previously approved these changes Feb 11, 2018
Copy link
Collaborator

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typhoonzero typhoonzero merged commit 735177d into PaddlePaddle:develop Feb 24, 2018
@typhoonzero typhoonzero deleted the refine_readme branch February 24, 2018 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants